This allows tests to be run with yarn jest
from packages/client/
and packages/server/
folders.
Some server tests are still failing (tests which involve database or networking interactions), and these still need to be fixed or removed.
This works for me locally!
Dan Visel (4593f17a) at 22 Mar 10:11
Dan Visel (c390dfc4) at 22 Mar 10:11
Merge branch 'xsweet-mathtype-update' into 'main'
... and 1 more commit
This just bumps the image of cokoapp/xsweet to use the updated version which handles more MathType issues.
Dan Visel (4593f17a) at 22 Mar 06:38
took out yarn version
Oh bother, no. This is what Yarn has been doing when I do yarn cz
recently – really not sure why, I wish it wouldn't.
This just bumps the image of cokoapp/xsweet to use the updated version which handles more MathType issues.
Dan Visel (af5fab5f) at 21 Mar 13:45
feat(models): update cokoapps/xsweet for more mathtype functionality
Dan Visel (59a1396b) at 21 Mar 12:27
See #1548
Actually, this looks good! I'm happy with the code changes & I've tested it.
(closing this, this one is better: !10 (merged) )
This changes the MathType processing code to deal with inline equations and edge situations found in a particular document from Amnet. Sometimes LaTeX was being exported that included inline MTEF XML, which contains positioning and color data that can't be represented in vanilla LaTeX; this strips that out. This is not stripping out all XML tags (which might look very much like valid LaTeX); it only strips out the tags that were represented in that document. I've asked for more sample MathType documents to see how often this issue comes up, but haven't yet received them. This does post a warning if it does encounter something in LaTeX from Mathtype that looks like XML so that we can better diagnose this issue in the future.
Trying to get a cleaner branch to make the changes more clear!
This changes the MathType processing code to deal with inline equations and edge situations found in a particular document from Amnet. Sometimes LaTeX was being exported that included inline MTEF XML, which contains positioning and color data that can't be represented in vanilla LaTeX; this strips that out. This is not stripping out all XML tags (which might look very much like valid LaTeX); it only strips out the tags that were represented in that document. I've asked for more sample MathType documents to see how often this issue comes up, but haven't yet received them. This does post a warning if it does encounter something in LaTeX from Mathtype that looks like XML so that we can better diagnose this issue in the future.
All of this is behind the math flag, so it should not affect anything that's not using this (or anything that's not converting WMF to LaTeX).
Dan Visel (6b5179e0) at 20 Mar 10:17
feat(service): more mathtype fixes, this time in a clean branch
Dan Visel (2d88abd3) at 20 Mar 06:36
fix(api): fix for crossref years
Dan Visel (f9b699ba) at 20 Mar 05:50
This MR makes inline LaTeX appear correctly – the baseline should match the baseline of paragraph text, and the font size is not as tiny as it was.
Dan Visel (9e31e28f) at 20 Mar 05:50
Merge branch 'latex-size-fixing' into 'main'
... and 1 more commit