ncbi issueshttps://gitlab.coko.foundation/groups/ncbi/-/issues2022-04-08T12:37:35Zhttps://gitlab.coko.foundation/ncbi/ncbi/-/issues/698Don't show "TOC?" label before the user can provide the missing value2022-04-08T12:37:35ZDione Mentisdione@coko.foundationDon't show "TOC?" label before the user can provide the missing value@danjela
The "TOC?" is a big improvement, but we shouldn't show it in all cases. This label is meant to signal to the user that the ordering value is missing -- we should not show this label before the user can take any action to fix t...@danjela
The "TOC?" is a big improvement, but we shouldn't show it in all cases. This label is meant to signal to the user that the ordering value is missing -- we should not show this label before the user can take any action to fix the issue (therefore only show after the file has been processed).
1. [x] Show label for statuses:
* Conversion errors
* Loading preview
* Loading errors
* Tagging errors
* Previewing
2. [x] Add alt-text for the "TOC?" label: Ordering value missing from metadataSept 01Danjela Shehidanjelashehi@gmail.comDanjela Shehidanjelashehi@gmail.comhttps://gitlab.coko.foundation/ncbi/ncbi/-/issues/625Send TOC package in cron job2022-03-01T19:39:49ZDione Mentisdione@coko.foundationSend TOC package in cron job@John.kopanas
This workflow we discussed for sending TOCs to NCBI applies to all chapter-processed books:
1. The TOC gets created or updated when any book component is published
2. Daily at 2 am Eastern Time (ET) send all the created...@John.kopanas
This workflow we discussed for sending TOCs to NCBI applies to all chapter-processed books:
1. The TOC gets created or updated when any book component is published
2. Daily at 2 am Eastern Time (ET) send all the created or updated TOC packages to Load to PMC
**Specs**
Send the toc to Load to PMC as its own package to `ingest/chapter`. NCBI expects a zip file containing the `toc.xml` and the book cover image, and a corresponding JSON file with:
* `"chapter": "toc"`
* `"xml_file":"toc.xml"`
* `"version":"1"`
* `"thumb": "filename"` (the book cover file name).Aug 01.Giannis Kopanasjkopanas@gmail.comGiannis Kopanasjkopanas@gmail.comhttps://gitlab.coko.foundation/ncbi/ncbi/-/issues/629Include section headings in toc.xml2021-11-09T17:37:11ZDione Mentisdione@coko.foundationInclude section headings in toc.xml@andynicholson
Refer to the [toc-template-main.xml](/uploads/59c90fbdb0f1ec9668da95d6e07606df/toc-template-main.xml) for guidance on adding the section headings as in [this rendered example](https://www.ncbi.nlm.nih.gov/books/NBK555156...@andynicholson
Refer to the [toc-template-main.xml](/uploads/59c90fbdb0f1ec9668da95d6e07606df/toc-template-main.xml) for guidance on adding the section headings as in [this rendered example](https://www.ncbi.nlm.nih.gov/books/NBK555156/)
```
<nav-pointer>
<related-object document-id="chaper1" document-type="chapter">
<?xml_file chapter1.xml?>
<?version 3?>
</related-object>
</nav-pointer>
<!--
For chapters in the body, include entries for the main sections of the chapter
- @object-id contains the XML ID of the target section
- @object-type is the name of the target element
The sections can be identfied by the following XPath:
/book-part-wrapper/*/book-part-meta/abstract[title]
| /book-part-wrapper/*/front-matter/*[title | toc-title-group | book-part-meta/title-group]
| /book-part-wrapper/*/body/sec[not(@sec-type = 'link-group', 'figs-and-tables')]
| /book-part-wrapper/*/back/*[(title | toc-title-group | index-title-group) and not(@sec-type = 'link-group', 'figs-and-tables')]
| /book-part-wrapper/*/back/app-group[not(title)]/app[title]
| /book-part-wrapper/*/back/index-group[not(index-title-group)]/index[index-title-group]
| /book-part-wrapper/*/*/toc-group[not(toc-title-group)]/toc[toc-title-group]
-->
<toc-entry>
<label>I.1.1</label>
<title>Section</title>
<nav-pointer>
<related-object document-id="chaper1" document-type="chapter" object-id="ch1.s1" object-type="sec"/>
</nav-pointer>
</toc-entry>
```
Section heading are only included for components in the body section: as documented [here](https://gitlab.coko.foundation/ncbi/ncbi/-/wikis/Workflows/Word-source-books#placement-in-frontbodyback): `<book-part book-part-type="chapter"` and `<book-part book-part-type="section"`.
These should always be included, irrespective of the TOC setting in the UI -- the setting chosen determines what gets rendered on Bookshelf (through the domain service integration).Oct.02.Dione Mentisdione@coko.foundationSidorela UkuDione Mentisdione@coko.foundationhttps://gitlab.coko.foundation/ncbi/ncbi/-/issues/680toc.xml tagging issues2021-09-22T16:27:17ZStacy Lathroptoc.xml tagging issues@DioneMentis @jordandc
## Expected behaviour
The toc.xml should match specifications and samples at: https://gitlab.coko.foundation/ncbi/ncbi/-/issues/24
## Current behaviour
See discrepancies between toc.xml we tested and the sampl...@DioneMentis @jordandc
## Expected behaviour
The toc.xml should match specifications and samples at: https://gitlab.coko.foundation/ncbi/ncbi/-/issues/24
## Current behaviour
See discrepancies between toc.xml we tested and the samples provided in attachment - [toc-meta-check_20210903.docx](/uploads/2ebbf942952d0abf8abddb5a1af26ad1/toc-meta-check_20210903.docx)
## Steps to reproduce
1. Go to: https://ncbi.cloud68.co/organizations/32d78686-4b9a-46af-b52a-f5d0c4052177/bookmanager/be91e860-bbca-422d-a74f-1af83b0bf3c0
2. Go to TOC preview link
3. Download toc.xml
4. Compare toc.xml to those in issue #24
5. See filename in attached Word doc documenting issues to see source data to be used to build the toc.xml
## Environment
N/A
## Priority
Accurate toc.xml is a priority in following order, 1) minimally to display per current display on Bookshelf AND 2) build wholebook PDFs
Items in red in Word attachment need further testing and review when we can load and see a Bookshelf preview of the TOC to test use case 1 (use case 2 can't be fully tested yet, integration depends on toc.xml build to be complete)
1. Resolving this bug is required for migration (Y/N) Y - per dependencies above
2. This can be prioritised after migration (Y/N) TBD per comments aboveAndy NicholsonAndy Nicholsonhttps://gitlab.coko.foundation/ncbi/ncbi/-/issues/309Empty contrib nodes should not be included in toc.xml file2021-09-22T16:27:17ZStacy LathropEmpty contrib nodes should not be included in toc.xml fileProbably related to issue #286
editor and author empty elements behave differently as seen in the downloadable toc (see "null" for some empty editor elements):
[toc_blank-contribs.xml](/uploads/50f99e271b27b3a2a7636ebe9c252879/toc_bl...Probably related to issue #286
editor and author empty elements behave differently as seen in the downloadable toc (see "null" for some empty editor elements):
[toc_blank-contribs.xml](/uploads/50f99e271b27b3a2a7636ebe9c252879/toc_blank-contribs.xml)
Neither should be there.
Also display is inconsistent:
![image](/uploads/cbe41fb9d7eda8311424a577c76aa3ae/image.png)Cycle scheduling WIPDione Mentisdione@coko.foundationDione Mentisdione@coko.foundationhttps://gitlab.coko.foundation/ncbi/ncbi/-/issues/674Problem manually dragging contents in TOC2021-09-22T16:27:17ZStacy LathropProblem manually dragging contents in TOCcc @jordandc
## Expected behaviour
When user drags contents it should easily move down (or where they drag the content)
## Current behaviour
User moved a chapter down, but it jumped up in the TOC
## Steps to reproduce
See video: [...cc @jordandc
## Expected behaviour
When user drags contents it should easily move down (or where they drag the content)
## Current behaviour
User moved a chapter down, but it jumped up in the TOC
## Steps to reproduce
See video: [127.0.0.2_3390_-_Remote_Desktop_Connection_2021-08-27_16-04-23.zip](/uploads/29bd3bb297d2f994caf2795013cf3b2d/127.0.0.2_3390_-_Remote_Desktop_Connection_2021-08-27_16-04-23.zip)
https://ncbi.cloud68.co/organizations/32d78686-4b9a-46af-b52a-f5d0c4052177/bookmanager/20f78f65-99e4-4607-accb-c109e35e435e/
1.Try drag a chapter down
## Environment
PC Chrome Version 92.0.4515.159 (Official Build) (64-bit)
# Priority
If can eventually move contents to the right place with trial and error, this bug can move to backlog (post deployment)Sept 01Sidorela UkuDanjela Shehidanjelashehi@gmail.comSidorela Ukuhttps://gitlab.coko.foundation/ncbi/ncbi/-/issues/662When a component is created (by file upload), place it at the top of the body...2021-09-22T16:27:17ZDione Mentisdione@coko.foundationWhen a component is created (by file upload), place it at the top of the body section## Expected behaviour
Chapter-processed books can have 100+ chapters. When users create new chapters (by file upload), they should see it placed at the top of the body section so that it's quick to select them and submit.
## Current b...## Expected behaviour
Chapter-processed books can have 100+ chapters. When users create new chapters (by file upload), they should see it placed at the top of the body section so that it's quick to select them and submit.
## Current behaviour
It's difficult to tell what the current rules are in all use cases, but it varies depending on what TOC order is selected, as I experienced in [this book](https://ncbidev.cloud68.co/organizations/a2c1e381-f348-41a9-9d76-e4f11f761033/bookmanager/e8cc2fd2-8136-43f4-9575-ae5ec9644f82).
1. When the TOC ordering is set to `A-Z`, new chapters are placed in A-Z order (probably because new uploads have default "Untitled" as the title metadata field).
2. When the TOC ordering is set to `Chapter number` or `date created`, new chapters are placed at the bottom of the body section
3. When the TOC ordering is set to `date updated`, new chapters are placed at the bottom of the body section
4. When the TOC ordering is set to `manual`, new chapters are placed at the second from the top of the body section
## Steps to reproduce
For the use cases above, I started with 7 chapters in Previewing status shown in the correct TOC order. then:
* changed TOC ordering value, upload files
* repeat for all casesSept 01Sidorela UkuDanjela Shehidanjelashehi@gmail.comSidorela Ukuhttps://gitlab.coko.foundation/ncbi/ncbi/-/issues/311Add book part labels to book manager page2021-09-22T16:27:16ZStacy LathropAdd book part labels to book manager pageCannot see label in the Book landing page. If select order by "chapter number" it becomes extremely difficult - nearly impossible - for user to tell if it is correct or not.Cannot see label in the Book landing page. If select order by "chapter number" it becomes extremely difficult - nearly impossible - for user to tell if it is correct or not.Post Phase 1