From 55b8d5dcbe7a525480282b3edee8d99c92d8d73f Mon Sep 17 00:00:00 2001
From: Jure Triglav <juretriglav@gmail.com>
Date: Mon, 14 Sep 2020 11:19:52 +0200
Subject: [PATCH] fix: don't call setToggle on every render
---
.../component-review/src/components/decision/DecisionReview.js | 2 +-
.../component-submit/src/components/molecules/Accordion.js | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/app/components/component-review/src/components/decision/DecisionReview.js b/app/components/component-review/src/components/decision/DecisionReview.js
index 82b39bcf98..db417a6fab 100644
--- a/app/components/component-review/src/components/decision/DecisionReview.js
+++ b/app/components/component-review/src/components/decision/DecisionReview.js
@@ -77,7 +77,7 @@ const DecisionReview = ({ review, reviewer }) => {
const journal = useContext(JournalContext)
const [open, setOpen] = useState(false)
- const toggleOpen = setOpen(!open)
+ const toggleOpen = () => setOpen(!open)
return (
<Root>
diff --git a/app/components/component-submit/src/components/molecules/Accordion.js b/app/components/component-submit/src/components/molecules/Accordion.js
index a0925a1a75..0e9e895130 100644
--- a/app/components/component-submit/src/components/molecules/Accordion.js
+++ b/app/components/component-submit/src/components/molecules/Accordion.js
@@ -97,7 +97,7 @@ const AccordionHeading = ({
const Accordion = ({ ordinal, title, status, Component, withDots }) => {
const [open, setOpen] = useState(false)
- const toggleOpen = setOpen(!open)
+ const toggleOpen = () => setOpen(!open)
return (
<Root>
--
GitLab