From 904245635ec852d18ed6fb2aff9c8b16488bcd33 Mon Sep 17 00:00:00 2001
From: Ema Suarasan <beatrice.suarasan@endava.com>
Date: Tue, 13 Apr 2021 17:59:25 +0300
Subject: [PATCH] test: fix unused method

---
 .../integration/elife/form_builer_page_spec.js  |  2 +-
 .../integration/elife/manuscripts_page_spec.js  | 17 ++++++++---------
 .../integration/ncrc/form_builder_page_spec.js  |  3 +--
 .../integration/ncrc/manuscripts_page_spec.js   |  1 -
 4 files changed, 10 insertions(+), 13 deletions(-)

diff --git a/cypress/integration/elife/form_builer_page_spec.js b/cypress/integration/elife/form_builer_page_spec.js
index 303c46780f..c492045c3b 100644
--- a/cypress/integration/elife/form_builer_page_spec.js
+++ b/cypress/integration/elife/form_builer_page_spec.js
@@ -88,7 +88,7 @@ describe('Form builder page tests', () => {
       })
       ManuscriptsPage.getTableHeader().should('be.visible')
       ManuscriptsPage.clickSubmit()
-      NewSubmissionPage.clickSubmitUrlAndVerifyLink()
+      NewSubmissionPage.clickSubmitUrlAndWaitPageLoad()
     })
 
     // check if the form contain all the columns
diff --git a/cypress/integration/elife/manuscripts_page_spec.js b/cypress/integration/elife/manuscripts_page_spec.js
index 67cf3d6a59..0e6154790d 100644
--- a/cypress/integration/elife/manuscripts_page_spec.js
+++ b/cypress/integration/elife/manuscripts_page_spec.js
@@ -24,7 +24,7 @@ describe('Manuscripts page tests', () => {
     })
     it('evaluation button is visible on unsubmited status article', () => {
       ManuscriptsPage.clickSubmit()
-      NewSubmissionPage.clickSubmitUrlAndVerifyLink()
+      NewSubmissionPage.clickSubmitUrlAndWaitPageLoad()
       // fill the submit form and submit it
       // eslint-disable-next-line jest/valid-expect-in-promise
       cy.fixture('submission_form_data').then(data => {
@@ -47,7 +47,7 @@ describe('Manuscripts page tests', () => {
       })
       ManuscriptsPage.getTableHeader().should('be.visible')
       ManuscriptsPage.clickSubmit()
-      NewSubmissionPage.clickSubmitUrlAndVerifyLink()
+      NewSubmissionPage.clickSubmitUrlAndWaitPageLoad()
       // fill the submit form and submit it
       // eslint-disable-next-line jest/valid-expect-in-promise
       cy.fixture('submission_form_data').then(data => {
@@ -82,15 +82,15 @@ describe('Manuscripts page tests', () => {
 
     it('sort article after Article id', () => {
       ManuscriptsPage.clickSubmit()
-      NewSubmissionPage.clickSubmitUrlAndVerifyLink()
+      NewSubmissionPage.clickSubmitUrlAndWaitPageLoad()
       SubmissionFormPage.fillInArticleld('456')
       Menu.clickManuscriptsAndAssertPageLoad()
       ManuscriptsPage.clickSubmit()
-      NewSubmissionPage.clickSubmitUrlAndVerifyLink()
+      NewSubmissionPage.clickSubmitUrlAndWaitPageLoad()
       SubmissionFormPage.fillInArticleld('abc')
       Menu.clickManuscriptsAndAssertPageLoad()
       ManuscriptsPage.clickSubmit()
-      NewSubmissionPage.clickSubmitUrlAndVerifyLink()
+      NewSubmissionPage.clickSubmitUrlAndWaitPageLoad()
       SubmissionFormPage.fillInArticleld('def')
       Menu.clickManuscriptsAndAssertPageLoad()
       ManuscriptsPage.getArticleTitleByRow(0).should('contain', 'def')
@@ -119,7 +119,7 @@ describe('Manuscripts page tests', () => {
         ManuscriptsPage.getEvaluationButton().should('not.exist')
         ManuscriptsPage.clickSubmit()
 
-        NewSubmissionPage.clickSubmitUrlAndVerifyLink()
+        NewSubmissionPage.clickSubmitUrlAndWaitPageLoad()
 
         // fill the submit form and submit it
         // eslint-disable-next-line jest/valid-expect-in-promise
@@ -241,11 +241,10 @@ describe('Manuscripts page tests', () => {
 
     it('message for DOI invalid is visible ', () => {
       ManuscriptsPage.clickSubmit()
-      NewSubmissionPage.clickSubmitUrlAndVerifyLink()
-      SubmissionFormPage.fillInArticleUrl("google.com")
+      NewSubmissionPage.clickSubmitUrlAndWaitPageLoad()
+      SubmissionFormPage.fillInArticleUrl('google.com')
       SubmissionFormPage.fillInDescription('2')
       SubmissionFormPage.getValidationErrorMessage('DOI is invalid')
     })
   })
 })
-
diff --git a/cypress/integration/ncrc/form_builder_page_spec.js b/cypress/integration/ncrc/form_builder_page_spec.js
index a61e7a019b..8bf8fe8d1d 100644
--- a/cypress/integration/ncrc/form_builder_page_spec.js
+++ b/cypress/integration/ncrc/form_builder_page_spec.js
@@ -94,7 +94,7 @@ describe('form builder tests', () => {
       })
       ManuscriptsPage.getTableHeader().should('be.visible')
       ManuscriptsPage.clickSubmit()
-      NewSubmissionPage.clickSubmitUrlAndVerifyLink()
+      NewSubmissionPage.clickSubmitUrlAndWaitPageLoad()
     })
 
     it('check submission form contains the same fields', () => {
@@ -207,6 +207,5 @@ describe('form builder tests', () => {
         }
       })
     })
-
   })
 })
diff --git a/cypress/integration/ncrc/manuscripts_page_spec.js b/cypress/integration/ncrc/manuscripts_page_spec.js
index d27afb46c8..cb0ef00203 100644
--- a/cypress/integration/ncrc/manuscripts_page_spec.js
+++ b/cypress/integration/ncrc/manuscripts_page_spec.js
@@ -258,7 +258,6 @@ describe('manuscripts page tests', () => {
     })
   })
   context('DOI validation', () => {
-
     it('message for DOI invalid is visible ', () => {
       ManuscriptsPage.clickSubmit()
       NewSubmissionPage.clickSubmitUrlAndWaitPageLoad()
-- 
GitLab