Kotahi merge requestshttps://gitlab.coko.foundation/kotahi/kotahi/-/merge_requests2024-03-06T07:50:55Zhttps://gitlab.coko.foundation/kotahi/kotahi/-/merge_requests/1144feat(proofing): hide author proofing email templates from control panel2024-03-06T07:50:55ZVignesh Devendranfeat(proofing): hide author proofing email templates from control panelSee #1538See #1538Vignesh DevendranVignesh Devendranhttps://gitlab.coko.foundation/kotahi/kotahi/-/merge_requests/1143feat(semantic-scholar): suggested manuscripts from semantic scholar2024-02-28T06:36:12ZPankaj Kandpalfeat(semantic-scholar): suggested manuscripts from semantic scholarIssue addressed #1487Issue addressed #1487Pankaj KandpalPankaj Kandpalhttps://gitlab.coko.foundation/kotahi/kotahi/-/merge_requests/1142Orcid identifier and proofing default bug fixes2024-02-16T09:07:25ZVignesh DevendranOrcid identifier and proofing default bug fixesSee #1532 and #1492 ([comment](https://gitlab.coko.foundation/kotahi/kotahi/-/issues/1492#note_135066))
- Fix ORCID identifier - `defaultIdentity` object shown as `null`
- Update the `authorProofingEnabled` key value default to `false`See #1532 and #1492 ([comment](https://gitlab.coko.foundation/kotahi/kotahi/-/issues/1492#note_135066))
- Fix ORCID identifier - `defaultIdentity` object shown as `null`
- Update the `authorProofingEnabled` key value default to `false`Vignesh DevendranVignesh Devendranhttps://gitlab.coko.foundation/kotahi/kotahi/-/merge_requests/1141feat(cms): fix expired images in article template2024-02-16T01:32:57ZGiannis Kopanasjkopanas@gmail.comfeat(cms): fix expired images in article templateThis fixes expired images from NunJunks templates. I had to create a new function and a regex to catch all the `img` tags because the original replaceImageSrc function uses cheerio and expects a valid html not a NunJunks template which i...This fixes expired images from NunJunks templates. I had to create a new function and a regex to catch all the `img` tags because the original replaceImageSrc function uses cheerio and expects a valid html not a NunJunks template which is the case now.Giannis Kopanasjkopanas@gmail.comGiannis Kopanasjkopanas@gmail.comhttps://gitlab.coko.foundation/kotahi/kotahi/-/merge_requests/1140fix(cms): only provide handlebars for fields we can display2024-02-14T14:47:38ZBen Whitmorefix(cms): only provide handlebars for fields we can displayIn the Article Metadata tab of the Article Template page, this hides the fields named 'fileName', 'manuscriptFile' and 'visualAbstract', as these were producing handlebars code that didn't actually work. A better solution for including t...In the Article Metadata tab of the Article Template page, this hides the fields named 'fileName', 'manuscriptFile' and 'visualAbstract', as these were producing handlebars code that didn't actually work. A better solution for including these fields in the article can be found in future.https://gitlab.coko.foundation/kotahi/kotahi/-/merge_requests/1139fix(cms): fix DOI link in template2024-02-14T13:33:36ZBen Whitmorefix(cms): fix DOI link in templatehttps://gitlab.coko.foundation/kotahi/kotahi/-/merge_requests/1138fix(cms): ensure article template populates for new groups2024-02-14T12:21:15ZBen Whitmorefix(cms): ensure article template populates for new groupsPreviously, a migration was implemented to patch CMS article templates for existing groups. The trouble is, when setting up a new instance of Kotahi this migration runs before any groups have been created. There are thus no records to pa...Previously, a migration was implemented to patch CMS article templates for existing groups. The trouble is, when setting up a new instance of Kotahi this migration runs before any groups have been created. There are thus no records to patch. The groups and article template records were created at a later point. Thus, a new instance of Kotahi would have no article templates populated for CMS.
I've removed the migration and instead added a seed script that will either patch existing CMS article template records if the template is empty, or will insert completely new records if records are missing.
This will run at every server startup, and patch or insert only as necessary. One bonus of this is that if you really mess up your article template you can clear it entirely then restart the server and it will be restored to default.https://gitlab.coko.foundation/kotahi/kotahi/-/merge_requests/1137build(*): upgrade flax2024-02-14T14:11:26ZGiannis Kopanasjkopanas@gmail.combuild(*): upgrade flaxGiannis Kopanasjkopanas@gmail.comGiannis Kopanasjkopanas@gmail.comhttps://gitlab.coko.foundation/kotahi/kotahi/-/merge_requests/1136Refactor proofing access and feedback2024-03-04T03:57:25ZVignesh DevendranRefactor proofing access and feedbackSee #1473 and #1508See #1473 and #1508Vignesh DevendranVignesh Devendranhttps://gitlab.coko.foundation/kotahi/kotahi/-/merge_requests/1135fix(submit): show multiple versions correctly2024-02-14T09:47:15ZBen Whitmorefix(submit): show multiple versions correctlySee #1528
When implementing caching code, I thought I had checked carefully and concluded that manuscript versions were only being queried for a top-level manuscript -- i.e. the manuscripts returned would all be its children. But there ...See #1528
When implementing caching code, I thought I had checked carefully and concluded that manuscript versions were only being queried for a top-level manuscript -- i.e. the manuscripts returned would all be its children. But there were some uses that I missed, where the supplied manuscript ID was actually the _latest_ version of the manuscript, and we needed to return all _preceding_ versions.https://gitlab.coko.foundation/kotahi/kotahi/-/merge_requests/1134fix(attachments): fix missing URLs for files2024-02-14T05:42:32ZBen Whitmorefix(attachments): fix missing URLs for filesAttachments couldn't be downloaded because no URL was being passed from the server for file objects. This is because I created a new `files` resolver for the `Manuscript` graphql type, but I didn't run the files through `getFilesWithUrl`...Attachments couldn't be downloaded because no URL was being passed from the server for file objects. This is because I created a new `files` resolver for the `Manuscript` graphql type, but I didn't run the files through `getFilesWithUrl` before returning them. As Vignesh pointed out, the resolver I added was a duplicate anyway, and unneeded.
I have removed the new resolver and slightly improved the old resolver to obtain files in a single DB query rather than two.https://gitlab.coko.foundation/kotahi/kotahi/-/merge_requests/1133fix(notifications): don't fail if ccEmails missing from data2024-02-14T06:25:09ZBen Whitmorefix(notifications): don't fail if ccEmails missing from dataI noticed several errors in the kotahidev logs like this:
![image](/uploads/93c1911bddb3be5f1d1fea0022470ebb/image.png)
The `sendEmailNotification` function expects `data.ccEmails` to be supplied if the "CC editors" option is enabled o...I noticed several errors in the kotahidev logs like this:
![image](/uploads/93c1911bddb3be5f1d1fea0022470ebb/image.png)
The `sendEmailNotification` function expects `data.ccEmails` to be supplied if the "CC editors" option is enabled on the email template. But most places in code that `sendEmailNotification` is used don't supply `data.ccEmails`, so we get an error and the email doesn't get sent.
I've made the code lenient so that it won't fail if `ccEmails` isn't supplied.https://gitlab.coko.foundation/kotahi/kotahi/-/merge_requests/1132fix(file): manuscript files url not displayed remove duplicate code2024-02-14T04:04:05ZVignesh Devendranfix(file): manuscript files url not displayed remove duplicate code#1430 - [comment](https://gitlab.coko.foundation/kotahi/kotahi/-/issues/1430#note_134901)
- Manuscript files query does not retrieve URLs with recent code updates - check this [comment](https://gitlab.coko.foundation/kotahi/kotahi/-/comm...#1430 - [comment](https://gitlab.coko.foundation/kotahi/kotahi/-/issues/1430#note_134901)
- Manuscript files query does not retrieve URLs with recent code updates - check this [comment](https://gitlab.coko.foundation/kotahi/kotahi/-/commit/fbe5f805611b376b526cc7379e4983658d20c6e1#note_134900). Removed the duplicate code!Vignesh DevendranVignesh Devendranhttps://gitlab.coko.foundation/kotahi/kotahi/-/merge_requests/1131fix(decision): fix mangled DOIs to register label2024-02-13T10:18:41ZBen Whitmorefix(decision): fix mangled DOIs to register labelIn the decision page, DOIs to be registered used to be displayed like this:
![image](/uploads/a77ae9998cf8ab55ce8b985138304440/image.png)
Now they are displayed like this:
![image](/uploads/a10793d9b6a563a5ffd7779023bbe499/image.png)
...In the decision page, DOIs to be registered used to be displayed like this:
![image](/uploads/a77ae9998cf8ab55ce8b985138304440/image.png)
Now they are displayed like this:
![image](/uploads/a10793d9b6a563a5ffd7779023bbe499/image.png)
This is achieved by prefixing "- " inside the translation string, which tells i18next not to escape the supplied variable. This is safe because React does its own escaping to prevent scripting attacks.https://gitlab.coko.foundation/kotahi/kotahi/-/merge_requests/1130fix(form): allow non-URL DOIs for validation2024-02-13T10:11:49ZBen Whitmorefix(form): allow non-URL DOIs for validationThe form was treating DOIs in the form `10.1234/abc` as invalid, and only `https://doi.org/10.1234/abc` as valid. This needs to change, as DOIs in `submission.$doi` are now converted into the short actual DOI format after entry into the ...The form was treating DOIs in the form `10.1234/abc` as invalid, and only `https://doi.org/10.1234/abc` as valid. This needs to change, as DOIs in `submission.$doi` are now converted into the short actual DOI format after entry into the form. So revisiting a form, you'll always see DOIs in the short form.https://gitlab.coko.foundation/kotahi/kotahi/-/merge_requests/1129ci(*): change chrome download url2024-02-13T10:58:39ZYannis Barlasci(*): change chrome download urlBen WhitmoreBen Whitmorehttps://gitlab.coko.foundation/kotahi/kotahi/-/merge_requests/1128Author proofing config default migration and feedback notification to editor2024-02-13T10:38:40ZVignesh DevendranAuthor proofing config default migration and feedback notification to editorSee #1451 - [comment](https://gitlab.coko.foundation/kotahi/kotahi/-/issues/1451#note_134704) and #1492
Bug fixes
- Migration updates default `authorProofingEnabled` config values as `true` for journal archetype; New instance defaults...See #1451 - [comment](https://gitlab.coko.foundation/kotahi/kotahi/-/issues/1451#note_134704) and #1492
Bug fixes
- Migration updates default `authorProofingEnabled` config values as `true` for journal archetype; New instance defaults updated;
- Mapped Author feedback submission notification to assigned `editor` roleAmnet Author proofing workflowVignesh DevendranVignesh Devendranhttps://gitlab.coko.foundation/kotahi/kotahi/-/merge_requests/1127refactor(config): simplify UI by using HiddenTabs2024-03-19T12:41:45ZBen Whitmorerefactor(config): simplify UI by using HiddenTabsI've simplified the approach to #1493 by using the `HiddenTabs` component. I think it could still be simplified further, as we're keeping state in separate variables where I suspect we don't need to, since all the forms continue to be av...I've simplified the approach to #1493 by using the `HiddenTabs` component. I think it could still be simplified further, as we're keeping state in separate variables where I suspect we don't need to, since all the forms continue to be available. Also, I don't think we need to reload/rebuild the forms upon saving the data. That causes focus to return to the 'general' tab and all panes to scroll back to the top, which could be disruptive.
There are small visual differences: no fade at top/bottom of the scrollable pane; and the scrollbar is now styled like the rest of Kotahi (though I liked the scrollbar styling in !1090).
Also, there are some labels in this page that need translations provided.v3.1.0MRdevTaggMRdevTagghttps://gitlab.coko.foundation/kotahi/kotahi/-/merge_requests/1126ci(*): do not start server again2024-02-12T23:13:14ZYannis Barlasci(*): do not start server againBen WhitmoreBen Whitmorehttps://gitlab.coko.foundation/kotahi/kotahi/-/merge_requests/1125Load default article template2024-02-13T10:42:34ZGiannis Kopanasjkopanas@gmail.comLoad default article templateGiannis Kopanasjkopanas@gmail.comGiannis Kopanasjkopanas@gmail.com