micropublication issueshttps://gitlab.coko.foundation/micropublication/micropublication/-/issues2021-08-24T08:48:20Zhttps://gitlab.coko.foundation/micropublication/micropublication/-/issues/306Finish client-side refactor2021-08-24T08:48:20ZYannis BarlasFinish client-side refactor* [ ] all pages should use apollo hooks
* [ ] all ui components should move to storybook
* [ ] remove react-adopt
* [ ] remove react-powerplug* [ ] all pages should use apollo hooks
* [ ] all ui components should move to storybook
* [ ] remove react-adopt
* [ ] remove react-powerplugWrap uphttps://gitlab.coko.foundation/micropublication/micropublication/-/issues/305Add graphql shield for server-side authorization2021-08-24T08:48:26ZYannis BarlasAdd graphql shield for server-side authorizationWrap uphttps://gitlab.coko.foundation/micropublication/micropublication/-/issues/304Reviewer redesign feedback2021-08-24T08:48:31ZYannis BarlasReviewer redesign feedbackPasting @draciti's feedback here:
For section ‘Invite a reviewer that is not a user yet’
* I insert the reviewer info but I would like to add to the list, not send an invitation right away. The button below says send invitation. Would b...Pasting @draciti's feedback here:
For section ‘Invite a reviewer that is not a user yet’
* I insert the reviewer info but I would like to add to the list, not send an invitation right away. The button below says send invitation. Would be better that the button said “add to list”. Once that reviewer is in the list, the editor can rearrange reviewers and then start the automation. (need @karenyook’s feedback when she will be back from vacation)
* When I entered a reviewer there (‘Invite a reviewer that is not a user yet’) I did not receive an invitation but I did receive a notification when the invitation was revoked.
* Once I start the automation I cannot add reviewers in the ‘Invite a reviewer that is not a user yet’. We should allow that as we might receive additional names while the system is running. Possible to allow it?
* the cron seems not to be working. When I start the automation I do not receive reminder emails, waited 12 min now.Wrap uphttps://gitlab.coko.foundation/micropublication/micropublication/-/issues/303Replace xpub edit with wax-prosemirror2021-08-24T08:48:42ZYannis BarlasReplace xpub edit with wax-prosemirrorWe'll also need a "special characters" plugin for the editor if it doesn't exist already.We'll also need a "special characters" plugin for the editor if it doesn't exist already.Upcominghttps://gitlab.coko.foundation/micropublication/micropublication/-/issues/302Reimplement statuses2021-05-05T20:31:49ZYannis BarlasReimplement statusesThere's two aspects to this:
One is that status creation should be constructed or derived server-side
The other is that we need a rethink of what statuses we're using.
@nickstiffler @draciti @karenyook feel free to brainstorm in the ...There's two aspects to this:
One is that status creation should be constructed or derived server-side
The other is that we need a rethink of what statuses we're using.
@nickstiffler @draciti @karenyook feel free to brainstorm in the comments what changes you'd like to see in the statuses.Upcominghttps://gitlab.coko.foundation/micropublication/micropublication/-/issues/301Make assign reviewers accessible after publish2021-08-24T08:48:38ZYannis BarlasMake assign reviewers accessible after publishAfter a manuscript is published, the assign reviewers page should be accessible, but read-only.After a manuscript is published, the assign reviewers page should be accessible, but read-only.Wrap uphttps://gitlab.coko.foundation/micropublication/micropublication/-/issues/300Invite reviewer text2021-05-05T20:32:08ZYannis BarlasInvite reviewer textWhen invite is clicked:
* Open a modal
* Modal should have a text area where editors can compose their message
* Text that was composed becomes the email that is sent outWhen invite is clicked:
* Open a modal
* Modal should have a text area where editors can compose their message
* Text that was composed becomes the email that is sent outNexthttps://gitlab.coko.foundation/micropublication/micropublication/-/issues/299Handle invitations after publish2021-08-24T08:48:35ZYannis BarlasHandle invitations after publishThere's states like publish, or when a manuscript is rejected, where the reviewer shouldn't be able to accept an invitation any more.
We should
* automatically uninvite reviewers when manuscripts get to these states
* check for these ...There's states like publish, or when a manuscript is rejected, where the reviewer shouldn't be able to accept an invitation any more.
We should
* automatically uninvite reviewers when manuscripts get to these states
* check for these states anyway when the reviewer responds to an invitationWrap uphttps://gitlab.coko.foundation/micropublication/micropublication/-/issues/298Unable to `yarn server`2021-04-15T14:12:48ZnickstifflerUnable to `yarn server`I have tried a few configurations, and haven't been successful at running our dev server with the newest code release. When running `yarn server`, the browser resolves to `Cannot GET /`. This happens for both `NODE_ENV=development` and `...I have tried a few configurations, and haven't been successful at running our dev server with the newest code release. When running `yarn server`, the browser resolves to `Cannot GET /`. This happens for both `NODE_ENV=development` and `NODE_ENV=production`. This happens on our AWS instance (ubuntu) as well as my development laptop (arch).
Here is the output:
```
yarn run v1.17.3
$ pubsweet server
info: Starting PubSweet app
info: Checking if database tables exist.
info: Database tables exist.
info: App started.
info: The app will be kept running, even if errors occur, until you stop it.
info: To stop the app use ctrl-C
info: Registered component @pubsweet/model-team
info: Registered component @pubsweet/model-user
info: Registered component @pubsweet/component-send-email
info: Registered component ./server/api
info: Registered component ./server/models/chatMessage
info: Registered component ./server/models/chatThread
info: Registered component ./server/models/curatorReview
info: Registered component ./server/models/identity
info: Registered component ./server/models/manuscript
info: Registered component ./server/models/manuscriptVersion
info: Registered component ./server/models/review
info: Registered component ./server/models/teamMember
info: Registered component ./server/models/team
info: Registered component ./server/models/user
info: Registered component ./app/wbApi
info: Registered server component ./app/wbApi
info: Registered component ./server/export
info: Registered server component ./server/export
info: Registered component ./app/pubMedApi
info: Registered server component ./app/pubMedApi
info: Registered component ./app/dataCiteApi
info: Registered server component ./app/dataCiteApi
info: Coko server => Registering graphql middleware...
info: Coko server => Middleware: Registered email middleware
info: Starting HTTP server
info: App is listening on port 5000
Browserslist: caniuse-lite is outdated. Please run next command `yarn upgrade`
webpack built app 56e4439525a099158dd7 in 20021ms
ℹ 「wdm」: Hash: 56e4439525a099158dd7
Version: webpack 4.42.1
Time: 20021ms
Built at: 04/13/2021 8:20:06 PM
Asset Size Chunks Chunk Names
app.js 9.36 MiB app [emitted] app
app.js.gz 2.31 MiB [emitted]
app.js.map 8.66 MiB app [emitted] [dev] app
favicon.ico 6.61 KiB [emitted]
index.html 244 bytes [emitted]
logo.png 28 KiB [emitted]
print.css 1.01 KiB [emitted]
Entrypoint app = app.js app.js.map
[0] multi react-hot-loader/patch ./app 40 bytes {app} [built]
[../node_modules/@babel/runtime/helpers/interopRequireDefault.js] 147 bytes {app} [built]
[../node_modules/@coko/client/src/index.js] 94 bytes {app} [built]
[../node_modules/pubsweet-client/dist/index.js] 2.22 KiB {app} [built]
[../node_modules/react-dom/index.js] 1.33 KiB {app} [built]
[../node_modules/react-hot-loader/dist/react-hot-loader.development.js] 95.3 KiB {app} [built]
[../node_modules/react-hot-loader/index.js] 1.24 KiB {app} [built]
[../node_modules/react-hot-loader/patch.js] 229 bytes {app} [built]
[../node_modules/react/index.js] 190 bytes {app} [built]
[../node_modules/regenerator-runtime/runtime.js] 23.6 KiB {app} [built]
[../node_modules/webpack/buildin/harmony-module.js] 573 bytes {app} [built]
[./app.js] 2.71 KiB {app} [built]
[./routes.js] 2.97 KiB {app} [built]
[./theme.js] 4.24 KiB {app} [built]
[./userContext.js] 2.22 KiB {app} [built]
+ 1231 hidden modules
Child html-webpack-plugin for "index.html":
Asset Size Chunks Chunk Names
index.html 534 KiB 0
Entrypoint undefined = index.html
[../node_modules/html-webpack-plugin/lib/loader.js!./index.ejs] 404 bytes {0} [built]
[../node_modules/lodash/lodash.js] 528 KiB {0} [built]
[../node_modules/webpack/buildin/global.js] 472 bytes {0} [built]
[../node_modules/webpack/buildin/module.js] 497 bytes {0} [built]
ℹ 「wdm」: Compiled successfully.
ℹ 「wdm」: Compiling...
webpack building...
webpack built app abd7f989b8deb7944284 in 2011ms
ℹ 「wdm」: Hash: abd7f989b8deb7944284
Version: webpack 4.42.1
Time: 2011ms
Built at: 04/13/2021 8:20:09 PM
Asset Size Chunks Chunk Names
56e4439525a099158dd7.hot-update.json 35 bytes [emitted] [immutable] [hmr]
app.js 9.36 MiB app [emitted] app
app.js.gz 2.31 MiB [emitted]
app.js.map 8.66 MiB app [emitted] [dev] app
favicon.ico 6.61 KiB [emitted]
index.html 244 bytes [emitted]
Entrypoint app = app.js app.js.map
[0] multi react-hot-loader/patch ./app 40 bytes {app}
[../node_modules/@babel/runtime/helpers/interopRequireDefault.js] 147 bytes {app}
[../node_modules/@coko/client/src/index.js] 94 bytes {app}
[../node_modules/pubsweet-client/dist/index.js] 2.22 KiB {app}
[../node_modules/react-dom/index.js] 1.33 KiB {app}
[../node_modules/react-hot-loader/dist/react-hot-loader.development.js] 95.3 KiB {app}
[../node_modules/react-hot-loader/index.js] 1.24 KiB {app}
[../node_modules/react-hot-loader/patch.js] 229 bytes {app}
[../node_modules/react/index.js] 190 bytes {app}
[../node_modules/regenerator-runtime/runtime.js] 23.6 KiB {app}
[../node_modules/webpack/buildin/harmony-module.js] 573 bytes {app}
[./app.js] 2.71 KiB {app}
[./routes.js] 2.97 KiB {app}
[./theme.js] 4.24 KiB {app}
[./userContext.js] 2.22 KiB {app}
+ 1231 hidden modules
Child html-webpack-plugin for "index.html":
Asset Size Chunks Chunk Names
index.html 534 KiB 1
Entrypoint undefined = index.html
[../node_modules/html-webpack-plugin/lib/loader.js!./index.ejs] 404 bytes {1}
[../node_modules/lodash/lodash.js] 528 KiB {1}
[../node_modules/webpack/buildin/global.js] 472 bytes {1}
[../node_modules/webpack/buildin/module.js] 497 bytes {1}
ℹ 「wdm」: Compiled successfully.
```Yannis BarlasYannis Barlashttps://gitlab.coko.foundation/micropublication/micropublication/-/issues/297Image path now includes server URL2021-01-26T18:13:38ZnickstifflerImage path now includes server URLIt looks like changes made in MR !300 is causing unexpected behavior. The full server URL is now stored in the database in addition to the image path. Example:
`{"url": "https://portal.micropublication.org/uploads/f82a5a73cb042583905a331...It looks like changes made in MR !300 is causing unexpected behavior. The full server URL is now stored in the database in addition to the image path. Example:
`{"url": "https://portal.micropublication.org/uploads/f82a5a73cb042583905a33185a122bf9.jpg", "name": "figure.jpg"}`
The figure does not render in the manuscript preview.Yannis BarlasYannis Barlashttps://gitlab.coko.foundation/micropublication/micropublication/-/issues/296Update team membership error2021-05-05T20:45:28ZnickstifflerUpdate team membership error@draciti and @karenyook experience an issue I have been unable to replicate. When they use the team manager to set the editors, SO and curator for an article, the server doesn't return and the modal doesn't close. The error on the server...@draciti and @karenyook experience an issue I have been unable to replicate. When they use the team manager to set the editors, SO and curator for an article, the server doesn't return and the modal doesn't close. The error on the server is:
`{"error":{"message":"Cannot read property 'title' of undefined","locations":[{"line":2,"column":3}],"path":["updateManuscriptTeamMembership"],"extensions":{"code":"INTERNAL_SERVER_ERROR"}},"level":"error","message":"Cannot read property 'title' of undefined","timestamp":"2020-10-31T23:24:41.678Z"}`
The error happens here:
https://gitlab.coko.foundation/micropublication/micropublication/blob/master/server/services/notify/emailMiddleware.js#L137
Can you think of a reason the version would be undefined?Nexthttps://gitlab.coko.foundation/micropublication/micropublication/-/issues/295Null value in reference causes crash2020-09-27T19:07:26ZnickstifflerNull value in reference causes crashI am not sure how this happens, but on a couple of occasions authors have input references where the `pubmedId` is null. This causes the browser to crash when editing the references. I can edit the DB and replace the null with an empty s...I am not sure how this happens, but on a couple of occasions authors have input references where the `pubmedId` is null. This causes the browser to crash when editing the references. I can edit the DB and replace the null with an empty screen, but I am wondering how this might happen.
I am playing with adding a check to ensure objects do not contain null values here:
https://gitlab.coko.foundation/micropublication/micropublication/blob/master/app/components/SubmissionForm.js#L321Yannis BarlasYannis Barlashttps://gitlab.coko.foundation/micropublication/micropublication/-/issues/294Google analytics2021-05-05T20:45:54ZnickstifflerGoogle analyticsWe use Google Analytics and it requires a code snippet that I manually place in `/app/index.ejs` every time I update production. Is there a way to have webpack do this automatically using a file in `/config`?We use Google Analytics and it requires a code snippet that I manually place in `/app/index.ejs` every time I update production. Is there a way to have webpack do this automatically using a file in `/config`?https://gitlab.coko.foundation/micropublication/micropublication/-/issues/293Add chat button to feedback panel2020-09-02T18:00:51ZnickstifflerAdd chat button to feedback panelAuthors should be able to chat with editors if clarification is needed during revision.Authors should be able to chat with editors if clarification is needed during revision.https://gitlab.coko.foundation/micropublication/micropublication/-/issues/292Handle when a deactivated user tries to sign-up again2021-05-05T20:35:31ZnickstifflerHandle when a deactivated user tries to sign-up againOne option would be to notify them that they need to request via email to have their account reactivated.One option would be to notify them that they need to request via email to have their account reactivated.https://gitlab.coko.foundation/micropublication/micropublication/-/issues/291Remove UI files that moved to storybook2020-08-21T19:29:36ZnickstifflerRemove UI files that moved to storybookThere are a few things that moved to `/ui/src` from /app/components/ui` but were never deleted. I sometimes edit the wrong file, but I am hesitant to delete anything.There are a few things that moved to `/ui/src` from /app/components/ui` but were never deleted. I sometimes edit the wrong file, but I am hesitant to delete anything.https://gitlab.coko.foundation/micropublication/micropublication/-/issues/290Curator can submit to manuscript version under revision2021-02-02T23:57:28ZnickstifflerCurator can submit to manuscript version under revisionCurator submitted their assessment, but the editor couldn't see it because it went to a version that hadn't been submitted yet.Curator submitted their assessment, but the editor couldn't see it because it went to a version that hadn't been submitted yet.https://gitlab.coko.foundation/micropublication/micropublication/-/issues/289Sign up errors show uninformative message2020-07-02T15:24:59ZnickstifflerSign up errors show uninformative messageThe pubsweet graphql api returns default error meessage "Something went wrong! Please contact your administrator" when signing up with a duplicate username or email. https://gitlab.coko.foundation/pubsweet/pubsweet/blob/master/packages/s...The pubsweet graphql api returns default error meessage "Something went wrong! Please contact your administrator" when signing up with a duplicate username or email. https://gitlab.coko.foundation/pubsweet/pubsweet/blob/master/packages/server/src/graphql/api.js#L48https://gitlab.coko.foundation/micropublication/micropublication/-/issues/288Entering wrong username in password reset results in uninformative message2020-08-05T14:44:41ZnickstifflerEntering wrong username in password reset results in uninformative messageThe message is "There was an unexpected error" when it should be something like "Username not found". This is using a pubsweet component, so I am not sure the best way to handle it.The message is "There was an unexpected error" when it should be something like "Username not found". This is using a pubsweet component, so I am not sure the best way to handle it.https://gitlab.coko.foundation/micropublication/micropublication/-/issues/287Relabel tabs2020-06-13T00:48:05ZnickstifflerRelabel tabsManuscript version tabs should be label based on what they are a response to. This includes reviewer comments, editor comments and proofing.Manuscript version tabs should be label based on what they are a response to. This includes reviewer comments, editor comments and proofing.