ncbi issueshttps://gitlab.coko.foundation/ncbi/ncbi/-/issues2021-01-13T19:01:48Zhttps://gitlab.coko.foundation/ncbi/ncbi/-/issues/141Files tab column ordering2021-01-13T19:01:48ZDione Mentisdione@coko.foundationFiles tab column orderingHi @danjela
The order of the columns on the file tab should be improved to make it easier for the user to read.
This image is zoomed out to show all sections:
![QuickTime_Player_39](/uploads/96268ef0723c555ba8ab0cefbc84c370/QuickTi...Hi @danjela
The order of the columns on the file tab should be improved to make it easier for the user to read.
This image is zoomed out to show all sections:
![QuickTime_Player_39](/uploads/96268ef0723c555ba8ab0cefbc84c370/QuickTime_Player_39.png)
I suggest this order, from left to right:
1. Book component: Source, File version, Converted, Status, Uploaded
2. Supplementary: Filename, File version, Uploaded
2. Images: Filename, File version, Type, Uploaded
2. Support: Filename, File version, Uploaded
@henrik -- do you agree?process fileshttps://gitlab.coko.foundation/ncbi/ncbi/-/issues/142Full metadata requirements for collections, books, and book components2024-01-16T18:23:06ZDione Mentisdione@coko.foundationFull metadata requirements for collections, books, and book componentsHi @lathrops1
As discussed yesterday, we need to scope out the full metadata requirements for all workflows.
Please provide a spreadsheet that includes all fields. Please list the related fields together as per the required xml struc...Hi @lathrops1
As discussed yesterday, we need to scope out the full metadata requirements for all workflows.
Please provide a spreadsheet that includes all fields. Please list the related fields together as per the required xml structure. Please also indicate which fields:
* are common (i.e. we'd expect them to be in the UI)
* are uncommon or have complex nesting (i.e. the user may need to fill these in in an NCBI metadata template spreadsheet)
* come from the source content versus those that don't.https://gitlab.coko.foundation/ncbi/ncbi/-/issues/143Sample JSON files with errors2021-06-10T21:16:27ZStacy LathropSample JSON files with errors@DioneMentis
cc: @Kireev
As discussed I have posted JSON files with errors that Evgeny and our developers prepared. He will provide additional information about the files. Let us know if you and your developers have questions when re...@DioneMentis
cc: @Kireev
As discussed I have posted JSON files with errors that Evgeny and our developers prepared. He will provide additional information about the files. Let us know if you and your developers have questions when reviewing and using them for testing, etc.
The files are at:
/am/ftp-private/bookshelf/coko/misc/bacvir4ed_gene_error_notices.zip
Also see [Error Categories](https://gitlab.coko.foundation/ncbi/ncbi/-/wikis/Errors-Categories) Wiki page.https://gitlab.coko.foundation/ncbi/ncbi/-/issues/144table of users is not scrollable (manage team tab)2020-08-27T15:30:50ZDione Mentisdione@coko.foundationtable of users is not scrollable (manage team tab)Hi @John.kopanas and @danjela
When I add more than three users to the manage team tab, I cannot scroll to see all the users.
![ncbi_46](/uploads/b543d40394bb5916905b29b756244a02/ncbi_46.png)Hi @John.kopanas and @danjela
When I add more than three users to the manage team tab, I cannot scroll to see all the users.
![ncbi_46](/uploads/b543d40394bb5916905b29b756244a02/ncbi_46.png)Sidorela UkuSidorela Ukuhttps://gitlab.coko.foundation/ncbi/ncbi/-/issues/145'add author' button opens blank page2020-08-03T07:56:20ZDione Mentisdione@coko.foundation'add author' button opens blank pageHi @John.kopanas
I found a bug. See video attached.
![add-aurhor-bug-20200631](/uploads/d49e277024d32fae5e1f86adb8738d74/add-aurhor-bug-20200631.mov)Hi @John.kopanas
I found a bug. See video attached.
![add-aurhor-bug-20200631](/uploads/d49e277024d32fae5e1f86adb8738d74/add-aurhor-bug-20200631.mov)https://gitlab.coko.foundation/ncbi/ncbi/-/issues/146Unticked items are published in bulk pushing modal2020-08-03T07:57:33ZDione Mentisdione@coko.foundationUnticked items are published in bulk pushing modal@John.kopanas and @danjela
when I untick book components from the bulk publishing modal and select the 'publish' button, the unticked items are published. Untick items should remain with status 'ready to publish'.
![QuickTime_Player_4...@John.kopanas and @danjela
when I untick book components from the bulk publishing modal and select the 'publish' button, the unticked items are published. Untick items should remain with status 'ready to publish'.
![QuickTime_Player_47](/uploads/dbadba69c152b9282e5dfdec9bc4dd83/QuickTime_Player_47.png)https://gitlab.coko.foundation/ncbi/ncbi/-/issues/147'Save' for Individual file uploads does't work2021-01-13T18:59:56ZDione Mentisdione@coko.foundation'Save' for Individual file uploads does't workHi @danjela
I've tried a few times to upload individual files but nothing happens. Can you look at this bug please
![QuickTime_Player_48](/uploads/2b5714e97174ca7f0d7e14cf4ba358a1/QuickTime_Player_48.png)Hi @danjela
I've tried a few times to upload individual files but nothing happens. Can you look at this bug please
![QuickTime_Player_48](/uploads/2b5714e97174ca7f0d7e14cf4ba358a1/QuickTime_Player_48.png)process filesDanjela Shehidanjelashehi@gmail.comDanjela Shehidanjelashehi@gmail.comhttps://gitlab.coko.foundation/ncbi/ncbi/-/issues/148Progress review agenda 4 August2020-11-10T18:58:01ZDione Mentisdione@coko.foundationProgress review agenda 4 AugustHi @lathrops1
Here's the agenda for tomorrow:
1. NCBI review of latest dev (#149)
2. Question on preview for PDF and XML (#71)
2. Developer questions on error handing (#138 and #143) and documentation [here](https://gitlab.coko.found...Hi @lathrops1
Here's the agenda for tomorrow:
1. NCBI review of latest dev (#149)
2. Question on preview for PDF and XML (#71)
2. Developer questions on error handing (#138 and #143) and documentation [here](https://gitlab.coko.foundation/ncbi/ncbi/-/wikis/Errors-Categories)
3. This cycle's schedulehttps://gitlab.coko.foundation/ncbi/ncbi/-/issues/149NCBI dev review 4 Aug2021-09-14T13:37:34ZDione Mentisdione@coko.foundationNCBI dev review 4 Aug
Hi @lathrops1
The following items are ready for your team's review at http://ncbi.coko.foundation/
## Versioning and files
| Items for review | Related issue | Notes |
| ------ | ------ | ------ |
| Dev: Bulk upload file checks and...
Hi @lathrops1
The following items are ready for your team's review at http://ncbi.coko.foundation/
## Versioning and files
| Items for review | Related issue | Notes |
| ------ | ------ | ------ |
| Dev: Bulk upload file checks and creating new file versions | #116 | See #152 and #153 |
| Dev: Create new version of individual book component | #133 | See related #153 |
| Dev: Display and download support files (book components) | #124 | [Docs](https://gitlab.coko.foundation/ncbi/ncbi/-/wikis/Workflows-and-wireframes/Upload-file-versions-and-manage-all-files) |
| Dev: Display extracted Image files | #123 | [Docs](https://gitlab.coko.foundation/ncbi/ncbi/-/wikis/Workflows-and-wireframes/Upload-file-versions-and-manage-all-files) |
## Ordering components in book manager page and previewing TOC
| Items for review | Related issue | Notes |
| ------ | ------ | ------ |
| Dev: Place component in correct section based on xml metadata | #101 | |
| Dev: Auto order TOC | #134 | |
| Dev: Show published and ready to publish book components in Preview TOC | #132 | |
| Dev: TOC xml errors | #24 | Please check toc.xml file file provided - NCBI provided feedback in #24 |
| Bug: Moving components in TOC | #131 | |
## Publishing book components
| Items for review | Related issue | Notes |
| ------ | ------ | ------ |
| Dev: Publish book components (second and subsequent times) | #125 | [Docs](https://gitlab.coko.foundation/ncbi/ncbi/-/wikis/Workflows-and-wireframes/Publish-book-components) |
## Other bugs
| Items for review | Related issue | Notes |
| ------ | ------ | ------ |
| Bug: Display of Last pub date | #128 | |
| Bug: Unsaved actions in manage team tab | #127 | NCBI reopend as still an issue |
| Bug: Last Published Date | #128 | |Dione Mentisdione@coko.foundationDione Mentisdione@coko.foundationhttps://gitlab.coko.foundation/ncbi/ncbi/-/issues/150Previewing workflow for book components (Word)2021-06-17T15:00:56ZDione Mentisdione@coko.foundationPreviewing workflow for book components (Word)Hi @danjela and @John.kopanas
There's a lot of information in #71 so I'm creating a separate dev issue.
**Workflow**
* When a preview is generated only the user who uploaded the file gets notified.
* This user checks the previews,...Hi @danjela and @John.kopanas
There's a lot of information in #71 so I'm creating a separate dev issue.
**Workflow**
* When a preview is generated only the user who uploaded the file gets notified.
* This user checks the previews, makes corrections to the file if necessary (this could involve multiple file uploads and preview regenerations)
* After the user is satisfied with the preview, she asks other users to check the preview. This is done with the 'Request review' button and @mentioning a user or role. These users are send a notification which includes a link to the Preview tab.
- authors
- editors
- previewers
- org admins (rare)
- system admins (very rare use case)
* Users check the preview and provide their feedback in the pop up feedback panel.
* Users can:
- Approve the preview (with or without adding a comment)
- Request changes (must add a comment and optionally attaching a file).
- @mention the users and roles (for example, @dione replace image.png with image.jpg).
**Status changes**
The book component status always matches the status of the *current* file version. It's possible for one file version to go back in status, e.g. from 'approved' to 'changes requested'.
* Previewing = there is a Preview generated
* Review requested = The Author or Editor has pressed 'Request review' button. (status maps to all Previewers associated with the book component)
* Changes requested = Changes have been requested by any of the requested users. (status maps to all Authors associated with the book component)
* Approved = **all** requested user have pressed 'approve' button.
* Ready to publish = Editor approves for publishing by pressing the ‘Ready to publish’ button.
* Published = Editor has pressed the ‘Publish’ button.
**Permissions**
* Previewers do not see the 'request review' button
* Authors do not see the 'Request changes' button.
* All users associated with the book component can see and comment on the feedback
* Only the Editor can mark the chapter for 'ready to publish' and select 'publish'.
* When the book component is in the status 'ready to publish', Authors and Previewers can only comment. The Editor is the only role who may change the status from 'ready to publish' back to 'Request changes'
**Notification**
For the time being, notification will be via email. This includes notifications coming from the system (e.g. preview generated), @mentions, and status changes. In app notification later on a global activity page accessed from the Dashboard.
**Wireframe**
![Preview-20200806](/uploads/33a734b69bd148a4cf63128a082cb75d/Preview-20200806.jpg)
Features:
1. @mention user and role (in plural, e.g. @previewers)
2. Reply icon to make reply. Showing replies are Linked/referenced to the original comment. We'll develop the reply functionality after this first version is tested.
3. The user can see in the chat when a new preview has been generated, so they know which comments relate to an older/out-of-date preview. See line with text ‘ch01.docx (V3) preview generated’ in the wireframe.
6. Similarly, users can see within the chat when the preview was marked as ‘ready to publish’ and ‘published’ by editor (not shown in wireframe, but in the same style as point 3).
7. Users can comment/ask a questions without necessarily having to make a decision with 'comment' button.
8. When no *approval* of a preview is required (as set in the Settings modal), users may still want to be able ask a question about the preview. So instead so hiding the review panel completely, this should show *without* all the radio buttons (approve, request changes, etc.)
9. The files (that have been attached in the review panel) should show in the files tab so they are easy to access/ don't get lost in the thread. This should be a separate section to the book component files, called 'Review'.Review book partsSidorela UkuSidorela Ukuhttps://gitlab.coko.foundation/ncbi/ncbi/-/issues/151Admin page search doesn't work if there is space between words2021-05-19T16:59:45ZSidorela UkuAdmin page search doesn't work if there is space between wordsHi @danjela,
When trying to search based on name of organization, if we search more than a word it shows no results
For example:
![image](/uploads/882e00418104282df8571e80dd823215/image.png)
When searching 'test organization' doesn't ...Hi @danjela,
When trying to search based on name of organization, if we search more than a word it shows no results
For example:
![image](/uploads/882e00418104282df8571e80dd823215/image.png)
When searching 'test organization' doesn't filter anything.
![image](/uploads/9db46c7bd78d60a4ac744a5309a9a23d/image.png)
There was also another related issue #34 related to search.https://gitlab.coko.foundation/ncbi/ncbi/-/issues/152bulk upload problems - related to cache?2021-01-19T19:11:27ZStacy Lathropbulk upload problems - related to cache?@DioneMentis - per Mattermost, we are having problems when trying to bulk upload all 15 of the provided bacvir4ed sample docs at one time.
Sent video via Mattermost of experience in Chrome after clearing history - video cut off, but aft...@DioneMentis - per Mattermost, we are having problems when trying to bulk upload all 15 of the provided bacvir4ed sample docs at one time.
Sent video via Mattermost of experience in Chrome after clearing history - video cut off, but after more than 10 min the files did appear.
If I load in Chrome Incognito on first try, this batch of files took 4 min to appear.
Each itme I loaded to Chrome after having quite a bit of history, the files never loaded.
So it does look like a cache issue - I think some of our power users will do multiple bulk uploads without clearing history in browser session, so don't know if this will pose a problen or not with full integrationprocess filesGiannis Kopanasjkopanas@gmail.comGiannis Kopanasjkopanas@gmail.comhttps://gitlab.coko.foundation/ncbi/ncbi/-/issues/153bulk upload does not work for new version of component2021-01-13T18:59:56ZStacy Lathropbulk upload does not work for new version of componentIf you create a new version component and upload a file to component via bulk upload it does not actually load..
Will send video via Mattermost.If you create a new version component and upload a file to component via bulk upload it does not actually load..
Will send video via Mattermost.process filesSidorela UkuSidorela Ukuhttps://gitlab.coko.foundation/ncbi/ncbi/-/issues/154book metadata modal does not open properly in 20200804 dev work2020-08-27T15:30:51ZStacy Lathropbook metadata modal does not open properly in 20200804 dev workWhen NCBI testers click on the book metadata button a blank page appears - no metadata fields are provided to be populated
Video provided by Mattermost to @DioneMentisWhen NCBI testers click on the book metadata button a blank page appears - no metadata fields are provided to be populated
Video provided by Mattermost to @DioneMentisSidorela UkuSidorela Ukuhttps://gitlab.coko.foundation/ncbi/ncbi/-/issues/155provide error notice when upload wrongly named Word doc2021-01-13T18:59:56ZStacy Lathropprovide error notice when upload wrongly named Word docWhen try to upload the wrongly named file it doesn't allow it (good) but you don't get an indication why (confusing) - can we add an error notice if user tries to upload a file that does not meet file specifications?
![image](/uploads/9...When try to upload the wrongly named file it doesn't allow it (good) but you don't get an indication why (confusing) - can we add an error notice if user tries to upload a file that does not meet file specifications?
![image](/uploads/942a1e3f7a8a282920f9170693413f4e/image.png)process filesDanjela Shehidanjelashehi@gmail.comDanjela Shehidanjelashehi@gmail.comhttps://gitlab.coko.foundation/ncbi/ncbi/-/issues/156Wrapping of long book component titles2021-01-19T19:11:27ZDione Mentisdione@coko.foundationWrapping of long book component titlesHi @danjela
Noting this from feedback in #149 -- I will discuss this with with Henrik first.
![ncbi_48](/uploads/87cf6cccf92f6af9661552dc7bbee0bd/ncbi_48.png)Hi @danjela
Noting this from feedback in #149 -- I will discuss this with with Henrik first.
![ncbi_48](/uploads/87cf6cccf92f6af9661552dc7bbee0bd/ncbi_48.png)Dione Mentisdione@coko.foundationDione Mentisdione@coko.foundationhttps://gitlab.coko.foundation/ncbi/ncbi/-/issues/157Display filename2021-01-19T19:11:27ZDione Mentisdione@coko.foundationDisplay filenameFrom #149:
>When uploading a new word doc to a new book version without any existing files or really at any time, it would be useful to have an indication of the filename related to that component - users may not know from title what t...From #149:
>When uploading a new word doc to a new book version without any existing files or really at any time, it would be useful to have an indication of the filename related to that component - users may not know from title what that the associated source file name is, especially if authors or other users change (since even ncbi testers familiar with files and titles got confused during testing what file should be uploaded without a guide). Perhaps this file name / id should be above all the tabs with the title?
I'll discuss design for this with Henrikhttps://gitlab.coko.foundation/ncbi/ncbi/-/issues/158Login page implementation2021-03-26T13:53:58ZYannis BarlasLogin page implementation![ncbi_login_design](/uploads/850c6f38294c27393789191be141224b/ncbi_login_design.png)
We need a react component with the above design for the login page.
Some notes:
* This should be developed in storybook with a minimum of one defau...![ncbi_login_design](/uploads/850c6f38294c27393789191be141224b/ncbi_login_design.png)
We need a react component with the above design for the login page.
Some notes:
* This should be developed in storybook with a minimum of one default story and related prop types declarations.
* We only need the "box". (ie. ignore the gray background and logo, as these will change)
* Ignore the "remember me" feature for this iteration.
* "Forgot password" and "register" should accept urls through props.
* Dont' worry about fonts and colors, as those will change. It is still expected that everything is positioned correctly.https://gitlab.coko.foundation/ncbi/ncbi/-/issues/159Chapters metadata updates are not saved2020-08-13T18:29:12ZSidorela UkuChapters metadata updates are not savedHi @John.kopanas
There is a bug on the staging site. When I make a change on the chapters metadata, the Save button doesn't work or update. While this is working correctly on nbci site.
![image](/uploads/1ee28fcfb958e41800d3c04811143c...Hi @John.kopanas
There is a bug on the staging site. When I make a change on the chapters metadata, the Save button doesn't work or update. While this is working correctly on nbci site.
![image](/uploads/1ee28fcfb958e41800d3c04811143cf3/image.png)https://gitlab.coko.foundation/ncbi/ncbi/-/issues/160Team modal: userlist not scrollable (can not see the usernames in the dropdown)2020-08-25T14:14:37ZSidorela UkuTeam modal: userlist not scrollable (can not see the usernames in the dropdown)Hi @danjela
When clicking on the 'Team' to add more users/roles to a book the dropdown list for the usernames is not scrollable. In the screenshot there are 5 users which can be added (assuming that there might be many more), we can't ...Hi @danjela
When clicking on the 'Team' to add more users/roles to a book the dropdown list for the usernames is not scrollable. In the screenshot there are 5 users which can be added (assuming that there might be many more), we can't see their usernames from the dropdown list.
![users-list](/uploads/a2e4781a4bccf555bf63de2b619230a9/users-list.png)