ncbi issues
https://gitlab.coko.foundation/ncbi/ncbi/-/issues
2024-01-16T17:29:20Z
https://gitlab.coko.foundation/ncbi/ncbi/-/issues/804
Inconsistent behavior in permitting ingest of tagged XML from PDF
2024-01-16T17:29:20Z
Stacy Lathrop
Inconsistent behavior in permitting ingest of tagged XML from PDF
cc @douglassue
## Expected behaviour
System creates error if chapter-processed files do not meet file naming specifications regardless if posted to FTP by taggers or manually uploaded.
## Current behaviour
System ingests chapter-pro...
cc @douglassue
## Expected behaviour
System creates error if chapter-processed files do not meet file naming specifications regardless if posted to FTP by taggers or manually uploaded.
## Current behaviour
System ingests chapter-processed tagged files from PDF that are not named the same as the source file. This file is processed all the way to the publish state.
System creates error if user tries to manually upload a edited tagged file that is not named the same as the source file.
## Steps to reproduce
See: https://ncbi.cloud68.co/organizations/4dd138c1-1baa-437b-8a0e-d25b91319687/bookmanager/821733d2-6057-425e-bc8f-955457f6c36c/59f88edc-5f7c-4aa8-b39b-6258570f3608
![image](/uploads/ceeb5f3075c20309f83946e9c43150c9/image.png)
1. Download files and package as tagged files from PDF2XML taggers
2. Once published, download converted file and try to reupload
## Solution
Since this problem occurs when the Vendor submit a converted file that should not be accepted, this should be considered a "Tagging error". This solution described here is [documented as user story 5a in the BCMS scoping outcomes list](https://docs.google.com/spreadsheets/d/1ksBkzJjzTsmW3vtaTgrSL7nqzZEvOP0dSwaAscAX9d8/edit?usp=sharing)
1. Apply a new Status "Tagging error" to the PDF workflow (with the user actions defined in the [Status/Action sheet](https://docs.google.com/spreadsheets/d/1M4ZdBbzr2s4-PUXqEblfsKoPBUuk4aG343u9ZAUn_Tk/edit?usp=sharing))
2. When Vendor submits Chapter package with a converted file that does not have the same filename as the existing source file, put the chapter into a "Tagging error" state.
3. Report the following error on the errors tab
| Name | Category | Severity | Assignee | Error Message |
|-------------|----------------------|------|---|-------|
| file naming | Tagging error | error | Vendor | The converted file name must match the source file name |
(This is included on the [error tracking sheet](https://docs.google.com/spreadsheets/d/1bcOKaEihkrX4LR6cAWcKjQelcIolLiHH1e4AEbDR_4g/edit?usp=sharing))
4. Email the Sys admin assigned to the Org and the PDF2XML Vendor (this will only be done by #1296)
5. The Vendor submits a corrected package, and the status of the chapter updates accordingly, or a System admin can download the converted file, rename and upload it, to resolve the Tagging errors status.
## Priority
Y, if there is no workaround to prevent file version and content integrity issues on Bookshelf
## Remaining tasks
Note NCBI task remaining to complete in https://gitlab.coko.foundation/ncbi/ncbi/-/issues/804#note_97990
### QA Steps
- For PDF chapter processed books, we validate the filename that is uploaded on the converted section via UI. So if it doesn't match with the source it will not be uploaded.
- Tagging-errors status can be caused by the submission via ftp. Steps to reproduce:
1. Create a PDF chapter-processed book
2. Upload any source file
3. Download the vendor-meta.xml from the book component file tab
4. Connect with APEX ftp
5. Create a package similar to this [compress18aug.zip](/uploads/c02e67669acd61317e2480b7eb2d7a69/compress18aug.zip). Where the filename on the converted folder doesn't match with the source. Replace the vendor-meta.xml with the one you downloaded on step 3.
6. Submit the source file for tagging
7. The package which was created on step 5, submit it to ftp folder /done/testbcms
8. When the package is sent to ncbi, the converted file will appear on the UI and the status will be tagging-errors.
P05: Address MVP Files Management and Processing Issues to support all current Bookshelf submitters and NCBI Integration specifications
Stacy Lathrop
Stacy Lathrop
https://gitlab.coko.foundation/ncbi/ncbi/-/issues/1036
Book TOC invalid XML because RID attributes reference unknown xref ids not in...
2024-01-16T17:35:15Z
Dione Mentis
dione@coko.foundation
Book TOC invalid XML because RID attributes reference unknown xref ids not in TOC XML
## Expected behaviour
The TOC that the BCMS generates should be valid
## Current behaviour
In [this example book](https://ncbi.cloud68.co/organizations/6b3576c3-eb69-42a2-8f60-bfbca9df9dcc/bookmanager/585d921f-13be-4513-9a8a-600f87ac7...
## Expected behaviour
The TOC that the BCMS generates should be valid
## Current behaviour
In [this example book](https://ncbi.cloud68.co/organizations/6b3576c3-eb69-42a2-8f60-bfbca9df9dcc/bookmanager/585d921f-13be-4513-9a8a-600f87ac71a9/toc/53c97891-0a76-4f40-ba40-853a7a007da0) which is a chapter processed book, the TOC gets an error when you try to publish it, because of invalid XML.
The error reported is: TOC.xml: Invalid XML.<br>-:36: parser warning<br>: xmlParsePITarget: invalid name prefix 'xml'<br> <?xml_file consstemcellmet.xml?><br> ^<br>-:26: element xref: validity error :<br>IDREFS attribute rid references an unknown ID "consstemcellmet.fn1"<br>
If you go to the chapter called 'Bone Marrow or Blood Stem Cell Transplants in Children With Certain Rare Inherited Metabolic Diseases* (https://ncbi.cloud68.co/organizations/6b3576c3-eb69-42a2-8f60-bfbca9df9dcc/bookmanager/585d921f-13be-4513-9a8a-600f87ac71a9/part/undefined/112d658f-34f8-4d63-ad20-481d7edd59c8), you will see that the converted XML [consstemcellmet.xml](/uploads/62fc247e255e68d2d0adbe859dde7f0a/consstemcellmet.xml) shows a footnote in the chapter title, like this:
`<title>Bone Marrow or Blood Stem Cell Transplants in Children With Certain Rare Inherited Metabolic Diseases<xref ref-type="fn" rid="consstemcellmet.fn1">*</xref>`
When you look at [the preview or published version of that chapter](https://ncbi.cloud68.co/organizations/6b3576c3-eb69-42a2-8f60-bfbca9df9dcc/bookmanager/585d921f-13be-4513-9a8a-600f87ac71a9/part/undefined/112d658f-34f8-4d63-ad20-481d7edd59c8), you can see that in the preview, the footnote displays fine and the preview is correct. We can't strip the footnote from the chapter XML because we need it for the preview to display correctly. However this footnote is causing issues when we try publish the TOC of the book, in the TOC XML that we write, which includes the chapter title with the footnote XREF. The footnote referred to is not present in the TOC (because we only have the chapter title there and can't have the referenced footnote there), so the error shown above occurs.
## Solution
We can't strip the footnote out of the chapter title everywhere because it previews for the chapter preview and is valid, so it needs to remain in the converted chapter XML, but when we build the TOC XML, we need to strip the footnote totally out of the chapter title (when a footnote exists for the chapter title), and we need to strip all `<xref>` and `ref-type` attributes when building the TOC in case there are others that can cause invalid TOC XML.
## Steps to reproduce
1. Create a chapter processed PDF book and upload this chapter [consstemcellmet.xml](/uploads/62fc247e255e68d2d0adbe859dde7f0a/consstemcellmet.xml)
2. Publish the chapter and make sure it published successfully (you'll see to fill out required metadata fields first)
3. Once the chapter is published try publish the TOC, see the error that appears.
## Priority
Y
## QA Steps
1. Create a chapter processed PDF book of 'full text' content type
2. Upload the source: [consstemcellmet.pdf](/uploads/ef59833815e39ec78485055c26567f95/consstemcellmet.pdf)
3. and upload this converted [consstemcellmet.xml](/uploads/62fc247e255e68d2d0adbe859dde7f0a/consstemcellmet.xml)
4. Fill out the required metadata field
5. Publish the chapter and make sure it publishes successfully
6. Publish the TOC and check that TOC is published successfully
7. For existing books, the file should be submitted or reloaded again, in order to have the converted file updated before publishing the toc again.
P04: Support valid and compliant TOC XML for all migrated Bookshelf content
https://gitlab.coko.foundation/ncbi/ncbi/-/issues/1096
Allow new user registration when first and last name are not unique
2024-01-16T18:11:02Z
ChristinaTromp
Allow new user registration when first and last name are not unique
Hey @andynicholson cc @DioneMentis
There is one use case related to #1089 that we still need to cater for which I confirmed with Dione.
When a user signs up with unique details, except for their first and last name, they should still b...
Hey @andynicholson cc @DioneMentis
There is one use case related to #1089 that we still need to cater for which I confirmed with Dione.
When a user signs up with unique details, except for their first and last name, they should still be able to sign up. For example, if two different people named John Smith exist, they should both be able to use the BCMS without making their *name* unique (but they will need to use a unique email and username).
At the moment, if all your details are unique except your first and last name, you get the following error:
1. First I registered a new unique account
![Screen_Shot_2022-03-15_at_08.58.44](https://gitlab.coko.foundation/ncbi/ncbi/uploads/fe7203ae43c9d98151e0772d462716ed/Screen_Shot_2022-03-15_at_08.58.44.png)
1. Then I tried to register another account with the same first and last names, with all other details (email, username) unique, and got this error:
![Screen_Shot_2022-03-15_at_09.06.48](https://gitlab.coko.foundation/ncbi/ncbi/uploads/65bdd7e0749b0ec0ce3c2d39162a2ad7/Screen_Shot_2022-03-15_at_09.06.48.png)
When all details are unique, except first and last name, we should allow them to register.
P10: BCMS Production Deployment Issues
Stacy Lathrop
Stacy Lathrop
https://gitlab.coko.foundation/ncbi/ncbi/-/issues/1149
Previously published chapter that has a replacement chapter file version in p...
2024-01-16T17:36:23Z
Diana jordan
Previously published chapter that has a replacement chapter file version in previewing status does not show original published version of chapter on toc
@ChristinaTromp @lathrops1
## Expected behaviour
toc should be accurate:
- a chapter should be included in the TOC.xml build when it is published and should remain on the TOC.xml even if the current *file version* is not published
...
@ChristinaTromp @lathrops1
## Expected behaviour
toc should be accurate:
- a chapter should be included in the TOC.xml build when it is published and should remain on the TOC.xml even if the current *file version* is not published
## Current behaviour
a previously published chapter is no longer showing in the TOC if an update is previewing
## Steps to reproduce
https://ncbi.cloud68.co/organizations/32d78686-4b9a-46af-b52a-f5d0c4052177/bookmanager/18e972c9-df07-4dee-975d-00230567ea8f
1. publish a chapter (in example see chapter LM584.docx)
2. publish a TOC and see chapter shows in TOC
3. update the chapter so that it is now in previewing status
4. publish toc again (user was working on and published other chapters hence reloaded toc)
5. see that original chapter that is now previewing is no longer in TOC
## NCBI's priority feedback
y, for deployment - need to be able to process and have accurate data
## QA Steps
[To be completed by Coko once dev is done]
P04: Support valid and compliant TOC XML for all migrated Bookshelf content
https://gitlab.coko.foundation/ncbi/ncbi/-/issues/1170
Add chapter files to Book TOC package for NCBI wholebook PDF build
2024-01-08T23:43:26Z
Stacy Lathrop
Add chapter files to Book TOC package for NCBI wholebook PDF build
@DioneMentis -
@ChristinaTromp @latternm
## Context
As discussed last Wed, we are blocked to complete development of our wholebook PDFs based on the new BCMS chapter-processed workflow because when we "put the book back together" we...
@DioneMentis -
@ChristinaTromp @latternm
## Context
As discussed last Wed, we are blocked to complete development of our wholebook PDFs based on the new BCMS chapter-processed workflow because when we "put the book back together" we don't have access to all of the images and suppl files. We also know that we planned in the future to have a bulk download of all chapter-processed book files functionality.
## Proposal
For the the BCMS to dump all chapter-processed book files and make them available to NCBI by FTP when the BCMS passes a TOC.XML file to NCBI, and to do this in a way that can be reused in the future as a bulk download of all chapter-processed book files that BCMS users can use.
## Scoping outcome
Miro ref: [scoping session 5](https://miro.com/app/board/o9J_lEzF9oQ=/?moveToWidget=3458764535261860705&cot=10)
[User story 19](https://docs.google.com/spreadsheets/d/1ksBkzJjzTsmW3vtaTgrSL7nqzZEvOP0dSwaAscAX9d8/edit?usp=sharing): BCMS systems require book images and supplementary file at time of TOC ingest so that they can generate one PDF for the complete book from all of its components
This image summarises the discussion we had during the Scoping session
![image](/uploads/5035357636e43bc7faae44c6e0dfafa1/image.png)
## Design
No update relevant to the frontend
## Agreed Implementation
1. Add the following files types to Book TOC package and send the package in same process as currently done:
* images
* suppl
* converted chapter
2. Build this type of TOC package only when a a chapter-processed book has the setting ON for "display book-level PDF"
Note for the files types: only include files corresponding to the Published chapter (or the *latest* published version chapter number if there are multiple published versions). This is the `<?version ?>` specified in the TOC.xml
Time estimate: 3 days
## Alternative approaches (if applicable)
Additionally the BMCS could check if any filenames are the same when creating TOC package, if yes, the report this as a Publishing error (this adds 1 day to time estimate)
## Open issues (if applicable)
[Links to and a discussion of related issues, if applicable.]
## Acceptance Criteria
- [ ] Users can select create wholebook PDF and display book-level PDF for chapter-processed books and when they do so load their contents successfully
- [ ] NCBI generated wholebook PDFs will be accurate and of the the same quality as those generated from Silverlight CMS BXML
P05: Address MVP Files Management and Processing Issues to support all current Bookshelf submitters and NCBI Integration specifications
https://gitlab.coko.foundation/ncbi/ncbi/-/issues/1178
"Ignore book order" domain attribute is not set for yes for Word One Doc book
2024-01-09T02:18:05Z
Stacy Lathrop
"Ignore book order" domain attribute is not set for yes for Word One Doc book
@DioneMentis @ChristinaTromp
## Expected behaviour
The domain attribute should be set as "yes" for "ignore book order" Word One Doc books.
One Doc books use the chapter-processed book settings template. See the domain attribute here...
@DioneMentis @ChristinaTromp
## Expected behaviour
The domain attribute should be set as "yes" for "ignore book order" Word One Doc books.
One Doc books use the chapter-processed book settings template. See the domain attribute here: https://docs.google.com/spreadsheets/d/1Xd0vKDbaYrajfnUmYqCnXUY5Ir0znqc7o0KGVp_okg0/edit#gid=1460870662&range=186:186
See original specification in feature issue #215
## Current behaviour
User gets loading error because the domain attribute is not set as "yes" for "ignore book order" Word One Doc books
## Steps to reproduce
1. Go to: https://ncbi.cloud68.co/organizations/308db55a-21c9-4a64-9a70-d5aa7574726c/bookmanager/483e9438-8e7f-468e-8ce2-d2c5b4352c50/17c9300b-ab9a-49db-bc3a-88c82c777189
2. See Loading Error - notice the error itself is not appearing - I am working on NCBI to make sure it is sent, but it says:
"ERROR: Missing book order file"
## NCBI's priority feedback
Y, for deployment
## QA Steps
[To be completed by Coko once dev is done]
P06: MVP Data Model and Integrity Issues to Ensure Data Quality in Bookshelf and NLM Databases
https://gitlab.coko.foundation/ncbi/ncbi/-/issues/1296
Email Error notification: When a converted package submission from PDF2XML ve...
2023-06-12T18:33:36Z
Dione Mentis
dione@coko.foundation
Email Error notification: When a converted package submission from PDF2XML vendor results in a Tagging error status, notify the PDF2XML Vendor and System Admin
## Context
This email use case applies to:
1. Submissions of converted packages in the PDF workflow to the BCMS prior to loading to PMC
2. Kafka topics: submit_apex_package_receipt
3. BCMS generated error as developed in #804
## Prop...
## Context
This email use case applies to:
1. Submissions of converted packages in the PDF workflow to the BCMS prior to loading to PMC
2. Kafka topics: submit_apex_package_receipt
3. BCMS generated error as developed in #804
## Proposal
1. When BCMS receives an error report for the above topic with **Status=3** send email notification to the PDF2XML vendor and System Admin. (see related development completed in #566)
2. When Vendor submits Chapter package with a converted file that does not have the same filename as the existing source file, send email notification to the PDF2XML vendor (see related development completed in #804) and System Admin
## Email template for chapter
```
From: NCBI Bookshelf
Date: [Date email sent]
To: [User email]
Subject: Failed to process: Chapter [Title of component] in [Book Title] ([BCMS ID])
Your chapter [Title of component] in [Book title] belonging to the organization [Organization name] failed to process.
Please find a list of errors below:
[List All ERRORS and QUERIES that result in Tagging error status]
If you have any questions about this email, please contact the NCBI Bookshelf at booksauthors@ncbi.nlm.nih.gov.
Thank you,
NCBI Bookshelf
[Main BCMS link]
[Bookshelf public site link]
```
## Email template for book
```
From: NCBI Bookshelf
Date: [Date email sent]
To: [User email]
Subject: Failed to process: Book [Title of component] ([BCMS ID])
Your book [Title of component] belonging to the organization [Organization name] failed to process.
Please find a list of errors below:
[List All ERRORS and QUERIES that result in Tagging error status]
If you have any questions about this email, please contact the NCBI Bookshelf at booksauthors@ncbi.nlm.nih.gov.
Thank you,
NCBI Bookshelf
[Main BCMS link]
[Bookshelf public site link]
```
## Example email for chapter
From: NCBI Bookshelf
Date: [Date email sent]
To: [User email]
Subject: Failed to process: Chapter Search in Bookshelf Help (bcms789123)
The chapter **Search** in **Bookshelf Help** from the organization **National Institutes of Health** failed to process.
Please find a list of errors below:
The converted file name must match the source file name.
If you have any questions about this email, please contact the NCBI Bookshelf at booksauthors@ncbi.nlm.nih.gov.
Thank you,
NCBI Bookshelf
[Main BCMS link]
[Bookshelf public site link]
## Notes for developers
P08: MVP BCMS Notifications Issues and Improvements
https://gitlab.coko.foundation/ncbi/ncbi/-/issues/1308
Unable to process chapter published versions
2024-01-08T23:45:26Z
Stacy Lathrop
Unable to process chapter published versions
cc @ChristinaTromp @jordandc
## Expected behaviour
User should be able to create a chapter published version
## Current behaviour
User is unable in any workfow to create chapter published versions
## Steps to reproduce
Try to crea...
cc @ChristinaTromp @jordandc
## Expected behaviour
User should be able to create a chapter published version
## Current behaviour
User is unable in any workfow to create chapter published versions
## Steps to reproduce
Try to create a chapter publisher version at:
word - https://ncbi.cloud68.co/organizations/6b3576c3-eb69-42a2-8f60-bfbca9df9dcc/bookmanager/0d2738f8-61b1-45ff-abe8-1775f4769b42/65c6be43-fe0a-4b2b-9cab-03f20758b9ac
pdf - https://ncbi.cloud68.co/organizations/6b3576c3-eb69-42a2-8f60-bfbca9df9dcc/bookmanager/3aa72844-bcdd-4dc7-be3a-02460f45ac7d/002cdd83-1616-4c65-a578-9b02a78c072d
See movie to reproduce here:
[127.0.0.2_3390_-_Remote_Desktop_Connection_2022-07-20_17-34-47.mp4.zip](/uploads/4f0d971ad9cb3b3cfc74e7e7d26ac803/127.0.0.2_3390_-_Remote_Desktop_Connection_2022-07-20_17-34-47.mp4.zip)
## NCBI's priority feedback
Y
## QA Steps
1. Create a chapter processed Word book (this can be replicated with xml and pdf chapters as well)
2. Turn on the toggle 'Support multiple published versions' in the settings modal
3. Upload chapters which would result of successful preview and then you can publish
4. Go to the book component page which has status published and click the button 'New Published Version'
5. A new version of the book component will be created as below
![image](/uploads/48dd87623d2e62122a8b01cc07811ac1/image.png)
Example [here](https://ncbi.cloud68.co/organizations/3dc22c09-b3d8-44d1-9dd6-ac9baf69163e/bookmanager/8794fb01-7ae3-4af5-bdc8-c4648da32074/part/13c5aff4-33c0-4190-b945-f3cad2ab5ca9/73b6b054-9046-4b3b-a703-a7937eb9f14d)
P05: Address MVP Files Management and Processing Issues to support all current Bookshelf submitters and NCBI Integration specifications
https://gitlab.coko.foundation/ncbi/ncbi/-/issues/1316
Book status changed to "Tagging" after pressing the "Reload Preview" button (...
2024-01-08T23:42:19Z
Erin Schmieder
Book status changed to "Tagging" after pressing the "Reload Preview" button (PDF wholebooks only)
## Expected behaviour
Books status expected to change to "Loading Preview" when user clicks Reload preview button
## Current behaviour
Status changed to "Tagging" after clicking Reload preview button
## Steps to reproduce
* Organiza...
## Expected behaviour
Books status expected to change to "Loading Preview" when user clicks Reload preview button
## Current behaviour
Status changed to "Tagging" after clicking Reload preview button
## Steps to reproduce
* Organization: Erin Book Version Permissions Testing
* Book: WHO guideline on self-care interventions for health and well-being, 2022 revision
* Version: Final Full Text V1
* Was logged into the BCMS as a system admin
https://ncbi.cloud68.co/organizations/03f79aa4-1577-43eb-99e8-8b9b827f0ba5/bookmanager/6800dc28-092f-44c3-9a2f-2d7871f0b4bb
To reproduce:
* The book was is a “Loading Errors” status
* Based on that, I downloaded the converted file, edited it, and reuploaded it
* Then I pressed the Reload Preview button on the Files tab
* Actual Result: The status changed to “Tagging”
* Expected Result: The status should change to “Loading preview”
Update from Coko testing in https://gitlab.coko.foundation/ncbi/ncbi/-/issues/1316#note_100647
* This issue only happens in PDF wholebooks that have more than one source file (with different file names) in status tagging.
* When you click reload preview it goes to the status tagging.
## Environment
PC, Microsoft Edge
## Possible solution
N/A
## NCBI's priority feedback
[Select "Y" or "N" and provide an explanation]
1. This bug is blocking NCBI's work on migration planning for deployment 1 (Y/N)
2. This can be prioritised after deployment 1 (Y/N)
## QA Steps
[To be completed by Coko once dev is done]
cc @lathrops1
P05: Address MVP Files Management and Processing Issues to support all current Bookshelf submitters and NCBI Integration specifications
https://gitlab.coko.foundation/ncbi/ncbi/-/issues/1322
Multiple versions appearing on Collection pages and Dashboards
2024-01-02T17:28:43Z
Stacy Lathrop
Multiple versions appearing on Collection pages and Dashboards
## Expected behaviour
1. The Dashboard should display a list of all collections and the current version of all Books
2. Collection pages should display as how a Collection is built and that only has the most recent book version.
## ...
## Expected behaviour
1. The Dashboard should display a list of all collections and the current version of all Books
2. Collection pages should display as how a Collection is built and that only has the most recent book version.
## Current behaviour
1. All book version appear on the Dashboard
2. All book version appear on a collection page
## Steps to reproduce
Go to Org at: https://ncbi.cloud68.co/organizations/3293395b-7809-4bed-8b84-8bdc6d86f895
![image](/uploads/7c365fdccbd3b04cc657b90a0c36d536/image.png)
See multiple book versions.
See latest feedback from testing on Collection pages in: https://gitlab.coko.foundation/ncbi/ncbi/-/issues/1322#note_95880
## Implementation
**Option 1**
1. On Dashboard, roll up all versions of the same book into one row
2. On Collection manager page, roll up all versions of the same book into one row
**Option 2**
Keep the functionality as it is and just add a filter that lets the user hide the previous versions
Take into account, for this option: If a book has a high number of versions, this could affect loading performance. This testing should be done to validate the threshold and if necessary make amendments. (Since we already have pagination on both UIs, we expect low effort to resolve any performance issues).
## NCBI's priority feedback
Y - need to test the extent of this damage and its repercussions, but this is not a faithful collection list
## QA Steps
[To be completed by Coko once dev is done]
P09: Book Manager and other MVP BCMS improvements and Lower Priority Bug Fixes
https://gitlab.coko.foundation/ncbi/ncbi/-/issues/1377
In chapter-processed book metadata: When OA toggle is on, and license type = ...
2024-01-16T17:32:17Z
Stacy Lathrop
In chapter-processed book metadata: When OA toggle is on, and license type = 'Other', user should be required to provide a license URL
## Expected behaviour
Ability to migrate our chapter-processed books and collection metadata. Need to be able to have a license URL field in chapter processed book and collection metadata, when the user turns the OA toggle on and choose...
## Expected behaviour
Ability to migrate our chapter-processed books and collection metadata. Need to be able to have a license URL field in chapter processed book and collection metadata, when the user turns the OA toggle on and chooses 'Other' as the license type, the field should appear below the license type and validate that the input is a URL. The URL should also be written into the book metadata XML, and for the case of collections, in the collection metadata XML.
## Current behaviour
Unable to migrate Other license URLs to be tagged as attributes. No field appears for this.
## Steps to reproduce -
See:
Try to enter a custom license URL if select yes OA and Other, which should require a license URL to be tagged as an attribute - see attempt here:
https://nih.webex.com/recordingservice/sites/nih/recording/b6fb2930fe66103a967f42aca848dcda/playback
https://ncbi.cloud68.co/organizations/308db55a-21c9-4a64-9a70-d5aa7574726c/bookmanager/e6e614f1-68ae-44ce-a3f5-c299225d836f
Tagging target need to be able to produce / have BCMS write:
```
<license xmlns:xlink="http://www.w3.org/1999/xlink" license-type="open-access"
xlink:href="https://www.ncbi.nlm.nih.gov/books/NBK138602/">
<license-p>GeneReviews® chapters are owned by the University of Washington. Permission is
hereby granted to reproduce, distribute, and translate copies of content materials for
noncommercial research purposes only, provided that (i) credit for source (<ext-link
ext-link-type="uri" xlink:href="http://www.genereviews.org/"
>http://www.genereviews.org/</ext-link>) and copyright (© 1993-2020 University of
Washington) are included with each copy; (ii) a link to the original material is provided
whenever the material is published elsewhere on the Web; and (iii) reproducers,
distributors, and/or translators comply with the <related-object source-id="gene"
document-id="GRcopyright_permiss">GeneReviews® Copyright Notice and Usage
Disclaimer</related-object>. No further modifications are allowed. For clarity, excerpts
of GeneReviews chapters for use in lab reports and clinic notes are a permitted
use.</license-p>
<license-p>For more information, see the <related-object source-id="gene"
document-id="GRcopyright_permiss">GeneReviews® Copyright Notice and Usage
Disclaimer</related-object>.</license-p>
<license-p>For questions regarding permissions or whether a specified use is allowed,
contact: <email>admasst@uw.edu</email>.</license-p>
</license>
```
(There are other examples of this in collections / chapter-processed books we need to migrate)
## Solution
In a chapter processed book, in book metadata, when the user turns the OA toggle on, and then chooses 'Other' as the license type, a required field should appear below the license type and validate that the input is a URL starting with `http://` or `https://`. The URL should then be written into the book metadata XML at the same time that the other book metadata is written. The XML format should be as below, where the second line is the URL the user input (https://www.ncbi.nlm.nih.gov/books/NBK138602/).
```
<license xmlns:xlink="http://www.w3.org/1999/xlink" license-type="open-access"
xlink:href="https://www.ncbi.nlm.nih.gov/books/NBK138602/">
```
## NCBI's priority feedback
Y, migration blocker
## QA Steps / Acceptance Criteria
1. Create a chapter-processed book.
2. In the Metadata of the book, fill in the required fields and also turn the OA toggle on, and choose 'Other' as the license type.
3. Notice that the fields "License url" is now editable.
4. Type a valid url in the License url.
5. Upload a chapter and submit it for conversion.
6. In the converted file, check the XML format includes the license url, as per the example below:
```
<license license-type="open-access" xmlns:xlink="http://www.w3.org/1999/xlink"
xlink:href="https://www.ncbi.nlm.nih.gov/books/NBK138602/"><license-p>license
`statement</license-p></license>
```
7. Go back to the Metadata Modal and see that the "License URL" is still there as entered
P03: Support valid and compliant metadata for all migrated Bookshelf content
https://gitlab.coko.foundation/ncbi/ncbi/-/issues/1385
Add ability to archive books and collections via settings
2024-01-09T02:17:24Z
Stacy Lathrop
Add ability to archive books and collections via settings
<!-- Required. Provide a general summary of the issue in the title above -->
## Context
Users should be able to use settings to meet Bookshelf agreements requirements to accurately display status and updates, and we should also be able...
<!-- Required. Provide a general summary of the issue in the title above -->
## Context
Users should be able to use settings to meet Bookshelf agreements requirements to accurately display status and updates, and we should also be able to migrate these settings for legacy content for same reasons.
We delayed "Archive" functionality as an Action / Button via the UI because we said we could still handle this through BCMS settings, but as we try to do Greenlight testing early, we find we cannot archive any domain (or any books and collections) via settings to support our agreements. We also need to migrate these settings for version control pre-deployment.
## Proposal
In wholebooks and Word complete books we already have a section called 'Archiving and updating' with settings:
1. 'Create version link'
2. 'Version link text'
3. 'Version link URI'
Extended feature:
1. In wholebooks and Word complete books settings UI: add the new Domain Status dropdown to the exisiting 'Archiving and updating' section
1. In Chapter-processed book settings UI: add only the 'Archiving and updating' section heading and the new Domain Status dropdown in the design below.
1.In Collection settings UI: add only the 'Archiving and updating' section heading and the new Domain Status dropdown in the design below.
Allow the user to choose the status of this domain, from three options:
1. Current --> The default option. When selected, the domain settings are `'archive-version: no'`, and `'validity: valid'`
2. Archived --> When is selected, the domain settings are: `'archive-version: yes'`, and `'validity: expired'`.
3. Withdrawn --> editable by Sys admins only. When selected, the domain settings are `'archive-version: yes'`, and `'validity: withdrawn'`.
Note for book template functionality: Even though this setting only shows in the UI after set up, it exists in book's template. Therefore the domain settings that correspond to the choice "Current" must be set in the chapter-processed and wholebook clone domains.
The options are mutually exclusive (you can't choose more than one at a time) so a dropdown is suitable in order to make the user choose one.
The tooltip text is: Indicates the status of the domain on the Bookshelf site. Note, Withdrawn is only selectable by System admins.
## Design
### Chapter processed books and collections domain status default
![The_BCMS_-_Chapter_processed_books_and_collections_domain_status_default](/uploads/f1e80b5ef6663948e292a855e4f8e9af/The_BCMS_-_Chapter_processed_books_and_collections_domain_status_default.jpg)
### Chapter processed books and collections domain status non-System admin options
![The_BCMS_-_Chapter_processed_books_and_collections_domain_status_non-Sys_admin_options](/uploads/4d69bc90f85cf4f517bfee9a16c45e47/The_BCMS_-_Chapter_processed_books_and_collections_domain_status_non-Sys_admin_options.jpg)
### Chapter processed books and collections domain status System admin options
![The_BCMS_-_Chapter_processed_books_and_collections_domain_status_Sys_admin_options](/uploads/81d60738d8379f4d2c66c40b4746e09e/The_BCMS_-_Chapter_processed_books_and_collections_domain_status_Sys_admin_options.jpg)
### Wholebooks domain status default
![The_BCMS_-_Wholebooks_domain_status_default](/uploads/7f50d33529cabfff21338270e96ece13/The_BCMS_-_Wholebooks_domain_status_default.jpg)
### Wholebooks domain status non-System admin options
![The_BCMS_-_Wholebooks_domain_status_non-Sys_admin_options](/uploads/07fb3a18d2097304d8f777edad3cea46/The_BCMS_-_Wholebooks_domain_status_non-Sys_admin_options.jpg)
### Wholebooks domain status System admin options
![The_BCMS_-_Wholebooks_domain_status_Sys_admin_options](/uploads/68231336a9d9b10f030fcba2e1662be8/The_BCMS_-_Wholebooks_domain_status_Sys_admin_options.jpg)
## Implementation (if applicable)
<!-- A description of the steps to implement the feature.-->
## Alternative approaches (if applicable)
<!-- Include any alternatives to meet this use case. -->
## Acceptance Criteria
- [ ] In settings, Editors, Org Admin, System Admin can "Archive" content no longer current by indicating it has Expired and it is an Archive version, AND if these are selected
- [ ] The book on NCBI websites will appear with an Archive banner and Indication at the top of the page that it is no longer current, like this: https://www.ncbi.nlm.nih.gov/books/NBK33514/
- [ ] In settings, System Admin can "Withdraw" content that should have the full text no longer display by indicating it has been Withdrawn, AND if these are selected
- [ ] The book on NCBI websites will have a Withdrawn notice along with its metadata and no full text will appear
- [ ] Tool tips will be provided for each of the settings above clearly indicating what that setting will do
## Scheduling
<!-- Delete the irrelevant options -->
Schedule this feature to be scoped and designed for Epic:
- [1.0 Priority: Deploy MVP](https://gitlab.coko.foundation/groups/ncbi/-/epics/56)
<!-- Assignee and labels are added automatically. After creating this issue you can link other related or blocking issues with the Gitlab's Linked issues functionality. -->
P06: MVP Data Model and Integrity Issues to Ensure Data Quality in Bookshelf and NLM Databases
https://gitlab.coko.foundation/ncbi/ncbi/-/issues/1391
chapter date and label not passed to TOC for properly display on NCB web pages
2024-01-16T17:36:37Z
Diana jordan
chapter date and label not passed to TOC for properly display on NCB web pages
@lathrops1 @DioneMentis - cc @rorris
## Expected behaviour
Bookshelf can load all chapter-processed TOCs and expect them to display as they currently do with complete metadata.
We should always show the chapter label on the TOC, re...
@lathrops1 @DioneMentis - cc @rorris
## Expected behaviour
Bookshelf can load all chapter-processed TOCs and expect them to display as they currently do with complete metadata.
We should always show the chapter label on the TOC, regardless of the ordering setting applied to the book 2) we should fetch chapter publishing metadata from `<pub-date>`and tag as necessary to render on NCBI web pages (see specifications below)
## Current behaviour
Chapter dates are not tagged in the TOC xml for `<pub-date>` as necessary for rendering on Bookshelf web pages.
Chapter labels are not present in the TOC xml, when the chapter ordering setting applied to the book is not order by: `Chapter Number descending`
## Steps to reproduce
See: https://ncbi.cloud68.co/organizations/d400f251-44e8-44f4-9c27-58d25a09f849/bookmanager/767f2841-7a83-49fd-9f56-5d46127ac2c6
1. go to TOC component
2. see that it is not rendering per Bookshelf live site: https://www.ncbi.nlm.nih.gov/books/NBK425793/
## Environment
[Provide browser name and version and if you're working from a PC or Mac]
## Possible solution
**Chapter Labels**
### Sample content
Final Rendered TOC Example: https://www.ncbi.nlm.nih.gov/books/NBK425793/
Sample converted chapter XML file:
[stat542.xml](/uploads/3acfc4f878f0bcdc8082818a6ef56dc1/stat542.xml)
_Ordering spec_
XML element used to order content and target to write in TOC.XML
Syntax - <label>{string_name} {Arabic number}</label> where {string_name} is case insensitive and can be more than one word in string AND {Arabic number} may or may not be preceded by a # symbol
**Note:** the text or symbols preceding the number should not have to be specified.
Example:
`<label>STATISTICAL BRIEF #542</label>`
Target to write in TOC.XML is complete label in converted XML - see example:
```
<toc-entry>
<label>STATISTICAL BRIEF #541</label>
<title>Any Use and &#x201C;Frequent Use&#x201D; of Opioids among Elderly Adults in 2018&#x2013;2019, by Socioeconomic Characteristics</title>
```
**Pub Date**
There is a PI for epub, but it needs to be written as <?date-epub 20220301?> to display.
Per Martin when investigating, NCBI expects 'date-e/ppub' to render these dates.
## NCBI's priority feedback
Y, for deployment
## QA Steps
[To be completed by Coko once dev is done]
P04: Support valid and compliant TOC XML for all migrated Bookshelf content
https://gitlab.coko.foundation/ncbi/ncbi/-/issues/1407
Processing instructions in Word and PDF chapter processed book metadata
2024-01-16T17:32:24Z
ChristinaTromp
Processing instructions in Word and PDF chapter processed book metadata
# Feature proposal: Processing instructions in Word and PDF chapter processed metadata UI, and written into related components
## Context
There are certain processing instructions that NCBI needs written into book metadata if they are ...
# Feature proposal: Processing instructions in Word and PDF chapter processed metadata UI, and written into related components
## Context
There are certain processing instructions that NCBI needs written into book metadata if they are applied in the metadata UI. These were originally discussed in points 4-7 of #1378.
## Proposal
### UI for Word for System admins
In the metadata UI of Word workflow books, add a new section below the Funding section, editable by System admins only (related permissions have been documented [in row 8 of the chapter processed book manager permissions sheet](https://docs.google.com/spreadsheets/d/1cJeKIUhkkM_kwQ8Fzh9d2Vw9h2IJcgT3_87sWLiNdNQ/edit#gid=16945569)) with the heading 'Processing instructions'. Under that heading make the following processing instructions available as checkboxes (the numbers shown in the list below are not necessary to show in the UI, they are for reference purposes in the issue only, rather use a checkbox in the UI):
1. `<?create-gtr-links?>`
2. `<?pdfbuild-skip-alt-title-as-rhead?>`
3. `<?get-external-navigation-xml related?>`
4. `<?external-xml-source-base /pmcdata/bookshelf/gene/external-xml/ready/?>` and `<?external-xml-source-name .molgene.db.xml?>` (these are two separate processing instructions but since they always occur together, they will be selectable via one checkbox).
### UI for PDF chapter-processed books for System admins
In the metadata UI of PDF chapter-processed books, add a new section below the Funding section, editable by System admins only (related permissions have been documented [in row 8 of the chapter processed book manager permissions sheet](https://docs.google.com/spreadsheets/d/1cJeKIUhkkM_kwQ8Fzh9d2Vw9h2IJcgT3_87sWLiNdNQ/edit#gid=16945569)) with the heading 'Processing instructions'. Under that heading make the following processing instructions available as checkboxes:
- `<?pdfbuild-skip-alt-title-as-rhead?>`
### Back end writing of these Processing instructions:
1. `<?create-gtr-links?>`: when this PI is selected in the metadata UI for Word books, write the PI into all the chapters/components of that book, when loading to PMC (at preview and publish), into the `<book-meta>`.
Example tagging:
```
<book dtd-version="2.0">
<book-meta>
<?create-gtr-links?>
<book-id book-id-type="pmcid">gtrbook</book-id>
<book-title-group>
<book-title>Medical Genetics Summaries</book-title>
</book-title-group>
```
2. `<?pdfbuild-skip-alt-title-as-rhead?>`: when this PI is selected in the UI for Word books, or for PDF chapter processed books, write the PI into all the chapters/components of that book, when loading to PMC (at preview and publish), into the `<book-meta>`:
Example tagging:
```
<book-meta>
<?get-external-navigation-xml related?>
<?pdfbuild-skip-alt-title-as-rhead?>
<book-id book-id-type="pmcid">gene</book-id>
```
3. `<?get-external-navigation-xml related?>`: when this PI is selected in the metadata UI for Word books, write the PI into all the chapters/components of that book, when loading to PMC (at preview and publish), into the `<book-meta>`:
Example tagging:
```
<book-meta>
<?get-external-navigation-xml related?>
<?pdfbuild-skip-alt-title-as-rhead?>
<book-id book-id-type="pmcid">gene</book-id>
```
4. `<?external-xml-source-base /pmcdata/bookshelf/gene/external-xml/ready/?>` & `<?external-xml-source-name .molgene.db.xml?>`: when this PI combination is selected in the metadata UI for Word books, add them both to the book-part-wrapper for every component in the book when loading to PMC (at preview and publish). We should maintain the order of the tagging example below when the PIs are selected in the single checkbox:
`<book-part-wrapper content-type="chapter" id="mdel17q12"><?external-xml-source-base /pmcdata/bookshelf/gene/external-xml/ready/?><?external-xml-source-name .molgene.db.xml?>`
## Implementation (if applicable)
[A description of the steps to implement the feature.]
## Alternative approaches (if applicable)
[Include any alternatives to meet this use case.]
## QA Steps / Acceptance Criteria
1. Create a Word complete doc or a PDF/Word chapter-processed book
2. Fill in the required metadata for the book, and notice that below Funding in the Metadata, there is a new section: Processing instructions.
For books of word workflow, as below:
![image](/uploads/59f8a7d30668877ffa86d5063d31c1df/image.png)
For PDF chapter-processed books, as below:
![image](/uploads/771204e34fc0724e47296667311d7be1/image.png)
3. Check the PIs you need and save the metadata
4. Upload the necessary files and submit book for conversion or upload converted file and click reload preview.
5. After you get the converted file or the book is in Previewing, check the xml file for Processing instructions. They go inside the book-meta, which is within book-part-wrapper.
Example below is from a word complete book, where all the PIs were checked:
```
<book-part-wrapper content-type="toc" id="toc">
<book-meta>
<?create-gtr-links ?>
<?pdfbuild-skip-alt-title-as-rhead ?>
<?get-external-navigation-xml related?>
<?external-xml-source-base /pmcdata/bookshelf/gene/external-xml/ready/?>
<?external-xml-source-name .molgene.db.xml?>
<book-id book-id-type="pmcid">aaevqbhcfq</book-id>
```
6. You can also login as an Org Admin or Editor, and notice that the Processing Instructions are disabled for these users to make changes.
7. When you open up the PDF and Word book created for testing the PIs should still be selected and when send for reload written still into the converted XML.
P03: Support valid and compliant metadata for all migrated Bookshelf content
https://gitlab.coko.foundation/ncbi/ncbi/-/issues/1415
Create PDF setting set to on in PMCA3Bookdb though not turned on in BCMS sett...
2024-01-09T02:07:36Z
Stacy Lathrop
Create PDF setting set to on in PMCA3Bookdb though not turned on in BCMS settings
@ChristinaTromp
cc @ESgitlab
## Expected behaviour
PMCBookdb domain attributes should not change through Domain service unless user intentionally modifies BCMS settings to meet their user need.
## Current behaviour
For some books, ...
@ChristinaTromp
cc @ESgitlab
## Expected behaviour
PMCBookdb domain attributes should not change through Domain service unless user intentionally modifies BCMS settings to meet their user need.
## Current behaviour
For some books, the PMCBookdb domain attributes are changing even though the user did not change BCMS settings (or even can change the settings that became different in PMC databases)
## Steps to reproduce
See loading error here:
https://ncbi.cloud68.co/organizations/4dd138c1-1baa-437b-8a0e-d25b91319687/bookmanager/821733d2-6057-425e-bc8f-955457f6c36c/part/3d8a2f3d-2994-47a7-a6a5-2f16c36e664a/8b108d9d-0bea-406c-88d0-5cf96f220eef
Error is because the Create PDF setting was turned on via PMC Domain service: see:
![image](/uploads/cda49ccc4fc116e6a6eb8aaf6c2ad1a3/image.png)
This should not happen because user can't even make that change in BCMS settings, and there is a display PDF provided for the chapter, so no PDF should be created.
## Environment
[Provide browser name and version and if you're working from a PC or Mac]
## Possible solution
[Not required. Suggest a fix for the bug]
## NCBI's priority feedback
Y, for deployment because it breaks processing and correct displays
## QA Steps
[To be completed by Coko once dev is done]
P06: MVP Data Model and Integrity Issues to Ensure Data Quality in Bookshelf and NLM Databases
https://gitlab.coko.foundation/ncbi/ncbi/-/issues/1418
TOCs do not get sent by overnight chron job
2024-01-02T17:29:47Z
Stacy Lathrop
TOCs do not get sent by overnight chron job
## Expected behaviour
Chapter-processed and collection TOCs should be sent overnight to be published.
## Current behaviour
TOCs are not getting sent to NCBI overnight by chron job to be published with a preview link.
## Steps to rep...
## Expected behaviour
Chapter-processed and collection TOCs should be sent overnight to be published.
## Current behaviour
TOCs are not getting sent to NCBI overnight by chron job to be published with a preview link.
## Steps to reproduce
1. Go to: https://ncbi.cloud68.co/organizations/6804540d-8ecd-419a-a34d-6513718abf76/bookmanager/a3b75cd9-2f22-4011-b123-a777325b91c3
2. Publish chapters in a state you can publish
3. Next morning check for a published preview
Note, I checked the PMC TM and a job was never sent as a chron job. I cannot find any job in the PMC DTS for a failed TOC with errors. Did the BCMS generate this before sending the chron job?
## NCBI's priority feedback
Y, for deployment
## QA Steps
[To be completed by Coko once dev is done]
P09: Book Manager and other MVP BCMS improvements and Lower Priority Bug Fixes
https://gitlab.coko.foundation/ncbi/ncbi/-/issues/1420
Allow "Book submit ID" to be editable by a system admin
2024-01-09T02:06:25Z
ChristinaTromp
Allow "Book submit ID" to be editable by a system admin
## Context
Context is provided in #1151. This field is only present in some workflows and is not editable. Book submit ID needs to be editable, so that versions can be matched to each other by this Book submit ID, for which the Vendors ...
## Context
Context is provided in #1151. This field is only present in some workflows and is not editable. Book submit ID needs to be editable, so that versions can be matched to each other by this Book submit ID, for which the Vendors and Sys admins will use the DOI.
## Proposal
Allow "Book submit ID" in the Metadata UI to be editable by a system admin. Relevant cases:
- XML wholebook book metadata
- XML chapter-processed-book book metadata
- PDF wholebook book metadata
- PDF chapter-processed-book book metadata
## Design
![image](/uploads/d5ee240d44bb97b371f871609469c05a/image.png)
## Implementation
## Acceptance Criteria
- [ ] System Admin can manually edit the "Book submit ID" in XML wholebook Metadata UI to be a DOI
- [ ] System Admin can manually edit the "Book submit ID" in the XML chapter-processed Metadata UI to be a DOI
- [ ] System Admin can manually edit the "Book submit ID" in PDF wholebook Metadata UI to be a DOI
- [ ] System Admin can manually edit the "Book submit ID" in the PDF chapter-processed Metadata UI to be a DOI
P06: MVP Data Model and Integrity Issues to Ensure Data Quality in Bookshelf and NLM Databases
https://gitlab.coko.foundation/ncbi/ncbi/-/issues/1422
Chapter processed books: Error on upload of converted file because of affilia...
2024-01-16T17:32:34Z
Sidorela Uku
Chapter processed books: Error on upload of converted file because of affiliation tags
## Expected behavior
If the conversion of a file is successful, we should be able to upload the same converted file without issues again, from 'File upload' button of converted section.
## Current behavior
When I try to upload some co...
## Expected behavior
If the conversion of a file is successful, we should be able to upload the same converted file without issues again, from 'File upload' button of converted section.
## Current behavior
When I try to upload some converted files which have contributors and aff in their meta, I get an error `The converted file is not correct1` on UI. While is exactly the same file that came from a successful conversion [here](https://ncbidev.cloud68.co/organizations/73814fa2-d9fc-44f8-a12a-d3e52c589230/bookmanager/7ee8f0ec-0702-4282-8941-902f782cf01b/44c0f58b-39bb-47f4-97d0-b96958925b21#b48bab98-9995-46ea-a340-23249ff11cdc)
Also if you check the first converted xml file there are data about contributors which are missing on the ui at the metadata tab of the book component. (this is another bug, but the issues seem related)
## Steps to reproduce
[Provide a link to a live example or screenshots, and the steps to reproduce this bug]
1. Create a chapter processed book
2. Upload the source file: [ch-a.docx](/uploads/36b2227704f7c39bdeb88914d00deb6e/ch-a.docx)
3. Go to files tab and upload the converted file: [ch-a.xml](/uploads/d4f540e46e7593d627b871c420a32b41/ch-a.xml)
4. Click Save and the UI error will appear.
## Environment
[Provide browser name and version and if you're working from a PC or Mac]
## Possible solution
[Not required. Suggest a fix for the bug]
## NCBI's priority feedback
[Select "Y" or "N" and provide an explanation]
1. This bug is blocking NCBI's work on migration planning for deployment 1 (Y)
2. This can be prioritised after deployment 1 (N)
## QA Steps
[To be completed by Coko once dev is done]
P03: Support valid and compliant metadata for all migrated Bookshelf content
https://gitlab.coko.foundation/ncbi/ncbi/-/issues/1426
Unable to submit new source files when component was last in published status
2024-01-08T23:04:15Z
Stacy Lathrop
Unable to submit new source files when component was last in published status
## Expected behaviour
Can submit all new source files
## Current behaviour
Unable to submit new source files when component was last in published status
## Steps to reproduce
1. Go to: https://ncbi.cloud68.co/organizations/aa8b10ab...
## Expected behaviour
Can submit all new source files
## Current behaviour
Unable to submit new source files when component was last in published status
## Steps to reproduce
1. Go to: https://ncbi.cloud68.co/organizations/aa8b10ab-a0ea-41f2-897a-1cae9a632296/bookmanager/3aeb8245-78c3-49e2-a5a0-198028287932
2. See I just uploaded a new source XML file and provided the tag
3. See I cannot press submit to reconvert it
![image](/uploads/96b4696e293d24a0ffbe6ca4f73ccf36/image.png)
## NCBI's priority feedback
Y, for MVP because blocks processing
## QA Steps
[To be completed by Coko once dev is done]
P05: Address MVP Files Management and Processing Issues to support all current Bookshelf submitters and NCBI Integration specifications
https://gitlab.coko.foundation/ncbi/ncbi/-/issues/1438
Books with automatic publishing, crash the site if there are loading errors
2024-01-08T23:47:57Z
Sidorela Uku
Books with automatic publishing, crash the site if there are loading errors
NCBI has the option to allow automatic publishing, without approval from admin or editor. Which means if the conversion is successful the book goes automatically from Previewing to Publishing.
## Expected behavior
For book settings w...
NCBI has the option to allow automatic publishing, without approval from admin or editor. Which means if the conversion is successful the book goes automatically from Previewing to Publishing.
## Expected behavior
For book settings where the 'Require approval before publishing' toggle is turned off. This setting can be turned off for XML Wholebooks, PDF Wholebooks and Word Complete Doc.
If the conversion is successful book goes from Loading preview -> Previewing -> Publishing
If the conversion is not successful it should go Loading preview -> Loading errors
## Current behavior
When Clicked 'Reload preview' on a PDF wholebook (or XML Wholebook or Word Complete Book) which has errors, when the process for loading preview is finished the site crashes. When the app is restarted the status of the book is updated to 'Loading errors'.
## Steps to reproduce
Example book where site will crash if clicked reload preview button: https://ncbidev.cloud68.co/organizations/e56a6d10-ed49-4a0d-aafa-fb9ecee8b0e3/bookmanager/eca869a0-f35a-49e4-8350-fb4ce7647985
1. Create a PDF Wholebook (or XML, Word One Doc case as the bug is the same)
2. On the second step turn off the toggle for 'Require approval before publishing', If you forget here, you can still change it at the settings tab of the book.
3. Upload the converted file as in the example book above
4. Click reload preview
5. What for the loading to finish and in about 10 minutes the site will crash.
## Environment
All browsers on ncbidev staging site.
## Possible solution
<!-- If known, provide details on how to fix the bug.-->
<!-- After creating this issue you can link other related or blocking issues with the Gitlab's Linked issues functionality. -->
## QA Steps
[To be completed by Coko once dev is done]
## Scheduling
<!-- Select all the relevant options -->
- [ ] This issue is blocking current user testing
- [ ] This issue is blocking current migration testing
- [ ] Fixing this issue is required for [Priority 1: Deploy MVP](https://gitlab.coko.foundation/groups/ncbi/-/epics/56)
- [ ] This issue should be triaged into later epics in the PM weekly meeting
P05: Address MVP Files Management and Processing Issues to support all current Bookshelf submitters and NCBI Integration specifications