App crashes when I upload in Converted the same file as in Source (XML wf)
[Provide a general summary of the issue in the title above]
Expected behaviour
[Tell us what should happen. Link to the developed feature issue that describles the expected behaviour if possible]
Current behaviour
In a wholebook XML workflow, when I upload in the 'Converted' section the same file as in 'Source' section, the app crashes with the following message:
2022-06-21T12:05:00.029Z - error: uncaughtException: Cannot read properties of null (reading 'includes')
server_1 | {
server_1 | date: 'Tue Jun 21 2022 12:05:00 GMT+0000 (Coordinated Universal Time)',
server_1 | process: {
server_1 | pid: 60,
server_1 | uid: 1000,
server_1 | gid: 1000,
server_1 | cwd: '/home/node/app',
server_1 | execPath: '/usr/local/bin/node',
server_1 | version: 'v16.14.2',
server_1 | argv: [ '/usr/local/bin/node', '/home/node/app/startServer.js' ],
server_1 | memoryUsage: {
server_1 | rss: 163700736,
server_1 | heapTotal: 109158400,
server_1 | heapUsed: 82637600,
server_1 | external: 1760275,
server_1 | arrayBuffers: 846951
server_1 | }
server_1 | },
server_1 | os: { loadavg: [ 0.63, 0.44, 0.38 ], uptime: 4603.7 },
server_1 | trace: [
server_1 | {
server_1 | column: 18,
server_1 | file: '/home/node/app/server/services/xmlBaseModel/bookPartWrapper.js',
server_1 | function: 'BookPartWrapper.hideInTOC',
server_1 | line: 70,
server_1 | method: 'hideInTOC',
server_1 | native: false
server_1 | },
server_1 | {
server_1 | column: 31,
server_1 | file: '/home/node/app/server/services/xmlBaseModel/xmlBase.js',
server_1 | function: null,
server_1 | line: 84,
server_1 | method: null,
server_1 | native: false
server_1 | },
server_1 | {
server_1 | column: null,
server_1 | file: null,
server_1 | function: 'Array.forEach',
server_1 | line: null,
server_1 | method: 'forEach',
server_1 | native: false
server_1 | },
server_1 | {
server_1 | column: 17,
server_1 | file: '/home/node/app/server/services/xmlBaseModel/xmlBase.js',
server_1 | function: 'BookPartWrapper.loadFromSchema',
server_1 | line: 64,
server_1 | method: 'loadFromSchema',
server_1 | native: false
server_1 | },
server_1 | {
server_1 | column: 12,
server_1 | file: '/home/node/app/server/services/xmlBaseModel/xmlBase.js',
server_1 | function: 'BookPartWrapper.parseXml',
server_1 | line: 50,
server_1 | method: 'parseXml',
server_1 | native: false
server_1 | },
server_1 | {
server_1 | column: 17,
server_1 | file: '/home/node/app/server/services/xmlBaseModel/xmlBase.js',
server_1 | function: 'new XmlBase',
server_1 | line: 13,
server_1 | method: null,
server_1 | native: false
server_1 | },
server_1 | {
server_1 | column: 1,
server_1 | file: '/home/node/app/server/services/xmlBaseModel/bookPartWrapper.js',
server_1 | function: 'new BookPartWrapper',
server_1 | line: 6,
server_1 | method: null,
server_1 | native: false
server_1 | },
server_1 | {
server_1 | column: 22,
server_1 | file: '/home/node/app/server/services/events/listeners/parseUploadedFile.js',
server_1 | function: 'ParseUploadedFile.handle',
server_1 | line: 41,
server_1 | method: 'handle',
server_1 | native: false
server_1 | },
server_1 | {
server_1 | column: 5,
server_1 | file: 'node:internal/process/task_queues',
server_1 | function: 'processTicksAndRejections',
server_1 | line: 96,
server_1 | method: null,
server_1 | native: false
server_1 | }
server_1 | ],
server_1 | stack: [
server_1 | "TypeError: Cannot read properties of null (reading 'includes')",
server_1 | ' at BookPartWrapper.hideInTOC (/home/node/app/server/services/xmlBaseModel/bookPartWrapper.js:70:18)',
server_1 | ' at /home/node/app/server/services/xmlBaseModel/xmlBase.js:84:31',
server_1 | ' at Array.forEach (<anonymous>)',
server_1 | ' at BookPartWrapper.loadFromSchema (/home/node/app/server/services/xmlBaseModel/xmlBase.js:64:17)',
server_1 | ' at BookPartWrapper.parseXml (/home/node/app/server/services/xmlBaseModel/xmlBase.js:50:12)',
server_1 | ' at new XmlBase (/home/node/app/server/services/xmlBaseModel/xmlBase.js:13:17)',
server_1 | ' at new BookPartWrapper (/home/node/app/server/services/xmlBaseModel/bookPartWrapper.js:6:1)',
server_1 | ' at ParseUploadedFile.handle (/home/node/app/server/services/events/listeners/parseUploadedFile.js:41:22)',
server_1 | ' at processTicksAndRejections (node:internal/process/task_queues:96:5)'
server_1 | ]
server_1 | }
server_1 | [nodemon] app crashed - waiting for file changes before starting...Steps to reproduce
[Provide a link to a live example or screenshots, and the steps to reproduce this bug]
- Create a new wholebook of XML workflow
- Upload a file in the Source section, such as ukhta2501.xml
- Upload in the Converted section, the same file.
- Notice that you get a blank page and the app crashed
Environment
Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:101.0) Gecko/20100101 Firefox/101.0
Possible solution
[Not required. Suggest a fix for the bug]
NCBI's priority feedback
[Select "Y" or "N" and provide an explanation]
- This bug is blocking NCBI's work on migration planning for deployment 1 (Y/N)
- This can be prioritised after deployment 1 (Y/N)
QA Steps
[To be completed by Coko once dev is done]