QA feedback for prioritisation
Relates to #150 (closed), #169 (closed), #190 (closed), #230 (closed) and general test of latest staging site update.
@John.kopanas, @yannis, @danjela, @dmerizaj, @sidorelauku -- I have listed all feedback here. On Monday we need to prioritise the fixes for NCBI's next review (which will be followed by user testing by a small group of their Word WF users).
I've put *** next to the ones I think are a priority.
Accepting users and assigning roles
-
Organization roles should display in pending user modal (heading and toggles) *** -
Organization roles should display in accepted user modal (heading and toggles) *** -
Organization membership should not display in pending user modal (heading and toggle) ***
Creating new books
-
New: The metadata fields that are required for Word conversion must be added to the New Book modal: ID; Publisher; Publisher location; Date of Publication. (Otherwise it is too easy for users to upload files for conversion before the required metadata is provided). *** -
Bug: In the New Book modal I cannot select the second option 'Chapter title and main headings' for the TOC display headings setting. ***
Adding team to book and book component
-
Bug: When users are added the book team modal, they don't display in the table unless you refresh *** -
If we remove users from the team modal, they still display on the list of users in the 'Manage team' tab and continue to have a role in the book chapter -
The team listed on the Manage team tab disappears on previous versions when I create a new book component version. Example: - my current version is V2.
- I have added a team to the component V2.
- I create a new version V3 (
✅ ) - my team from V2 is copied to version 3 (
✅ ) - my team on V2 is blank (
❌ )
(I don't think this should be worked on until we get NCBI feedback from #181 (closed))
Uploading files and creating versions
-
Bug: On the book manager, the book component version number should update as soon as a source file has been uploaded. At the moment, it only updates at some point durning the 'converting' status -- this is confusing becuase it's not clear that the latest file version is converting. *** -
Bug: On the book component Files tab: when I upload a new file version it does not display in the files table even after refreshing. Eventually the file does show in the table (assuming after it has been converted). Also, as soon as an individual file has been uploaded, the version number should update on the book manager page. *** -
Supplementary files: bugs with version numbers displaying incorrectly when deleting files (see screen recordings in #192 (closed)) ***
Creating and previewing the TOC in book manager
-
After conversion all the chapters are uploaded in the body section, and from the files I tried to upload only a few of them had the conversion without error, and all where book components supposed to be at font/back matter which converted successfully. (Waiting on feedback in #231 (closed)) -
Another thing about the dragging is that sometimes, when trying to move a part of chapter by dragging that part/chapter might disappear, unless I refresh the page and see it still there. @sidorelauku can you provide a screen recording for this. *** -
Dragging parts it's difficult from the user experience. All the features related to reordering and moving parts or chapters work, but with the drag icon is not smooth and easy to do thing. @sidorelauku do you mean that dragging the whole row is not easy? (see my 'discuss' comment below). *** -
Discuss on Monday: The drag and drop icon in the book manager is not active, instead the whole row is draggable. I think we should use the icon as in the design because that will be clearer to users to understand when chapters can be moved or not. For example, if chapters are ordered automatically in the body section the icon will not display; if the chapters are ordered manually the icon will display. Whereas book components in the front and body can always be dragged and dropped so should always display the icon. This also means that clicking anywhere on the row will open the chapter (instead of clicking only on the chapter title) which is what we do on all other pages. *** -
Bug: When I select chapters and the 'Move to' button the modal opens and moving the chapters functions properly, but I cannot see the full modal unless I zoom out my browser to 70%. *** -
Bug: When I select 'Preview TOC' I should see the all book components with the status 'Ready to publish' and 'Published'. At the moment no TOC displays. (Also the 'download' link doesn't work.) *** -
The toc.xml file is not being sent at Load to PMC step (See #73 (closed) here)
When status = converting
-
Disable moving book components to sections (front/body/back) because system will know where to place book components when conversion completes -
On bulk upload: Block uploads of new file version. In the same way we currently display errors in file naming, show error message 'Duplicate upload. File is currently converting.'
Users can open book component row in book manager, but certain actions are limited:
-
On Preview tab 'ready to publish and 'publish' is disabled. Message on preview tab = 'Preview will display when file converts successfully' *** -
On metadata tab: Disable editing of fields that originate from source (list of fields TBC) -
On files tab: Disable book component file uploads. ***
Errors workflow
-
Some book components remain in the status 'converting' even after many hours. Could the problem be that the file has errors but the wrong status is reported? See examples in this book. ***
* [ ] The book component status *** (Done, waiting to be merged in !165 (merged) )Error
should be Errors
-
When a book component has the status 'Errors', the bottom toolbar on the Preview tab is missing (e.g. here). Instead I should see the tab as usual and this text "No preview available. Resolve errors to generate the preview." *** -
On the Error tab: the 'show history' button does nothing. I should see the error report from the previous file versions.
* [ ] Should 'Category' be filled with information, or is it optional? (Error categories will not display yet. This is dependent on the development in #165 (closed).)
-
When the status is Errors, the Book manager UI should include the error detail (Submitter or Bookshelf) as shown here -
On the Errors tab, when there are no errors reported the text 'No errors available' is not visible. -
On the book component Errors tab: the text 'NCBI Bookshelf Author Guide' should link to https://preview.ncbi.nlm.nih.gov/books/NBK310885/. Also, Include the following text below this sentence: *** Error Severity
- Error: must be fixed to successfully process submissions.
- Warning: should be reviewed for potential tagging issues.
- Query: should be addressed to ensure quality assurance.
-
The 'Show help' panel should show a history when the file/files were uploaded as shown here. Here's an example component
Previewing workflow
-
Feedback panel comments do not display, as I commented for @danjela in issue #150 (closed) -
When conversion is successful, or at least shows the status previewing
, clicking on that chapter is not always possible to see a preview. Error:We can’t connect to the server at ipmc-prod.be-md.ncbi.nlm.nih.gov.
. But it is the same chapter which is uploaded in two different books, sometimes preview is visible sometimes not. *** -
The main problem with the Previewing workflow is that the status 'In review' is lost (visually) when a new file is uploaded (because the status changes to 'converting' then 'previewing' or 'errors'). (See new issue #242 (closed)) *** -
When I sign in as an Editor, I cannot request a review. *** -
When a new file is uploaded it doesn't show in the feedback panel chat, that a new preview was generated or not, as shown in design here. Here's an example book component. -
When the status is In review, the Book manager UI should include the error review detail (the numbers how many Previewers have approved or revised) as shown in design here. -
right now the messages on the feedback panel are not delivered. It displays on the chat: An error happened during sending your message
-
Ready to publish and publish can be clicked even if the status is not approved, but this is related to the ready to publish modal which is not done yet. (requires dev in #239 (closed)) *** -
If the book component is in the status 'ready to publish' and the editor request review, the status of the book does not change back to 'In review'. ***
Double check feedback
@sidorelauku I didn't have these issues, can you double check please.
-
If a previewer logs in to check the feedback panel it shows a blank page. -
Also if the user (not admin) click the feedback panel it ends up in a blank page. -
Also when I request review is not reflected on the feedback panel. (not sure what you mean here. You should see the text "Review Requested" icon next to the user's comment, as in this example.
Publishing workflow
* [ ] When I'm signed in as an author or previewer I can make a chapter 'ready to publish' and I can publish a chapter (but the status remains 'ready to publish'). Authors and Previewers shouldn't be able to see these buttons at all. (I'm not sure if this part of permissions work is done yet @yannis?) (Permissions not merged)
-
Bug: When the book component has status 'Ready to publish' - the file status does not update (it should be the same.) *** -
When a book has the setting 'Support multiple published versions' turned ON, the user should be able to upload a new file version for all book component versions that have status 'Published' (because there needs to be a way to correct text (e.g. a typo) in any published version). (Dione to give example first) -
The last published date on the Book manager page disappears when a new book component version is created. This column should always display the last time the component was published. Add the version number too, e.g. Last Published: 11/07/2020 5:54 PM (V1.5) *** -
When the book component status is 'New version' (after selecting 'new version' button on individual book component) the Preview tab is missing the bottom bar. Instead I should see the tab as usual with the text "Upload a file to generate a preview.". The buttons 'ready to publish' and 'publish' should be inactive for all users in this state. ***
Other functionality not working
-
Back button doesn't work when going from book component page to book manager page -
Log-in as another user, not admin. In those case the menu toolbar disappears and not possible to see which user is logged in or how to logout. -
On the files tab, clicking on a file name (source or converted) leads to a blank page (e.g. http://localhost:3000/downloadFileVersion?id=87e321ce-485f-4364-9697-7bc66f786f49&category=source
) *** -
Clicking on manage team tab sometimes goes to blank page (e.g. http://ncbi-staging.coko.foundation/bookmanager/41be2dd1-95b3-4420-b5f4-c2eea8368787/b497643f-152b-48b4-862b-59cb7d2f588e#teams
) *** -
On the Preview and Errors tab, Should I get an error message when I @mention roles but no users with those roles are associated to the book component? -
Uploading a book cover works, but when I open the Book Metadata modal again the cover image doesn't display. (the cover image also doesn't display in the generated preview.) See example book metadata -
The bottom of the book component metadata tab is cut off, so I can't see the final Author or Editor in the list (Don't fix until design for full metadata is complete) -
Recurring connection error on staging site login page: net:: ERR_CONNECTION_REFUSED
in console ***
design missing / inconsistent / typos
-
On the file tab, the size of the button 'rename' is incorrect. -
In the top nav bar, the Admin button is not the same style as the other buttons. -
Generally, the alignment of symbols in icons needs improvement (e.g. ON/OFF toggles, error status icon) -
NB fix: The version paginator on the book component page should have arrows as in the design (not the 'previous' and 'next' buttons used in the Dashboard paginator in the bottom bar). No arrows should display unless there is another version to go to. *** -
On the book component page, the navigation button 'previous' and 'next' are missing. (To go to the previous or next book component.) *** -
The file name is missing from the book component page (under the title as in the design) See #157 (closed) -
On the book component page, long chapter titles fall outside the grey bar See #156 (closed) -
The icon for New version status should have an 'N' not a 'P' -
The 'Show history' button on the Errors tab is missing its border. -
On the Preview tab: there is a typo in the error message "Can't request review" "Can`t" should be Can't". -
Organization type should be 'Funder' not 'Founder' ***