Coko team templates branch review
@John.kopanas @danjela @andynicholson @sidorelauku
Here are the known fixes for @yannis's templates MR !559 (merged). I'm ticking off the ones that should be fixed, but I have not tested myself. Please go ahead with your check and add anything else you find to this list.
Book templates tab
-
Chapter-processed template: 'order chapters by' these options should be hidden: Date created, Date updated. -
Add the pop up success (green box) or error (red box) messages like we use when a domain is created, so the user knows if the template has been created or updated. -
The value for "Publisher URL" is not saved when the template is created or updated. -
Change domain name creation rule to for the templates to templ_pubisherID_whole
ortempl_pubisherID_chapter
New collection modal (and result in dashboard)
-
The styling tools for the 'Title' field are shown on top of the options for 'Collection type', making it difficult to select an option. (correct on ndbidev
) -
After creation, the text 'New collection' is missing from the status column. (This was done in MR !541 (merged)). -
Hide the setting 'Require approval before publishing: Previewers' because that won't be possible in the initial release. (This is already hidden in new book and book settings).
New book (and result in dashboard)
-
When I create a chapter-processed book (any) the values I set in my template for "Group chapters into parts" and "order chapters by" where not applied (I think the BCMS-only settings are not being applied from the template?) -
Same for when I create a new Word WF book: the value I set in my template for "Citation style" is not not applied. -
We can't make "Citation style" required in the template because it doesn't apply to all chapter-processed books, so it must be required when creating a Word WF book. Update this comment is incorrect since Citation style is not a domain setting. We have set a default in the template that can be changed by NCBI after testing if necessary. -
In the first step the alerts related with domain name (ex. Requested domain 'bcmsX' already exists
) do not display anymore.
Book settings
-
When a value for 'Display heading levels' isn't selected in the template, this shows as 99
in book settings -- this happens because it seems to be the default value fortoc-max-depth
in the domainclonechapterprocess
. NCBI to provide the default value we should set. opened ticket for NCBI in #748 (closed) -
For wholebooks and PDF/XML chapter-processed books that are not 'AuthorManuscript', we need to show the section "Landing page: Downloads" with below settings is missing: - Display book-level PDF for download
- Display chapter-level PDFs for download
-
Sometimes there is a bug with 'Display heading levels' setting at template point and Book creation step 2 where it shown a random number. That happened for this book: http://195.201.125.129:9001/organizations/851d4c6b-8981-4094-977a-b145fe4865a6/createBook (see screenshot). Note: the user can't save until the value is corrected to 3 or below so this bug isn't blocking any testing. Ping Yannis if you reproduce this
Bugs
-
For Word WF books "the Require approval before publishing: Org Admin or Editor" is correct in the UI (true and disabled) -- but this should result in the "publish" button displaying. The button is missing so the chapters get published automatically (i.e. without approval) -
I cannot update the settings at step 2 for a newly created book #736 (closed) -
Word workflow issue when we send the file for conversion (Citation number is needed)#741 (closed) -
"Book Template" multiple published versions settings is off by default and the default in the book creation step 2 is on by default -
In addition to bug 5, there are some other settings which are off by default but when you create a new book you see those settings on:
Note: If you create a new org, and go to templates (chapter-processed in this case) and change only one thing (TOC: order chapters by) and save this as a template. After save of custom tempalates, many checkboxes will be checked and some options by default will be add to the select elements even though none of those were chosen by default. Same for the wholebook tempalates. And this might be related with the last 2 bugs.