ncbi merge requestshttps://gitlab.coko.foundation/ncbi/ncbi/-/merge_requests2022-08-16T09:26:39Zhttps://gitlab.coko.foundation/ncbi/ncbi/-/merge_requests/864Draft: feat: extend ConversionError for saving file name errors2022-08-16T09:26:39ZPokhiDraft: feat: extend ConversionError for saving file name errorsTargets: #804
**Summary**
1. Extended how errors are saved by `ConversionError`Targets: #804
**Summary**
1. Extended how errors are saved by `ConversionError`Giannis Kopanasjkopanas@gmail.comGiannis Kopanasjkopanas@gmail.comhttps://gitlab.coko.foundation/ncbi/ncbi/-/merge_requests/993Draft: fixes on ui on chat2022-09-20T18:37:50ZDanjela Shehidanjelashehi@gmail.comDraft: fixes on ui on chat#1286
- [x] FIX: When I upload a files on XML/PDF wholebook & Word One Doc, at the review panel chat. Going to the files tab, you need to refresh to see it on the review section.
- [ ] FIX: for Word One Doc when status is 'New Book',...#1286
- [x] FIX: When I upload a files on XML/PDF wholebook & Word One Doc, at the review panel chat. Going to the files tab, you need to refresh to see it on the review section.
- [ ] FIX: for Word One Doc when status is 'New Book', it has that error showing feedback chat of preview tab and on errors help chat. However the message we sent does show up if we refresh or move from one tab to another.Giannis Kopanasjkopanas@gmail.comPokhiRudresh Shrotriyarudresh@coloredcow.inGiannis Kopanasjkopanas@gmail.comhttps://gitlab.coko.foundation/ncbi/ncbi/-/merge_requests/1031Include only last published file when toc is published2022-11-01T09:50:47ZPokhiInclude only last published file when toc is publishedTargets: #1149
**Changes proposed**
- [x] Create a new table `published_file_versions`
- [x] When a chapter (book_component) status changes to `published`, insert a row into the table containing the details of the book metadata and bo...Targets: #1149
**Changes proposed**
- [x] Create a new table `published_file_versions`
- [x] When a chapter (book_component) status changes to `published`, insert a row into the table containing the details of the book metadata and book component metadata
- [x] When building book TOC, read metadata of the latest published file of each chapter that was once published
---
**Flow of updating published version of book TOC**
1. When the `Update published version` button is clicked, the `publishToc` resolver is called.
1. The `publishToc` resolver executes command `publishComponent` for the toc
https://gitlab.coko.foundation/ncbi/ncbi/-/blob/718676e9fefa910465dfd584a2cf77077d1b3df2/server/api/graphql/toc/toc.resolvers.js#L26
1. When the toc `publishComponent` command is running, at one point the domain update command is executed
https://gitlab.coko.foundation/ncbi/ncbi/-/blob/718676e9fefa910465dfd584a2cf77077d1b3df2/server/services/CommandService/tocCommands/commands/publishComponent.js#L138
1. After the book has been successfully update, the `BookUpdated` event is fired
https://gitlab.coko.foundation/ncbi/ncbi/-/blob/718676e9fefa910465dfd584a2cf77077d1b3df2/server/services/CommandService/domainCommands/commands/updateCommand.js#L135
1. The `CreateTocXml` listener is mapped to `BookUpdated` event and hence it get called.
https://gitlab.coko.foundation/ncbi/ncbi/-/blob/718676e9fefa910465dfd584a2cf77077d1b3df2/config/default.js#L68
----
Consider a book with the following chapters and converted files:
1. Chapter 1 v1 - F1 (published)
1. Chapter 2 v1 - F1 (published), F2 (new-upload)
1. Chapter 1 v2 - F1 (published), F2 (previewing)
If the book's TOC is now published, it should include the following chapters with files:
1. Chapter 1 - v2 - F1
1. Chapter 2 - v1 - F1PokhiGiannis Kopanasjkopanas@gmail.comPokhihttps://gitlab.coko.foundation/ncbi/ncbi/-/merge_requests/1054Fix collection TOC2022-09-19T06:47:11ZShubham TiwariFix collection TOC## Targeted Issue: #1382
## Summary:## Targeted Issue: #1382
## Summary:Shubham TiwariShubham Tiwarihttps://gitlab.coko.foundation/ncbi/ncbi/-/merge_requests/1065Update create book submission flow2022-09-29T13:34:03ZShubham TiwariUpdate create book submission flow## Targeted Issue: #1346
## Summary:
7.1. Remove content type and version number at the book level for chapter-processed books:
- [x] Move the 'Submission type' choice up in the new book step, to sit below the existing 'Collection' ...## Targeted Issue: #1346
## Summary:
7.1. Remove content type and version number at the book level for chapter-processed books:
- [x] Move the 'Submission type' choice up in the new book step, to sit below the existing 'Collection' choice, the options for 'Submission type' are 'Complete books and documents' and 'Individual chapters'.
- [x] Move 'Conversion workflow' choice up, to be below the 'Submission type' choice and above the 'Content type' choice. Restrict 'Conversion workflow' options to what the Organisation creating the book is allowed to create based on the organisation's settings – #1310.
- [x] Only show 'Content type' when 'Submission type' = 'Complete books and documents' and 'Conversion workflow' = PDF or XML.
- [x] When 'Submission type' = 'Complete books and documents' and 'Conversion workflow' = XML, make 'Content type' automatically = 'Final full-text', and that default Content type in this case shouldn't be editable.
- [x] When 'Submission type' = 'Complete books and documents' and 'Conversion workflow' = PDF, make the following 'Content type' options available, in this order: 'Author manuscript', 'Prepublication draft', 'Published PDF', 'Final full-text'.
- [x] Only show version number input when 'Submission type' = 'Complete books and documents' and 'Conversion workflow' ≠ Word ('Conversion workflow' = PDF or XML).Shubham TiwariShubham Tiwarihttps://gitlab.coko.foundation/ncbi/ncbi/-/merge_requests/1067Draft: feat(ui): add groups to contributors2022-10-05T12:50:04ZDanjela Shehidanjelashehi@gmail.comDraft: feat(ui): add groups to contributorsThis MR is a draft for #1372This MR is a draft for #1372https://gitlab.coko.foundation/ncbi/ncbi/-/merge_requests/1073Show Display and Create PDF settings2023-09-28T20:32:39ZShubham TiwariShow Display and Create PDF settings## Targeted Issue: #1165
## Summary:
Some additional changes are required as described in [this comment](https://gitlab.coko.foundation/ncbi/ncbi/-/issues/1165#note_98826).## Targeted Issue: #1165
## Summary:
Some additional changes are required as described in [this comment](https://gitlab.coko.foundation/ncbi/ncbi/-/issues/1165#note_98826).https://gitlab.coko.foundation/ncbi/ncbi/-/merge_requests/1080test(fix): fixed and added tests for 3 types of order in collection2023-08-11T08:46:21ZBela Tocitest(fix): fixed and added tests for 3 types of order in collectionThis MR consists on improvements on Test01 regarding Collection order. More specifically:
- The tests for creating 3 books were merged in a single test and a command that changes the Metadata of books was added
- The test that selects 'O...This MR consists on improvements on Test01 regarding Collection order. More specifically:
- The tests for creating 3 books were merged in a single test and a command that changes the Metadata of books was added
- The test that selects 'Order by Title' for a collection was removed since this type of order is the default
- Added tests that select "Order by volume" and "Order by publication date", and tests that validate the orderings
- Confirm that the red label toc is showing for books missing that value for orderingSidorela UkuSidorela Ukuhttps://gitlab.coko.foundation/ncbi/ncbi/-/merge_requests/1083Fixes related to chapter label and date for toc2022-09-29T12:14:04ZPokhiFixes related to chapter label and date for tocTargets: #1391
**Changes proposed**
1. Chapter label will be included in the `TOC.xml` and will be visible in book toc, irrespective of the Order set in the book setting.
2. If `pub-history` is not present chapter publishing history (...Targets: #1391
**Changes proposed**
1. Chapter label will be included in the `TOC.xml` and will be visible in book toc, irrespective of the Order set in the book setting.
2. If `pub-history` is not present chapter publishing history (created, updated, revised) will be parsed from `pub-date` tag.https://gitlab.coko.foundation/ncbi/ncbi/-/merge_requests/1096Draft: feat(test): enhanced tests cases about roles and permissions2023-08-09T10:26:15ZSidorela UkuDraft: feat(test): enhanced tests cases about roles and permissionsThis MR has test cases for roles and permissions as for issue #1400.
The MR covers partially some of the permissions accesses based on role as for the permissions spreadsheet.This MR has test cases for roles and permissions as for issue #1400.
The MR covers partially some of the permissions accesses based on role as for the permissions spreadsheet.Bela TociSidorela UkuBela Tocihttps://gitlab.coko.foundation/ncbi/ncbi/-/merge_requests/1100Multiple organizations books2023-02-14T08:35:15ZGiannis Kopanasjkopanas@gmail.comMultiple organizations books#1428#1428https://gitlab.coko.foundation/ncbi/ncbi/-/merge_requests/1112Draft: Browser test ci2023-08-10T11:20:07ZSidorela UkuDraft: Browser test cihttps://gitlab.coko.foundation/ncbi/ncbi/-/merge_requests/1204feat(ui): books and collections search enhancement2023-10-02T12:51:20ZDuncan Bennettfeat(ui): books and collections search enhancementUpgrades the book collections search so that it uses the same bcms
search logic that was implemented for the book manager search.
NB: the book collections title search does not use the same logic as the
book manager search because this ...Upgrades the book collections search so that it uses the same bcms
search logic that was implemented for the book manager search.
NB: the book collections title search does not use the same logic as the
book manager search because this requires too many changes.
Related to #1467Giannis Kopanasjkopanas@gmail.comDione Mentisdione@coko.foundationBela TociSidorela UkuYannis BarlasGiannis Kopanasjkopanas@gmail.comhttps://gitlab.coko.foundation/ncbi/ncbi/-/merge_requests/1222refactor(*): use book component id instead of version id2023-11-08T18:01:08ZPokhirefactor(*): use book component id instead of version id#1624
This MR gets rid of `bookComponentVersionId` from the entire application and just use `id` of the bookComponent.#1624
This MR gets rid of `bookComponentVersionId` from the entire application and just use `id` of the bookComponent.Giannis Kopanasjkopanas@gmail.comGiannis Kopanasjkopanas@gmail.comhttps://gitlab.coko.foundation/ncbi/ncbi/-/merge_requests/1228fix(server): resolved order change in existing part on repeat2023-10-04T06:43:57ZRudresh Shrotriyarudresh@coloredcow.infix(server): resolved order change in existing part on repeatResolves: https://gitlab.coko.foundation/ncbi/ncbi/-/merge_requests/1224#note_126124
* added condition to not delete the the component from part if it is in target
* added condition to add a component in the part if it doesn't exist al...Resolves: https://gitlab.coko.foundation/ncbi/ncbi/-/merge_requests/1224#note_126124
* added condition to not delete the the component from part if it is in target
* added condition to add a component in the part if it doesn't exist alreadyRudresh Shrotriyarudresh@coloredcow.inRudresh Shrotriyarudresh@coloredcow.inhttps://gitlab.coko.foundation/ncbi/ncbi/-/merge_requests/1232Added 'publisherportalservice' to runtime-dependencies.yml2024-01-03T22:46:46ZEvgenyAdded 'publisherportalservice' to runtime-dependencies.ymlAdded missing dependency on the NCBI Publisher Portal API. Should not affect Coko, please merge to develop, thanksAdded missing dependency on the NCBI Publisher Portal API. Should not affect Coko, please merge to develop, thanksGiannis Kopanasjkopanas@gmail.comGiannis Kopanasjkopanas@gmail.com