ncbi issueshttps://gitlab.coko.foundation/ncbi/ncbi/-/issues2024-01-31T00:22:58Zhttps://gitlab.coko.foundation/ncbi/ncbi/-/issues/1657Unable to upload Converted xml into a chapter for glycopodv22024-01-31T00:22:58ZKin Man NgUnable to upload Converted xml into a chapter for glycopodv2We are getting an error when trying to upload an Converted XML into the glycopodv2 book.
BCMS link: https://ncbi.cloud68.co/organizations/810011d3-1093-4550-a882-c7cbe0ae33c6/bookmanager/22544eb7-0452-4b48-9675-e9975fe23705/f2ce654d-066...We are getting an error when trying to upload an Converted XML into the glycopodv2 book.
BCMS link: https://ncbi.cloud68.co/organizations/810011d3-1093-4550-a882-c7cbe0ae33c6/bookmanager/22544eb7-0452-4b48-9675-e9975fe23705/f2ce654d-0667-47cf-8041-cb4f45461931#undefined
After a user selects the file to upload and when they click on 'Save', a red pop window appears on the upper right hand corner with the error:
"Error uploading file;
The converted file you uploaded is not correct or parsing failed with error: Running command: Chapter Update Command Failed'
![glycopodv2_coko_upload_converted_error.png](/uploads/93ba7d6aed2385475d0f95dd809cce4e/glycopodv2_coko_upload_converted_error.png)
The converted file would need to be removed.Kin Man NgKin Man Nghttps://gitlab.coko.foundation/ncbi/ncbi/-/issues/1656pub-date not displaying when pub-history isn't present2024-01-26T23:45:29ZKin Man Ngpub-date not displaying when pub-history isn't presentIn the production TOC for ahrqlsr, pub-history date is displayed under the contrib list. For chapters that does not have pub-history tagged, the pub-date is displayed instead.
https://www.ncbi.nlm.nih.gov/books/NBK568855/
![ahrqlsr_pro...In the production TOC for ahrqlsr, pub-history date is displayed under the contrib list. For chapters that does not have pub-history tagged, the pub-date is displayed instead.
https://www.ncbi.nlm.nih.gov/books/NBK568855/
![ahrqlsr_prod_TOC_dates](/uploads/7ecafcccce3be77945357ab3a35b4fe7/ahrqlsr_prod_TOC_dates.PNG)
'**Published:** ' is the pub-history created date
'**Published online**: ' is the pub-date
I loaded the chapter 'Living Systematic Review ... Pain: Surveillance Report 4 ..' into a test book and there is no date.
https://ncbi.cloud68.co/organizations/4387b034-27b8-4bd8-9b86-4ddd34aacd15/bookmanager/3dd24a0c-4130-467f-a8d9-665af2c181fb/toc/354201df-655e-45d3-94df-29f3f23940e8
I checked the TOC.xml (see attached ahrqlsr_coko_pub-date_TOC.xml) and the pub-date is available as an pi `?epub 20220601?.`
[ahrqlsr_coko_pub-date_TOC.xml](/uploads/de6b377b17ccb509a1fb7ea9148d6264/ahrqlsr_coko_pub-date_TOC.xml)
This is tagged as `<pub-date publication-format="electronic" date-type="pub"><month>06</month><year>2022</year></pub-date>` within the book-part-meta of the converted XML.Kin Man NgKin Man Nghttps://gitlab.coko.foundation/ncbi/ncbi/-/issues/1655Upgrade to latest version of coko/client2024-02-07T15:46:18ZDione Mentisdione@coko.foundationUpgrade to latest version of coko/client* Upgrade libraries in app first (to be in line with Coko/client)
* Then upgrade to latest version of coko/client* Upgrade libraries in app first (to be in line with Coko/client)
* Then upgrade to latest version of coko/clientP07 - Support Current Bookshelf Chapter-Processed contents with Parts with Bodyhttps://gitlab.coko.foundation/ncbi/ncbi/-/issues/1654Upgrade to the latest @coko/server2024-02-07T15:42:54ZGiannis Kopanasjkopanas@gmail.comUpgrade to the latest @coko/server<!-- Required. Provide a general summary of the issue in the title above -->
## Context
<!-- Give the necessary context for your proposal. For example, what problem will this feature solve for users? What are the use cases, benefits, ...<!-- Required. Provide a general summary of the issue in the title above -->
## Context
<!-- Give the necessary context for your proposal. For example, what problem will this feature solve for users? What are the use cases, benefits, and goals? -->
Upgrading now is in line with the request in #1628 because we can make use of the fileStorage and AWS s3 Service, making the migration issue to AWS s3 easier.
## Proposal
<!-- A precise statement of the proposed feature. -->
Upgrade to the latest @coko/server. Note: there are breaking changes so we propose refactoring in BCMS step-by-step, alongside feature development, to bring the code closer to coko/server current version, then complete the upgrade.
## Design
<!-- Include sketches or wireframes of the UI suggested for this feature. -->
## Acceptance criteria
<!-- Provide the criteria that should be met for this feature. These criteria must be clearly defined customer requirements aligned to NCBI’s user stories in its Statement of Work. These criteria must be testable by either user testing, unit tests or integration tests.-->
## Definition of ready
<!-- A checklist of what needs to be done to a product backlog item before the team can start implementing it in the next sprint. -->
- [ ] BCMS User Story / Context has been well defined
- [ ] The priority of the user story is specified and agreed
- [ ] Digital assets added (design, database scheme, mockups etc if relevant)
- [ ] Coko Technical Proposal approved by NCBI
- [ ] Testable Acceptance Criteria approved by NCBI
- [ ] Estimate of effort to complete (time or points)
- [ ] The issue has been broken down into development tasks (if necessary)
- [ ] Requirements Clarified
- [ ] The product owner and development team agree that the user story is ready for development
- [ ] NCBI adds “Dev_Ready”
## Definition of done
<!-- A checklist of criteria that must be completed for a story to be considered “done.” -->
- [ ] All coding tasks are finished and implemented
- [ ] QA approved
- [ ] Deployed and tested on “ncbidev” (by Coko team)
- [ ] Deployed and tested on “ncbi” (by NCBI team)
- [ ] Acceptance Criteria Met
## Implementation
<!-- A description of the steps to implement the feature. To be completed by the lead dev. If there are multiple tasks, then break these down into "task" below.-->
## Alternative approaches (if applicable)
<!-- Include any alternatives to meet this use case. -->
## Scheduling
* [ ] Milestone is linked
* [ ] Iteration is linked
* [ ] Dependencies: ("None" or list issue numbers if relevant)
* [ ] Development estimate is added to issue time trackingP05: Address MVP Files Management and Processing Issues to support all current Bookshelf submitters and NCBI Integration specificationshttps://gitlab.coko.foundation/ncbi/ncbi/-/issues/1653Add Loaders to Resolvers2024-02-07T15:45:51ZGiannis Kopanasjkopanas@gmail.comAdd Loaders to Resolvers- Check the loaders we already have
- Add new loaders where is necessary- Check the loaders we already have
- Add new loaders where is necessaryP05: Address MVP Files Management and Processing Issues to support all current Bookshelf submitters and NCBI Integration specificationshttps://gitlab.coko.foundation/ncbi/ncbi/-/issues/1652Migrate all the parsing from Cheerio to SaxParser2024-01-29T09:05:26ZGiannis Kopanasjkopanas@gmail.comMigrate all the parsing from Cheerio to SaxParserAt the moment we have two different ways for parsing the Xml .
Cheerio for the smaller files and SaxParser for xml Files bigger than 10mb.
We need to move to SaxParser.
This can be done in parallel with issues about xml File Parsing .At the moment we have two different ways for parsing the Xml .
Cheerio for the smaller files and SaxParser for xml Files bigger than 10mb.
We need to move to SaxParser.
This can be done in parallel with issues about xml File Parsing .P03: Support valid and compliant metadata for all migrated Bookshelf contenthttps://gitlab.coko.foundation/ncbi/ncbi/-/issues/1651Improve SubmitComponent Controller2024-02-07T15:43:57ZGiannis Kopanasjkopanas@gmail.comImprove SubmitComponent ControllerRefactor / Clean the submit controller.
- Check the possibility to split the controller into two seperate controllers for book and chapters
- Improve the cases for pdf to separate functionality Since we need all the files . (Move that t...Refactor / Clean the submit controller.
- Check the possibility to split the controller into two seperate controllers for book and chapters
- Improve the cases for pdf to separate functionality Since we need all the files . (Move that to the model)
- Move the Creation of Xml files For pdf case. to the XmlFactory Service.P03: Support valid and compliant metadata for all migrated Bookshelf contenthttps://gitlab.coko.foundation/ncbi/ncbi/-/issues/1650Hide all locked versions on all dashboard, collection, book manager, search /...2024-01-16T18:06:04ZStacy LathropHide all locked versions on all dashboard, collection, book manager, search / filter pages from all users except Sys Amins<!-- Required. Provide a general summary of the issue in the title above -->
## Context
<!-- Give the necessary context for your proposal. For example, what problem will this feature solve for users? What are the use cases, benefits, ...<!-- Required. Provide a general summary of the issue in the title above -->
## Context
<!-- Give the necessary context for your proposal. For example, what problem will this feature solve for users? What are the use cases, benefits, and goals? -->
It will likely be confusing after #1465 and #1648 are implemented for non-system admin to see or be able to retrieve from search / filter locked component versions.
## Proposal
<!-- A precise statement of the proposed feature. -->
Hide from all dashboard, collection, book manager, search / filter pages locked book and chapter versions.
## Design
<!-- Include sketches or wireframes of the UI suggested for this feature. -->
## Acceptance criteria
<!-- Provide the criteria that should be met for this feature. These criteria must be clearly defined customer requirements aligned to NCBI’s user stories in its Statement of Work. These criteria must be testable by either user testing, unit tests or integration tests.-->
## Definition of ready
<!-- A checklist of what needs to be done to a product backlog item before the team can start implementing it in the next sprint. -->
- [ ] BCMS User Story / Context has been well defined
- [ ] The priority of the user story is specified and agreed
- [ ] Digital assets added (design, database scheme, mockups etc if relevant)
- [ ] Coko Technical Proposal approved by NCBI
- [ ] Testable Acceptance Criteria approved by NCBI
- [ ] Estimate of effort to complete (time or points)
- [ ] The issue has been broken down into development tasks (if necessary)
- [ ] Requirements Clarified
- [ ] The product owner and development team agree that the user story is ready for development
- [ ] NCBI adds “Dev_Ready”
## Definition of done
<!-- A checklist of criteria that must be completed for a story to be considered “done.” -->
- [ ] All coding tasks are finished and implemented
- [ ] QA approved
- [ ] Deployed and tested on “ncbidev” (by Coko team)
- [ ] Deployed and tested on “ncbi” (by NCBI team)
- [ ] Acceptance Criteria Met
## Implementation
<!-- A description of the steps to implement the feature. To be completed by the lead dev. If there are multiple tasks, then break these down into "task" below.-->
## Alternative approaches (if applicable)
<!-- Include any alternatives to meet this use case. -->
## Scheduling
* [ ] Milestone is linked
* [ ] Iteration is linked
* [ ] Dependencies: ("None" or list issue numbers if relevant)
* [ ] Development estimate is added to issue time tracking
---P09: Book Manager and other MVP BCMS improvements and Lower Priority Bug Fixeshttps://gitlab.coko.foundation/ncbi/ncbi/-/issues/1649Update FTP File Specifications to add `workflow` as a required value to matc...2024-01-09T03:25:29ZStacy LathropUpdate FTP File Specifications to add `workflow` as a required value to match book versionsAfter #1648 the BCMS will need to accommodate a scenario that results in two book versions with the same `book-submit-id` + `version-name` + `version-number`. Therefore the current FTP spec should be updated to add `workflow` as a requir...After #1648 the BCMS will need to accommodate a scenario that results in two book versions with the same `book-submit-id` + `version-name` + `version-number`. Therefore the current FTP spec should be updated to add `workflow` as a required value to match book versions.https://gitlab.coko.foundation/ncbi/ncbi/-/issues/1648Support book versioning to support changes in workflow2024-01-16T17:43:28ZStacy LathropSupport book versioning to support changes in workflow<!-- Required. Provide a general summary of the issue in the title above -->
## Context
<!-- Give the necessary context for your proposal. For example, what problem will this feature solve for users? What are the use cases, benefits, ...<!-- Required. Provide a general summary of the issue in the title above -->
## Context
<!-- Give the necessary context for your proposal. For example, what problem will this feature solve for users? What are the use cases, benefits, and goals? -->
In original NCBI specifications the ability to change workflow type of a book by System Admin was required because this happens frequently in Bookshelf production.
## Proposal
<!-- A precise statement of the proposed feature. -->
Support users to create a new version in order to change the processing workflow. The complication here is that this use case does not constitute a new scientific record (published version) so it would not be correct to change either the `content type` (version name) or `version number`. For example, the following would be valid in this use case:
book version 1:
* conversion workflow: PDF
* content type: final-full-text
* version number: V1
* flag: locked
book version 2:
* conversion workflow: XML
* content type: final-full-text
* version number: V1
* flag: current
#### workflow only change
| Change from | Change to |
|--------------------|--------------------|
| XML | PDF |
| XML | Word |
| PDF | XML |
| PDF | Word |
| Word | XML |
| Word | PDF |
There is no difference in complexity between the possible conversion workflow options, if the processing type remains the same.
#### Minimal workflow for Option 1
1. User publishes OR locks the current book version
2. User chooses to create a new version
3. User chooses the workflow type for the new version
4. BCMS shows confirmation that previous versions will be locked (because of the conversion workflow change)
5. User confirms decision
* new book version is created
* previous version is locked
* user is redirected to the new version
6. User uploads the relevant files to new version (i.e. the BCMS does *not* attempt to match files from the previous version to the current one)
#### Caveats
1. On initial review we don't see a technical issue for books created in the BCMS, however since repeating `content type` and `version number` across BCMS book versions is a departure from the original scope, there may be implications we're not thinking of now. We're adding 2 days for code review and scope sign-off.
1. The [updated request above (option 1)](https://gitlab.coko.foundation/ncbi/ncbi/-/issues/783#option-1-change-in-conversion-workflow-type) asks the BCMS to accommodate a scenario that results in two book versions with the same `book-submit-id` + `version-name` + `version-number`. Therefore the current FTP spec would need to be reconsidered if NCBI plans to introduce FTP support at a later date. Since we also have the `workflow` information in the meta.xml file, a reasonable solution is to add `workflow` as a require value to match book versions. This is the best proposal we can give at this time and it would need to be validated by Coko and NCBI at the start of the project. As an integration point, this spec change requires input from NCBI and Coko teams.
2. We think it would be confusing to users to see two versions in the BCMS with the same name. Ideally we should hide all locked versions from all users except Sys Amins. This is not included in this estimate.
## Design
<!-- Include sketches or wireframes of the UI suggested for this feature. -->
Pending
## Acceptance criteria
<!-- Provide the criteria that should be met for this feature. These criteria must be clearly defined customer requirements aligned to NCBI’s user stories in its Statement of Work. These criteria must be testable by either user testing, unit tests or integration tests.-->
- [ ] System Admin can delete or lock a Book Version in any one Workflow and create a new Workflow Book Version in a different Workflow as long as the processing type remains the same
- [ ] When System Admin successfully modifies the Workflow Type for a Book by creating a new Workflow Book Version, then the Files UI will appear according to the specifications correctly for each Workflow Book Version type, AND
- [ ] Users can only download files in the Locked Workflow versions
- [ ] When System Admin successfully modifies the Workflow Type for a Book by creating a new Workflow Book Version, THEN
- [ ] The Locked Workflow version can no longer be Submitted, Reload to Preview, or Published
- [ ] The new Workflow version will Convert according to the new Workflow Type Processing Integration specifications
## Definition of ready
<!-- A checklist of what needs to be done to a product backlog item before the team can start implementing it in the next sprint. -->
- [ ] BCMS User Story / Context has been well defined
- [ ] The priority of the user story is specified and agreed
- [ ] Digital assets added (design, database scheme, mockups etc if relevant)
- [ ] Coko Technical Proposal approved by NCBI
- [ ] Testable Acceptance Criteria approved by NCBI
- [ ] Estimate of effort to complete (time or points)
- [ ] The issue has been broken down into development tasks (if necessary)
- [ ] Requirements Clarified
- [ ] The product owner and development team agree that the user story is ready for development
- [ ] NCBI adds “Dev_Ready”
## Definition of done
<!-- A checklist of criteria that must be completed for a story to be considered “done.” -->
- [ ] All coding tasks are finished and implemented
- [ ] QA approved
- [ ] Deployed and tested on “ncbidev” (by Coko team)
- [ ] Deployed and tested on “ncbi” (by NCBI team)
- [ ] Acceptance Criteria Met
## Implementation
<!-- A description of the steps to implement the feature. To be completed by the lead dev. If there are multiple tasks, then break these down into "task" below.-->
## Alternative approaches (if applicable)
<!-- Include any alternatives to meet this use case. -->
## Scheduling
* [ ] Milestone is linked
* [ ] Iteration is linked
* [ ] Dependencies: ("None" or list issue numbers if relevant)
* [ ] Development estimate is added to issue time tracking
---P06: MVP Data Model and Integrity Issues to Ensure Data Quality in Bookshelf and NLM Databaseshttps://gitlab.coko.foundation/ncbi/ncbi/-/issues/1647Invalid TOC XML - repeated chapter tagged twice instead of a PI used2024-01-17T06:31:28ZStacy LathropInvalid TOC XML - repeated chapter tagged twice instead of a PI used<!-- Required. Provide a general summary of the issue in the title above -->
## Expected behaviour
<!-- Required. Tell us what should happen -->
TOC XML should be valid to BITS DTD and PMC style checker compliant.
## Current behaviou...<!-- Required. Provide a general summary of the issue in the title above -->
## Expected behaviour
<!-- Required. Tell us what should happen -->
TOC XML should be valid to BITS DTD and PMC style checker compliant.
## Current behaviour
<!-- Required. Tell us what happens instead of the expected behaviour -->
Many TOC XML are invalid because when a repeated chapter is indicated that chapter is getting tagged twice in the TOC XML rather than the correct PI being used in the repeated part.
## Steps to reproduce
<!-- Required. Provide a link to a live example or screenshots, and the steps to reproduce this bug.]-->
1. Validate attached TOC.xml -[TOC_1647.xml](/uploads/5a46b9da648e10c5197ba149224fa558/TOC_1647.xml)
2. See this file is tagged twice completely when it should only have a repeat PI - `<?xml_file epigeneticmechanismscontrollingmesode.xml?>`
## Environment
<!-- Required. Provide relevant information such as browser name and version, PC or Mac use, internet speed, etc.]-->
This is occurring in domain `stembook`. I cannot reproduce it on Coko site. @deniskar can you understand why?
## Possible solution
<!-- If known, provide details on how to fix the bug.-->
<!-- After creating this issue you can link other related or blocking issues with the Gitlab's Linked issues functionality. -->
## QA Steps
[To be completed by Coko once dev is done]
## Scheduling
<!-- Select all the relevant options -->P04: Support valid and compliant TOC XML for all migrated Bookshelf contentDenis KaramyshevDenis Karamyshevhttps://gitlab.coko.foundation/ncbi/ncbi/-/issues/1646Permit Editors, Org Admin, System Admin to Fail a Job and Send it back to New...2024-01-16T18:08:10ZStacy LathropPermit Editors, Org Admin, System Admin to Fail a Job and Send it back to New Upload<!-- Required. Provide a general summary of the issue in the title above -->
## Context
<!-- Give the necessary context for your proposal. For example, what problem will this feature solve for users? What are the use cases, benefits, ...<!-- Required. Provide a general summary of the issue in the title above -->
## Context
<!-- Give the necessary context for your proposal. For example, what problem will this feature solve for users? What are the use cases, benefits, and goals? -->
GeneReviews and other NIH power users have reported that they are losing lots of wasted time updating their files when they make a mistake and press "Submit" and immediately know there is a problem with the files they processed. But they can't fix the problem for sometimes more than four hours because the status is in an active "Converting" or "Loading Preview" status. They have requested the ability to Abort or Fail a job and have it automatically go back to a "New Upload" status if the source file was in "Converting" or "Loading Preview" with the ability to upload a corrected Source file.
## Proposal
<!-- A precise statement of the proposed feature. -->
1. Add a "Fail" button On Chapter / Book Component pages to the Left of the "Reload Preview" status
2. "Fail" button is active for Editors, Org Admin, System Admin IF Source files are in "Sending," "Converting," or "Loading Preview" status
3. If user presses "Fail" a "Fail" notification is sent back to PMC Task Manager to Fail any active sessions, AND
4. When user presses "Fail" button the Component Status and Source File status becomes "New Upload"
4. User can upload new source file and press "Submit" again
## Design
<!-- Include sketches or wireframes of the UI suggested for this feature. -->
TBD
## Acceptance criteria
<!-- Provide the criteria that should be met for this feature. These criteria must be clearly defined customer requirements aligned to NCBI’s user stories in its Statement of Work. These criteria must be testable by either user testing, unit tests or integration tests.-->
- [ ] Editors, Org Admin, and System Admin can press "Fail" button On Chapter / Book Component pages If Source files are in "Sending," "Converting," or "Loading Preview" status
- [ ] Editors, Org Admin, and System Admin can Upload and Submit new source file after they press "Fail" and the Component and Source File changes to "New Upload"
## Definition of ready
<!-- A checklist of what needs to be done to a product backlog item before the team can start implementing it in the next sprint. -->
- [ ] BCMS User Story / Context has been well defined
- [ ] The priority of the user story is specified and agreed
- [ ] Digital assets added (design, database scheme, mockups etc if relevant)
- [ ] Coko Technical Proposal approved by NCBI
- [ ] Testable Acceptance Criteria approved by NCBI
- [ ] Estimate of effort to complete (time or points)
- [ ] The issue has been broken down into development tasks (if necessary)
- [ ] Requirements Clarified
- [ ] The product owner and development team agree that the user story is ready for development
- [ ] NCBI adds “Dev_Ready”
## Definition of done
<!-- A checklist of criteria that must be completed for a story to be considered “done.” -->
- [ ] All coding tasks are finished and implemented
- [ ] QA approved
- [ ] Deployed and tested on “ncbidev” (by Coko team)
- [ ] Deployed and tested on “ncbi” (by NCBI team)
- [ ] Acceptance Criteria Met
## Implementation
<!-- A description of the steps to implement the feature. To be completed by the lead dev. If there are multiple tasks, then break these down into "task" below.-->
## Alternative approaches (if applicable)
<!-- Include any alternatives to meet this use case. -->
## Scheduling
* [ ] Milestone is linked
* [ ] Iteration is linked
* [ ] Dependencies: ("None" or list issue numbers if relevant)
* [ ] Development estimate is added to issue time tracking
---P09: Book Manager and other MVP BCMS improvements and Lower Priority Bug Fixeshttps://gitlab.coko.foundation/ncbi/ncbi/-/issues/1645Pass metadata and settings PDF2XML vendor for tagging2024-01-16T14:04:18ZStacy LathropPass metadata and settings PDF2XML vendor for tagging<!-- Required. Provide a general summary of the issue in the title above -->
## Expected behaviour
Requirements here: https://gitlab.coko.foundation/ncbi/ncbi/-/issues/404
**Package to Apex from BCMS**
Sample package: [BCMS-to-APEX-s...<!-- Required. Provide a general summary of the issue in the title above -->
## Expected behaviour
Requirements here: https://gitlab.coko.foundation/ncbi/ncbi/-/issues/404
**Package to Apex from BCMS**
Sample package: [BCMS-to-APEX-sample.zip](/ncbi/ncbi/uploads/cc7569dffcc8548c3269b697553699af/BCMS-to-APEX-sample.zip)
**Metadata** Content added in the metadata UI of the relevant book, corresponding to manifest file types:
* cover
And:
* Book meta in json
* Collection meta in json
* settings in json
## Current behaviour
PDF2XML taggers report no metadata or settings are being provided in packages with completed values, per:
**Folder: Metadata** Contains a cover image *only* in the case where the image has been extracted from the source PDF. No metadata is sent back from Apex:
* Wholebook use case: Any metadata sent to Apex is written into the metadata node in the wholebook.xml
* Chapter use case: BCMS writes Book metadata from UI into chapter.xml file prior to load to PMC
Like wholebook XML, following NCBI-specific metadata and settings should be minimally sent to taggers:
Coko will pass the following pieces of NCBI metadata to XML conversion and PDF tagging:
* domain name (required)
* collection id (optional)
* collection title - TBD whether this can be a string or requires formatting and needs to be passed during Load to PMC
* source type (required)
* publisher name (optional)
* publisher location (optional)
All other data or metadata will be in the PDF or support folders.
```
{
"job_id": 9876543210, // Reference ID for the XML conversion job. It's generated by Coko and used by NCBI to report back the status of the conversion.
"user_name": "jordandc", // Name of a user initiating a conversion
"main_xml": "978-3-030-47318-1_Book.xml" // Filename of the primary XML file to use as the conversion entry point.
"domain": "spr9783030473181", // PMCBook domain name of the book being converted
"collection_id": "wtcollect", // PMCBook domain name of the collection that the book being converted belongs to (OPTIONAL)
"collection_title": "Wellcome Monographs", // Title of the collection that the book being converted belongs to (OPTIONAL)
"source_type": "Book", // BCMS assigned "source-type" for the book being converted
"publisher_name": "Springer", // BCMS assigned name of the bibliographic publisher (OPTIONAL)
"publisher_loc": "Cham (CH)", // BCMS assigned publication place (OPTIONAL)
"package": "spr9783030473181.9876543210.2020_05_15-09_25_45.zip", // Name of the package with the XML file, in domain.job_id.timestamp format
"notification_recipients": { // List of emails for NCBI Task Manager (not CoKo) to send notifications to
"success": ["bookshelf@ncbi.nlm.nih.gov","fritz@publisher.org"],
"failure": ["bookshelf@ncbi.nlm.nih.gov"]
}
}
```
## Steps to reproduce
<!-- Required. Provide a link to a live example or screenshots, and the steps to reproduce this bug.]-->
1. Create a PDF wholebook
2. Enter in source type and publisher name and publisher location using metadata UI
3. Add a collection via settings
4. Check that all above values are sent to Tagging vendor in JSON per provided specifications
5. Check converted XML that all these values are correctly tagged per those provided specifications
## Environment
<!-- Required. Provide relevant information such as browser name and version, PC or Mac use, internet speed, etc.]-->
## Possible solution
<!-- If known, provide details on how to fix the bug.-->
<!-- After creating this issue you can link other related or blocking issues with the Gitlab's Linked issues functionality. -->
## QA Steps
[To be completed by Coko once dev is done]
## Scheduling
<!-- Select all the relevant options -->
Fixing this issue is required for [Priority 1: Deploy MVP](https://gitlab.coko.foundation/groups/ncbi/-/epics/56)P05: Address MVP Files Management and Processing Issues to support all current Bookshelf submitters and NCBI Integration specificationshttps://gitlab.coko.foundation/ncbi/ncbi/-/issues/1644Agree on, document, and implement process for resolving issues with the metad...2024-01-16T14:07:18ZStacy LathropAgree on, document, and implement process for resolving issues with the metadata and TOC XML written by the BCMS<!-- Required. Provide a general summary of the issue in the title above -->
## Context
<!-- Give the necessary context for your proposal. For example, what problem will this feature solve for users? What are the use cases, benefits, ...<!-- Required. Provide a general summary of the issue in the title above -->
## Context
<!-- Give the necessary context for your proposal. For example, what problem will this feature solve for users? What are the use cases, benefits, and goals? -->
There needs to be absolute clarity about the acceptance criteria for the BCMS to write XML that is valid against the BITS DTD and compliant against the PMC style checker and faithful in preview to existing TOCs published from the Silverlight CMS for existing content. There also needs to be 1) a process for identifying issues automatically against NCBI supported scripts as soon as possible in the process - see #1643 - and 2) a process for triaging both those errors AND any errors detected by human QA of the previews not meeting the same level of quality as Silverlight generated TOCs.
## Proposal
<!-- A precise statement of the proposed feature. -->
NCBI and Coko will agree on and document a mutually agreed process for handling issues with the metadata and TOC XML written by the BCMS.
## Design
<!-- Include sketches or wireframes of the UI suggested for this feature. -->
## Acceptance criteria
<!-- Provide the criteria that should be met for this feature. These criteria must be clearly defined customer requirements aligned to NCBI’s user stories in its Statement of Work. These criteria must be testable by either user testing, unit tests or integration tests.-->
- [ ] A process for handling issues with the metadata and TOC XML written by the BCMS will be documented on the Gitlab wiki.
- [ ] The process will be implemented successfully as soon as it is documented for triaging new errors.
## Definition of ready
<!-- A checklist of what needs to be done to a product backlog item before the team can start implementing it in the next sprint. -->
- [ ] BCMS User Story / Context has been well defined
- [ ] The priority of the user story is specified and agreed
- [ ] Digital assets added (design, database scheme, mockups etc if relevant)
- [ ] Coko Technical Proposal approved by NCBI
- [ ] Testable Acceptance Criteria approved by NCBI
- [ ] Estimate of effort to complete (time or points)
- [ ] The issue has been broken down into development tasks (if necessary)
- [ ] Requirements Clarified
- [ ] The product owner and development team agree that the user story is ready for development
- [ ] NCBI adds “Dev_Ready”
## Definition of done
<!-- A checklist of criteria that must be completed for a story to be considered “done.” -->
- [ ] All coding tasks are finished and implemented
- [ ] QA approved
- [ ] Deployed and tested on “ncbidev” (by Coko team)
- [ ] Deployed and tested on “ncbi” (by NCBI team)
- [ ] Acceptance Criteria Met
## Implementation
<!-- A description of the steps to implement the feature. To be completed by the lead dev. If there are multiple tasks, then break these down into "task" below.-->
## Alternative approaches (if applicable)
<!-- Include any alternatives to meet this use case. -->
## Scheduling
* [ ] Milestone is linked
* [ ] Iteration is linked
* [ ] Dependencies: ("None" or list issue numbers if relevant)
* [ ] Development estimate is added to issue time tracking
---P05: Address MVP Files Management and Processing Issues to support all current Bookshelf submitters and NCBI Integration specificationshttps://gitlab.coko.foundation/ncbi/ncbi/-/issues/1643BCMS runs ALL XML it WRITES against PMC style checker BEFORE uploading files ...2024-01-16T21:10:27ZStacy LathropBCMS runs ALL XML it WRITES against PMC style checker BEFORE uploading files to BCMS and sending them to PMC ingest<!-- Required. Provide a general summary of the issue in the title above -->
## Context
<!-- Give the necessary context for your proposal. For example, what problem will this feature solve for users? What are the use cases, benefits, ...<!-- Required. Provide a general summary of the issue in the title above -->
## Context
<!-- Give the necessary context for your proposal. For example, what problem will this feature solve for users? What are the use cases, benefits, and goals? -->
A lot of XML written by BCMS is not valid against the BITS DTD or compliant against the PMC Style Checker. This is minimal acceptance criteria for ALL XML written by the BCMS. Thus, the BCMS should run ALL XML it WRITES against the PMC style checker BEFORE uploading files to BCMS and sending them to PMC ingest because this will report validation and style checker errors that prevent loading.
## Proposal
<!-- A precise statement of the proposed feature. -->
The BCMS should run ALL XML it WRITES against the PMC style checker BEFORE uploading files to BCMS and sending them to PMC ingest because this will report validation and style checker errors that prevent loading. The NCBI supported PMC style checker is available here: https://www.ncbi.nlm.nih.gov/pmc/tools/stylechecker/
The Online PMC Style Checker is an interactive tool which provides a detailed report of all items in a document tagged using the NLM Book DTDs that do not comply with the Bookshelf Tagging Guidelines. The report will list items as either warnings or errors. Errors are required fixes, and warnings are suggested fixes. BCMS only needs to log immediate bug issues for maintenance for errors.
A downloadable XSL is available at: https://www.ncbi.nlm.nih.gov/pmc/pub/stylechecker-info/
Any errors running these tools will be reported immediately as Loading errors assigned to PMC with notifications to Coko project management / developer to address and prioritize as part of maintenance.
## Design
<!-- Include sketches or wireframes of the UI suggested for this feature. -->
## Acceptance criteria
<!-- Provide the criteria that should be met for this feature. These criteria must be clearly defined customer requirements aligned to NCBI’s user stories in its Statement of Work. These criteria must be testable by either user testing, unit tests or integration tests.-->
- [ ] XML that the BCMS writes will be valid against BITS DTD and compliant against PMC style checker
## Definition of ready
<!-- A checklist of what needs to be done to a product backlog item before the team can start implementing it in the next sprint. -->
- [ ] BCMS User Story / Context has been well defined
- [ ] The priority of the user story is specified and agreed
- [ ] Digital assets added (design, database scheme, mockups etc if relevant)
- [ ] Coko Technical Proposal approved by NCBI
- [ ] Testable Acceptance Criteria approved by NCBI
- [ ] Estimate of effort to complete (time or points)
- [ ] The issue has been broken down into development tasks (if necessary)
- [ ] Requirements Clarified
- [ ] The product owner and development team agree that the user story is ready for development
- [ ] NCBI adds “Dev_Ready”
## Definition of done
<!-- A checklist of criteria that must be completed for a story to be considered “done.” -->
- [ ] All coding tasks are finished and implemented
- [ ] QA approved
- [ ] Deployed and tested on “ncbidev” (by Coko team)
- [ ] Deployed and tested on “ncbi” (by NCBI team)
- [ ] Acceptance Criteria Met
## Implementation
<!-- A description of the steps to implement the feature. To be completed by the lead dev. If there are multiple tasks, then break these down into "task" below.-->
## Alternative approaches (if applicable)
<!-- Include any alternatives to meet this use case. -->
## Scheduling
* [ ] Milestone is linked
* [ ] Iteration is linked
* [ ] Dependencies: ("None" or list issue numbers if relevant)
* [ ] Development estimate is added to issue time tracking
---P05: Address MVP Files Management and Processing Issues to support all current Bookshelf submitters and NCBI Integration specificationshttps://gitlab.coko.foundation/ncbi/ncbi/-/issues/1642Republish jobs with converted files with file transfer issues and if fails se...2024-01-16T16:57:22ZStacy LathropRepublish jobs with converted files with file transfer issues and if fails second time report as File transfer Publishing Errors assigned to PMC<!-- Required. Provide a general summary of the issue in the title above -->
## Context
<!-- Give the necessary context for your proposal. For example, what problem will this feature solve for users? What are the use cases, benefits, ...<!-- Required. Provide a general summary of the issue in the title above -->
## Context
<!-- Give the necessary context for your proposal. For example, what problem will this feature solve for users? What are the use cases, benefits, and goals? -->
BCMS Users frequently report that the content they process gets "stuck," which corresponds to a component getting stuck in an active status in which the user can no longer conduct any action upon it.
## Dependencies
This feature extension improves the User experiences once the bug in #1545 is resolved.
This feature should be looked at the same time and in relation to other file management and processing integration tickets, particularly #1546, #1474 and #1453 and #1628
## Proposal
<!-- A precise statement of the proposed feature. -->
When a converted file is not transferred for loading a preview due to file transfer (FTP or AWS S3) being down, then:
1. The BCMS will try to resend the files to NCBI, OR
2. The BCMS will try to pick up the files again from NCBI, AND
3. If on the second time trying to send or retrieved transferred files fails, THEN
4. A "File transfer error" will be reported as a "Publishing errors" in the Errors tab for the component. The user will see status: Publishing Error and details on the Error tab:
```
Name: File transfer error
Category: File transfer error
Severity: Error
Assignee: PMC
Message: Publishing failed due to converted file transfer error. Please resubmit the file.
```
## Design
<!-- Include sketches or wireframes of the UI suggested for this feature. -->
N/A
## Acceptance criteria
<!-- Provide the criteria that should be met for this feature. These criteria must be clearly defined customer requirements aligned to NCBI’s user stories in its Statement of Work. These criteria must be testable by either user testing, unit tests or integration tests.-->
* [ ] User publishes job and converted files never are received by NCBI so hangs as Publishing. BCMS will auto-resend a second time and if the second time fails send a "Publishing error" typed "File transfer error" assigned to PMC to resolve. The error message will read: "Publishing failed due to converted file transfer error. Please resubmit the file."
* [ ] User submits job and it is completed by NCBI but BCMS never receives it so it hangs as Publishing. BCMS will try to retrieve the file a second time and if the second time fails send a "Publishing error" typed "File transfer error" assigned to PMC to resolved. The error message will read: "Publishing failed due to converted file transfer error. Please resubmit the file."
## Definition of ready
<!-- A checklist of what needs to be done to a product backlog item before the team can start implementing it in the next sprint. -->
- [ ] BCMS User Story / Context has been well defined
- [ ] The priority of the user story is specified and agreed
- [ ] Digital assets added (design, database scheme, mockups etc if relevant)
- [ ] Coko Technical Proposal approved by NCBI
- [ ] Testable Acceptance Criteria approved by NCBI
- [ ] Estimate of effort to complete (time or points)
- [ ] The issue has been broken down into development tasks (if necessary)
- [ ] Requirements Clarified
- [ ] The product owner and development team agree that the user story is ready for development
- [ ] NCBI adds “Dev_Ready”
## Definition of done
<!-- A checklist of criteria that must be completed for a story to be considered “done.” -->
- [ ] All coding tasks are finished and implemented
- [ ] QA approved
- [ ] Deployed and tested on “ncbidev” (by Coko team)
- [ ] Deployed and tested on “ncbi” (by NCBI team)
- [ ] Acceptance Criteria Met
## Implementation
<!-- A description of the steps to implement the feature. To be completed by the lead dev. If there are multiple tasks, then break these down into "task" below.-->
## Alternative approaches (if applicable)
<!-- Include any alternatives to meet this use case. -->
## Scheduling
* [ ] Milestone is linked
* [ ] Iteration is linked
* [ ] Dependencies: ("None" or list issue numbers if relevant)
* [ ] Development estimate is added to issue time tracking
---P05: Address MVP Files Management and Processing Issues to support all current Bookshelf submitters and NCBI Integration specificationshttps://gitlab.coko.foundation/ncbi/ncbi/-/issues/1641Reload to PMC jobs with converted files with file transfer issues and if fail...2024-01-16T16:55:17ZStacy LathropReload to PMC jobs with converted files with file transfer issues and if fails second time report as File transfer Loading Errors assigned to PMC<!-- Required. Provide a general summary of the issue in the title above -->
## Context
<!-- Give the necessary context for your proposal. For example, what problem will this feature solve for users? What are the use cases, benefits, ...<!-- Required. Provide a general summary of the issue in the title above -->
## Context
<!-- Give the necessary context for your proposal. For example, what problem will this feature solve for users? What are the use cases, benefits, and goals? -->
BCMS Users frequently report that the content they process gets "stuck," which corresponds to a component getting stuck in an active status in which the user can no longer conduct any action upon it.
## Dependencies
This feature extension improves the User experiences once the bug in #1545 is resolved.
This feature should be looked at the same time and in relation to other file management and processing integration tickets, particularly #1546, #1474 and #1453 and #1628
## Proposal
<!-- A precise statement of the proposed feature. -->
When a converted file is not transferred for loading a preview due to file transfer (FTP or AWS S3) being down, then:
1. The BCMS will try to resend the files to NCBI, OR
2. The BCMS will try to pick up the files again from NCBI, AND
3. If on the second time trying to send or retrieved transferred files fails, THEN
4. A "File transfer error" will be reported as a "Loading errors" in the Errors tab for the component. The user will see status: Loadding Error and details on the Error tab:
```
Name: File transfer error
Category: File transfer error
Severity: Error
Assignee: PMC
Message: Preview not generated due to converted file transfer error. Please resubmit the file.
```
## Design
<!-- Include sketches or wireframes of the UI suggested for this feature. -->
N/A
## Acceptance criteria
<!-- Provide the criteria that should be met for this feature. These criteria must be clearly defined customer requirements aligned to NCBI’s user stories in its Statement of Work. These criteria must be testable by either user testing, unit tests or integration tests.-->
* [ ] User reloads preview job and converted files never are received by NCBI so hangs as Loading preview. BCMS will auto-resend a second time and if the second time fails send a "Loading error" typed "File transfer error" assigned to PMC to resolve. The error message will read: "Preview not generated due to converted file transfer error. Please resubmit the file."
* [ ] User submits job and it is completed by NCBI but BCMS never receives it so it hangs as Loading preview. BCMS will try to retrieve the file a second time and if the second time fails send a "Loading error" typed "File transfer error" assigned to PMC to resolved. The error message will read: "Preview not generated due to converted file transfer error. Please resubmit the file."
## Definition of ready
<!-- A checklist of what needs to be done to a product backlog item before the team can start implementing it in the next sprint. -->
- [ ] BCMS User Story / Context has been well defined
- [ ] The priority of the user story is specified and agreed
- [ ] Digital assets added (design, database scheme, mockups etc if relevant)
- [ ] Coko Technical Proposal approved by NCBI
- [ ] Testable Acceptance Criteria approved by NCBI
- [ ] Estimate of effort to complete (time or points)
- [ ] The issue has been broken down into development tasks (if necessary)
- [ ] Requirements Clarified
- [ ] The product owner and development team agree that the user story is ready for development
- [ ] NCBI adds “Dev_Ready”
## Definition of done
<!-- A checklist of criteria that must be completed for a story to be considered “done.” -->
- [ ] All coding tasks are finished and implemented
- [ ] QA approved
- [ ] Deployed and tested on “ncbidev” (by Coko team)
- [ ] Deployed and tested on “ncbi” (by NCBI team)
- [ ] Acceptance Criteria Met
## Implementation
<!-- A description of the steps to implement the feature. To be completed by the lead dev. If there are multiple tasks, then break these down into "task" below.-->
## Alternative approaches (if applicable)
<!-- Include any alternatives to meet this use case. -->
## Scheduling
* [ ] Milestone is linked
* [ ] Iteration is linked
* [ ] Dependencies: ("None" or list issue numbers if relevant)
* [ ] Development estimate is added to issue time tracking
---P05: Address MVP Files Management and Processing Issues to support all current Bookshelf submitters and NCBI Integration specificationshttps://gitlab.coko.foundation/ncbi/ncbi/-/issues/1640Invalid TOC XML - id cannot start with a number2024-01-16T21:19:14ZStacy LathropInvalid TOC XML - id cannot start with a number<!-- Required. Provide a general summary of the issue in the title above -->
## Expected behaviour
<!-- Required. Tell us what should happen -->
TOC XML should be valid to BITS DTD and PMC style checker compliant.
## Current behaviou...<!-- Required. Provide a general summary of the issue in the title above -->
## Expected behaviour
<!-- Required. Tell us what should happen -->
TOC XML should be valid to BITS DTD and PMC style checker compliant.
## Current behaviour
<!-- Required. Tell us what happens instead of the expected behaviour -->
Many TOC XML are invalid because IDs are beginning with a number when this is not permitted.
## Steps to reproduce
<!-- Required. Provide a link to a live example or screenshots, and the steps to reproduce this bug.]-->
1. Validate attached TOC.xml -[TOC_1640.xml](/uploads/7b815bde8d1f14a1253a39ee594e3e64/TOC_1640.xml)
2. See error -
```
System ID: C:\Users\lathrops\OneDrive - National Institutes of Health\Desktop\Unconfirmed 2202.crdownload
Main validation file: C:\Users\lathrops\OneDrive - National Institutes of Health\Desktop\Unconfirmed 2202.crdownload
Schema: \\fridge\pmcprod\load\converter4\DTD\dtd-niso-z39.96\extensions\bits\2.0\BITS-book2.dtd
Engine name: Xerces
Severity: error
Problem ID: IDInvalidWithNamespaces
Description: Attribute value "17q12foundationbreakgrimesiowa" of type ID must be an NCName when namespaces are enabled.
Start location: 545:1993
End location: 545:2025
```
## Environment
<!-- Required. Provide relevant information such as browser name and version, PC or Mac use, internet speed, etc.]-->
This is occurring in domain `gene`. I cannot reproduce it on Coko site. @deniskar can you understand why? Affiliations should not get tagged in TOC.XML but they are in content in NCBI deployment but not Coko deployment.
## Possible solution
<!-- If known, provide details on how to fix the bug.-->
<!-- After creating this issue you can link other related or blocking issues with the Gitlab's Linked issues functionality. -->
## QA Steps
[To be completed by Coko once dev is done]
## Scheduling
<!-- Select all the relevant options -->P04: Support valid and compliant TOC XML for all migrated Bookshelf contentDenis KaramyshevDenis Karamyshevhttps://gitlab.coko.foundation/ncbi/ncbi/-/issues/1639Invalid TOC XML - duplicate aff ids are not valid2024-01-16T21:17:42ZStacy LathropInvalid TOC XML - duplicate aff ids are not valid<!-- Required. Provide a general summary of the issue in the title above -->
## Expected behaviour
<!-- Required. Tell us what should happen -->
TOC XML should be valid to BITS DTD and PMC Style Checker compliant.
## Current behaviou...<!-- Required. Provide a general summary of the issue in the title above -->
## Expected behaviour
<!-- Required. Tell us what should happen -->
TOC XML should be valid to BITS DTD and PMC Style Checker compliant.
## Current behaviour
<!-- Required. Tell us what happens instead of the expected behaviour -->
TOC XML is invalid in numerous cases because duplicate aff ids are tagged.
## Steps to reproduce
<!-- Required. Provide a link to a live example or screenshots, and the steps to reproduce this bug.]-->
1. Validate attached TOC.xml [TOC_1639.xml](/uploads/7924fbba1cc8ad7dd108e4f36fe4d919/TOC_1639.xml)
2. See error -
```
System ID: C:\Users\lathrops\Downloads\Unconfirmed_2202.crdownload
Main validation file: C:\Users\lathrops\Downloads\Unconfirmed_2202.crdownload
Schema: \\fridge\pmcprod\load\converter4\DTD\dtd-niso-z39.96\extensions\bits\2.0\BITS-book2.dtd
Engine name: Xerces
Severity: error
Problem ID: IDNotUnique
Description: Attribute value "seattlevamedicalcenterbreakdepartmentsofneurologyandmedicinebreakuniversityofwashingtonbreakseattlewashington" of type ID must be unique within the document.
Start location: 4684:169
End location: 4684:280
```
## Environment
<!-- Required. Provide relevant information such as browser name and version, PC or Mac use, internet speed, etc.]-->
This is occurring in domain `gene`. I cannot reproduce it on Coko site. @deniskar can you understand why? Affiliations should not get tagged in TOC.XML but they are in content in NCBI deployment but not Coko deployment.
## Possible solution
<!-- If known, provide details on how to fix the bug.-->
<!-- After creating this issue you can link other related or blocking issues with the Gitlab's Linked issues functionality. -->
## QA Steps
[To be completed by Coko once dev is done]
## Scheduling
<!-- Select all the relevant options -->P04: Support valid and compliant TOC XML for all migrated Bookshelf contentDenis KaramyshevDenis Karamyshevhttps://gitlab.coko.foundation/ncbi/ncbi/-/issues/1638In collection metadata: When OA toggle is on, and license type = 'Other', use...2024-01-16T08:23:32ZStacy LathropIn collection metadata: When OA toggle is on, and license type = 'Other', user should be required to provide a license URL<!-- Required. Provide a general summary of the issue in the title above -->
## Context
<!-- Give the necessary context for your proposal. For example, what problem will this feature solve for users? What are the use cases, benefits, ...<!-- Required. Provide a general summary of the issue in the title above -->
## Context
<!-- Give the necessary context for your proposal. For example, what problem will this feature solve for users? What are the use cases, benefits, and goals? -->
A URL should be required if an Other license type is selected in Collection metadata.
## Proposal
<!-- A precise statement of the proposed feature. -->
Make the license URL writeable when user selects Other license in Collection metadata. Write this URL into the collection XML as such:
```
<license xmlns:xlink="http://www.w3.org/1999/xlink" license-type="open-access"
xlink:href="https://www.ncbi.nlm.nih.gov/books/NBK138602/">
```
## Design
<!-- Include sketches or wireframes of the UI suggested for this feature. -->
## Acceptance criteria
<!-- Provide the criteria that should be met for this feature. These criteria must be clearly defined customer requirements aligned to NCBI’s user stories in its Statement of Work. These criteria must be testable by either user testing, unit tests or integration tests.-->
- [ ] In a Collection Component, System Admin, Org Admin, Editor can select Other as a license type in the dropdown, AND when they do be required to enter a license URL in the license URL free text box, AND
- [ ] The license URL will be saved and unchanged until the user modifies and saves their modifications to that license URL
- [ ] When a Collection is loaded, if user entered the Other license URL to Bookshelf https://www.ncbi.nlm.nih.gov/books, it will be written into the license in the collection metadata as such: `<license xmlns:xlink="http://www.w3.org/1999/xlink" license-type="open-access"`
- [ ] When any chapter-processed book in a Collection, such as Help Bookshelf (`helpbookshelf`) in the NCBI Help Collection (`helpcollect`), and a user enters the Other license URL to Bookshelf https://www.ncbi.nlm.nih.gov/books then it will be written to the collection metadata in every Help Bookshelf book part wrapper converted XMl as: `<license xmlns:xlink="http://www.w3.org/1999/xlink" license-type="open-access"`
## Definition of ready
<!-- A checklist of what needs to be done to a product backlog item before the team can start implementing it in the next sprint. -->
- [ ] BCMS User Story / Context has been well defined
- [ ] The priority of the user story is specified and agreed
- [ ] Digital assets added (design, database scheme, mockups etc if relevant)
- [ ] Coko Technical Proposal approved by NCBI
- [ ] Testable Acceptance Criteria approved by NCBI
- [ ] Estimate of effort to complete (time or points)
- [ ] The issue has been broken down into development tasks (if necessary)
- [ ] Requirements Clarified
- [ ] The product owner and development team agree that the user story is ready for development
- [ ] NCBI adds “Dev_Ready”
## Definition of done
<!-- A checklist of criteria that must be completed for a story to be considered “done.” -->
- [ ] All coding tasks are finished and implemented
- [ ] QA approved
- [ ] Deployed and tested on “ncbidev” (by Coko team)
- [ ] Deployed and tested on “ncbi” (by NCBI team)
- [ ] Acceptance Criteria Met
## Implementation
<!-- A description of the steps to implement the feature. To be completed by the lead dev. If there are multiple tasks, then break these down into "task" below.-->
## Alternative approaches (if applicable)
<!-- Include any alternatives to meet this use case. -->
## Scheduling
* [ ] Milestone is linked
* [ ] Iteration is linked
* [ ] Dependencies: ("None" or list issue numbers if relevant)
* [ ] Development estimate is added to issue time tracking
---P03: Support valid and compliant metadata for all migrated Bookshelf content