Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • D design
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 20
    • Issues 20
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • pubsweet
  • design
  • Issues
  • #31

Closed
Open
Created Jun 20, 2018 by Jen Spencer@jsms90Developer

Specify multiple gridUnits?

As I understand it, pubsweet is intending to change the gridUnit variable to 6px? This has already happened in the eLife theme.

We also have XXS, XS, S, M, L, XL & XXL for "vertical spacing", which have been added to our theme's code

Just feeding info back up, in case others would like this type of sizing, rather than computing gridUnit * 4 manually in each place in the code.

Personally, I'm unsure about XXS, XS, etc as variable names & would be more inclined to go with something like 1, 2, etc as we do with headings - see this comment in the eLife issue but perhaps this is a popular convention?

Relates #4, #10 & #24 (closed)

Edited Jun 20, 2018 by Jen Spencer
Assignee
Assign to
Time tracking