RFC: Add more theme variables at core theme
PubSweet uses default Coko theme which is documented here: https://gitlab.coko.foundation/pubsweet/pubsweet/blob/master/docs/content/using_themes.md#core-theme-variables
This includes the list of core theme variables but there are more options available to extend theme variables at the documentation in the file here: https://gitlab.coko.foundation/pubsweet/pubsweet/blob/master/packages/coko-theme/src/index.js
There are two issues for updated:
-
Variable name from the documentation which is not in the Coko theme.
On PubSweet theming section about typography, we havefontLineHeight
which is not declared anywhere in the theme and is not in use by any project. -
Extend list of theme variables LineHeight is now replaced by a list of new variables based on which font-size we are using. Now we can use
lineHeightBase
,
lineHeightBaseSmall
,
lineHeightHeading1
,
lineHeightHeading2
,
lineHeightHeading3
,
lineHeightHeading4
,
lineHeightHeading5
,
lineHeightHeading6
Also colorWarning
and fontHeading
are not included in the core theme variables list.
Editoria is using all these theme variables.
Micropublications uses lineHeightBase
, lineHeightBaseSmall
and colorWarning
variables.
While eLife, Hindawi and PMC Europe have their own theming variables with different values.
I propose to update documentation about theme by removing fontLineHeight
and adding new lineHeight variables there and colorWarning
.
Any thoughts on this @jure, @yannis, @alexgeo, @John.kopanas? Should we include all the variable in the theming documentation?