pubsweet issueshttps://gitlab.coko.foundation/pubsweet/pubsweet/-/issues2020-06-10T16:14:23Zhttps://gitlab.coko.foundation/pubsweet/pubsweet/-/issues/481xpub-edit's HtmlEditor uses componentWillMount2020-06-10T16:14:23ZJurexpub-edit's HtmlEditor uses componentWillMount```Warning: componentWillMount has been renamed, and is not recommended for use. See https://fb.me/react-unsafe-component-lifecycles for details.
* Move code with side effects to componentDidMount, and set initial state in the construct...```Warning: componentWillMount has been renamed, and is not recommended for use. See https://fb.me/react-unsafe-component-lifecycles for details.
* Move code with side effects to componentDidMount, and set initial state in the constructor.
* Rename componentWillMount to UNSAFE_componentWillMount to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.
Please update the following components: HtmlEditor```https://gitlab.coko.foundation/pubsweet/pubsweet/-/issues/327Dealing with packages/components/packages/* test config2020-06-08T11:33:17ZJureDealing with packages/components/packages/* test configCurrently, due to the way our testing is set up, you need to have a jest-setup.js per package, which changes NODE_CONFIG_DIR to the test config dir, e.g. `packages/components/config/`. This allows `node-config` to load the correct test c...Currently, due to the way our testing is set up, you need to have a jest-setup.js per package, which changes NODE_CONFIG_DIR to the test config dir, e.g. `packages/components/config/`. This allows `node-config` to load the correct test config for each package. However, nesting this doesn't appear to work (e.g. have a `jest-setup.js` in `packages/components/packages/AWSS3/`), probably because `packages/components/jest-setup.js` will also load and its jest will pick up the tests in `packages/componets/packages/AWSS3` but with the wrong config file.
We solved this temporarily by adding the config required by AWSS3 to `packages/components/config/test.js`, but it's probably best to uncouple all of this and somehow have each `packages/components/packages/*` thing run its own test with its own `jest-setup.js`.https://gitlab.coko.foundation/pubsweet/pubsweet/-/issues/466`yarn global add` results in command not found2020-02-05T15:18:58ZJure`yarn global add` results in command not foundOn a fresh Ubuntu 18.04 install: if you install `yarn` as the installation instructions recommend, and then run `yarn global add pubsweet` (according to the getting started guide), and all goes seemingly well:
```
success Installed "pubs...On a fresh Ubuntu 18.04 install: if you install `yarn` as the installation instructions recommend, and then run `yarn global add pubsweet` (according to the getting started guide), and all goes seemingly well:
```
success Installed "pubsweet@5.1.5" with binaries:
- pubsweet
```
You still won't be able to run `pubsweet` (command not found), because the `yarn global bin` path is not in PATH, by e.g. editing your `.bashrc` to say:
```
export PATH="$(yarn global bin):$PATH"
```
This is not an issue with PubSweet, but a yarn requirement we should document.Sidorela UkuSidorela Ukuhttps://gitlab.coko.foundation/pubsweet/pubsweet/-/issues/467Missing system dependencies description (git & docker)2020-02-05T15:18:51ZJureMissing system dependencies description (git & docker)Two additional dependencies, namely git and docker, are needed for completing the Getting started guide. These two are generally present in most developer environments, but we should still specify them.Two additional dependencies, namely git and docker, are needed for completing the Getting started guide. These two are generally present in most developer environments, but we should still specify them.Sidorela UkuSidorela Ukuhttps://gitlab.coko.foundation/pubsweet/pubsweet/-/issues/469'yarn server' results in server command not found2020-02-05T15:17:19ZSidorela Uku'yarn server' results in server command not foundTo start the pubsweet server and client-side application is required to run
`yarn server` command, but it results in 'server' command not found error.
The command which can do the work is `yarn pubsweet server`
I will open a new MR to...To start the pubsweet server and client-side application is required to run
`yarn server` command, but it results in 'server' command not found error.
The command which can do the work is `yarn pubsweet server`
I will open a new MR to update documentation for this.Sidorela UkuSidorela Ukuhttps://gitlab.coko.foundation/pubsweet/pubsweet/-/issues/468Update docs links2020-02-05T11:18:46ZSidorela UkuUpdate docs linksOn the introduction part of PubSweet documentation there is a link to Coko chat which does not redirects to PubSweet channel.
We can add there link from Coko forum there also: https://discourse.coko.foundation/c/InstallingPubSweet/5On the introduction part of PubSweet documentation there is a link to Coko chat which does not redirects to PubSweet channel.
We can add there link from Coko forum there also: https://discourse.coko.foundation/c/InstallingPubSweet/5Sidorela UkuSidorela Uku2020-02-06https://gitlab.coko.foundation/pubsweet/pubsweet/-/issues/462Audit what gets published to npm for each package2020-01-29T13:44:55ZJureAudit what gets published to npm for each packageThere are some unnecessary files included in the published packages.There are some unnecessary files included in the published packages.https://gitlab.coko.foundation/pubsweet/pubsweet/-/issues/406Update component's configuration to use method decided #4032020-01-29T10:51:15ZJureUpdate component's configuration to use method decided #403This is a task to rename existing core component's configuration keys to equal their package names.This is a task to rename existing core component's configuration keys to equal their package names.https://gitlab.coko.foundation/pubsweet/pubsweet/-/issues/445The examples in PubSweet docs should be copy-pasteable2019-04-09T08:53:35ZJureThe examples in PubSweet docs should be copy-pasteableYou should be able to copy and past the example of a component's use, and have it 'just work'
For example, the Link component includes this example:
```
<Link to={'www.google.com'}>Click here</Link>
```
It should be:
```
import { Link ...You should be able to copy and past the example of a component's use, and have it 'just work'
For example, the Link component includes this example:
```
<Link to={'www.google.com'}>Click here</Link>
```
It should be:
```
import { Link } from '@pubsweet/ui'
<Link to={'www.google.com'}>Click here</Link>
```https://gitlab.coko.foundation/pubsweet/pubsweet/-/issues/377Improve Signup component error messages2018-12-17T23:22:39ZJureImprove Signup component error messagesCurrently, e.g. if a user already exists, the error will be something like 'Conflict'
![image](/uploads/487548d6832eb2ed5a17847b8719ae86/image.png)
If the validation fails, it would be `Bad Request`.
We can make those error messages n...Currently, e.g. if a user already exists, the error will be something like 'Conflict'
![image](/uploads/487548d6832eb2ed5a17847b8719ae86/image.png)
If the validation fails, it would be `Bad Request`.
We can make those error messages nicer, to say things like 'A user with this username already exists', maybe at this point: https://gitlab.coko.foundation/pubsweet/pubsweet/blob/master/packages/components/Signup/Signup.jsx#L24
Inspired by #104https://gitlab.coko.foundation/pubsweet/pubsweet/-/issues/79Add license files to published components2018-05-14T11:52:43ZYannis BarlasAdd license files to published componentshttps://gitlab.coko.foundation/pubsweet/pubsweet/-/issues/108Check for clobber first2018-04-09T11:41:28ZYannis BarlasCheck for clobber firstIf I already have a db, and forget to pass the `--clobber` option, I'm allowed to give the cli tool all my info first (username, password etc), only to find out afterwards that I forgot the option.
Should we fail right from the start m...If I already have a db, and forget to pass the `--clobber` option, I'm allowed to give the cli tool all my info first (username, password etc), only to find out afterwards that I forgot the option.
Should we fail right from the start maybe?https://gitlab.coko.foundation/pubsweet/pubsweet/-/issues/114Output error message on nonexistent command2018-03-29T18:49:13ZAlf EatonOutput error message on nonexistent commandWhen `pubsweet foo` is run, there is no output - there should be an error message saying that "foo" is not a valid command.When `pubsweet foo` is run, there is no output - there should be an error message saying that "foo" is not a valid command.https://gitlab.coko.foundation/pubsweet/pubsweet/-/issues/89License missing2018-03-05T17:38:40ZSam GalsonLicense missingMissing in root: should probably be added to each package as well.Missing in root: should probably be added to each package as well.https://gitlab.coko.foundation/pubsweet/pubsweet/-/issues/107If an unknown option is used, e.g. 'pubsweet run', show help2018-03-01T15:59:45ZJureIf an unknown option is used, e.g. 'pubsweet run', show help