From 1e8127d2ea708593edb22c406d984c0acc3d8663 Mon Sep 17 00:00:00 2001 From: chris <kokosias@yahoo.gr> Date: Thu, 2 Dec 2021 16:28:48 +0200 Subject: [PATCH] fix tool --- .../MultipleChoiceQuestion.js | 4 ++-- .../MultipleChoiceSingleCorrectQuestion.js | 4 ++-- .../TrueFalseQuestionService/TrueFalseQuestion.js | 4 ++-- .../components/ToolBarBtn.js | 15 ++++----------- .../MultipleDropDown.js | 8 +++++--- 5 files changed, 15 insertions(+), 20 deletions(-) diff --git a/wax-prosemirror-services/src/MultipleChoiceQuestionService/MultipleChoiceQuestion.js b/wax-prosemirror-services/src/MultipleChoiceQuestionService/MultipleChoiceQuestion.js index df0d5eaaf..274c9d639 100644 --- a/wax-prosemirror-services/src/MultipleChoiceQuestionService/MultipleChoiceQuestion.js +++ b/wax-prosemirror-services/src/MultipleChoiceQuestionService/MultipleChoiceQuestion.js @@ -55,9 +55,9 @@ class MultipleChoiceQuestion extends Tools { label = 'Multiple Choice'; get run() { - return (view, main, context) => { + return (view, context) => { checkifEmpty(view); - createOption(main, context); + createOption(view, context); }; } diff --git a/wax-prosemirror-services/src/MultipleChoiceQuestionService/MultipleChoiceSingleCorrectQuestionService/MultipleChoiceSingleCorrectQuestion.js b/wax-prosemirror-services/src/MultipleChoiceQuestionService/MultipleChoiceSingleCorrectQuestionService/MultipleChoiceSingleCorrectQuestion.js index 9cfa3b32c..eaa9c6528 100644 --- a/wax-prosemirror-services/src/MultipleChoiceQuestionService/MultipleChoiceSingleCorrectQuestionService/MultipleChoiceSingleCorrectQuestion.js +++ b/wax-prosemirror-services/src/MultipleChoiceQuestionService/MultipleChoiceSingleCorrectQuestionService/MultipleChoiceSingleCorrectQuestion.js @@ -55,9 +55,9 @@ class MultipleChoiceSingleCorrectQuestion extends Tools { label = 'Multiple Choice Single Correct'; get run() { - return (view, main, context) => { + return (view, context) => { checkifEmpty(view); - createOption(main, context); + createOption(view, context); }; } diff --git a/wax-prosemirror-services/src/MultipleChoiceQuestionService/TrueFalseQuestionService/TrueFalseQuestion.js b/wax-prosemirror-services/src/MultipleChoiceQuestionService/TrueFalseQuestionService/TrueFalseQuestion.js index 170c95114..d4fe0a311 100644 --- a/wax-prosemirror-services/src/MultipleChoiceQuestionService/TrueFalseQuestionService/TrueFalseQuestion.js +++ b/wax-prosemirror-services/src/MultipleChoiceQuestionService/TrueFalseQuestionService/TrueFalseQuestion.js @@ -55,9 +55,9 @@ class MultipleChoiceQuestion extends Tools { label = 'True False'; get run() { - return (view, main, context) => { + return (view, context) => { checkifEmpty(view); - createOption(main, context); + createOption(view, context); }; } diff --git a/wax-prosemirror-services/src/MultipleChoiceQuestionService/components/ToolBarBtn.js b/wax-prosemirror-services/src/MultipleChoiceQuestionService/components/ToolBarBtn.js index d583f3b18..84090be50 100644 --- a/wax-prosemirror-services/src/MultipleChoiceQuestionService/components/ToolBarBtn.js +++ b/wax-prosemirror-services/src/MultipleChoiceQuestionService/components/ToolBarBtn.js @@ -13,44 +13,37 @@ const StyledButton = styled(MenuButton)` `; const ToolBarBtn = ({ view = {}, item }) => { - const { active, icon, label, onlyOnMain, run, select, title } = item; + const { icon, label, select, title } = item; const context = useContext(WaxContext); const { view: { main }, - activeViewId, activeView, } = useContext(WaxContext); - if (onlyOnMain) view = main; - const isEditable = main.props.editable(editable => { return editable; }); const { state } = view; - const isActive = !!( - active(state, activeViewId) && select(state, activeViewId) - ); - let isDisabled = !select(state, activeView); if (!isEditable) isDisabled = true; const ToolBarBtnComponent = useMemo( () => ( <StyledButton - active={isActive || false} + active={false} disabled={isDisabled} iconName={icon} label={label} onMouseDown={e => { e.preventDefault(); - item.run(view, main, context); + item.run(context.view.main, context); }} title={title} /> ), - [isActive, isDisabled], + [isDisabled], ); return ToolBarBtnComponent; diff --git a/wax-prosemirror-services/src/WaxToolGroups/MultipleDropDownToolGroupService/MultipleDropDown.js b/wax-prosemirror-services/src/WaxToolGroups/MultipleDropDownToolGroupService/MultipleDropDown.js index c86c8eec4..75f1b2359 100644 --- a/wax-prosemirror-services/src/WaxToolGroups/MultipleDropDownToolGroupService/MultipleDropDown.js +++ b/wax-prosemirror-services/src/WaxToolGroups/MultipleDropDownToolGroupService/MultipleDropDown.js @@ -99,6 +99,10 @@ class MultipleDropDown extends ToolGroup { } }); + const onChange = option => { + this._tools[option.value].run(main, context); + }; + const MultipleDropDown = useMemo( () => ( <Wrapper key={uuidv4()}> @@ -106,9 +110,7 @@ class MultipleDropDown extends ToolGroup { value={found} key={uuidv4()} options={dropDownOptions} - onChange={option => { - this._tools[option.value].run(view, main, context); - }} + onChange={option => onChange(option)} placeholder="Multiple Question Types" select={isDisabled} /> -- GitLab