From a199c6a6574d27dd5e7a15b6df22b3972de1541a Mon Sep 17 00:00:00 2001 From: Vukile Langa <vukilelanga@me.com> Date: Thu, 10 Oct 2024 18:51:01 +0200 Subject: [PATCH] fix(services): allow image alt text to be edited --- .../MultipleChoiceNodeView.js | 1 + .../MultipleChoiceSingleCorrectNodeView.js | 1 + .../TrueFalseQuestionService/QuestionTrueFalseNodeView.js | 7 ++++++- .../TrueFalseQuestionService/TrueFalseNodeView.js | 1 + .../QuestionTrueFalseSingleNodeView.js | 7 ++++++- .../TrueFalseSingleCorrectNodeView.js | 1 + 6 files changed, 16 insertions(+), 2 deletions(-) diff --git a/wax-questions-service/src/MultipleChoiceQuestionService/MultipleChoiceNodeView.js b/wax-questions-service/src/MultipleChoiceQuestionService/MultipleChoiceNodeView.js index 58040e5e2..8337f0423 100644 --- a/wax-questions-service/src/MultipleChoiceQuestionService/MultipleChoiceNodeView.js +++ b/wax-questions-service/src/MultipleChoiceQuestionService/MultipleChoiceNodeView.js @@ -26,6 +26,7 @@ export default class MultipleChoiceNodeView extends QuestionsNodeView { if ( !event.target.type || event.target.type === 'button' || + event.target.type === 'text' || event.target.type === 'textarea' ) { return true; diff --git a/wax-questions-service/src/MultipleChoiceQuestionService/MultipleChoiceSingleCorrectQuestionService/MultipleChoiceSingleCorrectNodeView.js b/wax-questions-service/src/MultipleChoiceQuestionService/MultipleChoiceSingleCorrectQuestionService/MultipleChoiceSingleCorrectNodeView.js index ce3ed262f..9204b81b4 100644 --- a/wax-questions-service/src/MultipleChoiceQuestionService/MultipleChoiceSingleCorrectQuestionService/MultipleChoiceSingleCorrectNodeView.js +++ b/wax-questions-service/src/MultipleChoiceQuestionService/MultipleChoiceSingleCorrectQuestionService/MultipleChoiceSingleCorrectNodeView.js @@ -26,6 +26,7 @@ export default class MultipleChoiceSingleCorrectNodeView extends QuestionsNodeVi if ( !event.target.type || event.target.type === 'button' || + event.target.type === 'text' || event.target.type === 'textarea' ) { return true; diff --git a/wax-questions-service/src/MultipleChoiceQuestionService/TrueFalseQuestionService/QuestionTrueFalseNodeView.js b/wax-questions-service/src/MultipleChoiceQuestionService/TrueFalseQuestionService/QuestionTrueFalseNodeView.js index 31b4e304a..aa47023df 100644 --- a/wax-questions-service/src/MultipleChoiceQuestionService/TrueFalseQuestionService/QuestionTrueFalseNodeView.js +++ b/wax-questions-service/src/MultipleChoiceQuestionService/TrueFalseQuestionService/QuestionTrueFalseNodeView.js @@ -23,7 +23,12 @@ export default class QuestionTrueFalseNodeView extends QuestionsNodeView { } stopEvent(event) { - if (event.target.type === 'textarea') { + if ( + !event.target.type || + event.target.type === 'button' || + event.target.type === 'text' || + event.target.type === 'textarea' + ) { return true; } const innerView = this.context.pmViews[this.node.attrs.id]; diff --git a/wax-questions-service/src/MultipleChoiceQuestionService/TrueFalseQuestionService/TrueFalseNodeView.js b/wax-questions-service/src/MultipleChoiceQuestionService/TrueFalseQuestionService/TrueFalseNodeView.js index 527a485f0..b52a9db18 100644 --- a/wax-questions-service/src/MultipleChoiceQuestionService/TrueFalseQuestionService/TrueFalseNodeView.js +++ b/wax-questions-service/src/MultipleChoiceQuestionService/TrueFalseQuestionService/TrueFalseNodeView.js @@ -26,6 +26,7 @@ export default class TrueFalseNodeView extends QuestionsNodeView { if ( !event.target.type || event.target.type === 'button' || + event.target.type === 'text' || event.target.type === 'textarea' ) { return true; diff --git a/wax-questions-service/src/MultipleChoiceQuestionService/TrueFalseSingleCorrectQuestionService/QuestionTrueFalseSingleNodeView.js b/wax-questions-service/src/MultipleChoiceQuestionService/TrueFalseSingleCorrectQuestionService/QuestionTrueFalseSingleNodeView.js index bd8f9a2c3..8aacd755a 100644 --- a/wax-questions-service/src/MultipleChoiceQuestionService/TrueFalseSingleCorrectQuestionService/QuestionTrueFalseSingleNodeView.js +++ b/wax-questions-service/src/MultipleChoiceQuestionService/TrueFalseSingleCorrectQuestionService/QuestionTrueFalseSingleNodeView.js @@ -23,7 +23,12 @@ export default class QuestionTrueFalseSingleNodeView extends QuestionsNodeView { } stopEvent(event) { - if (event.target.type === 'textarea') { + if ( + !event.target.type || + event.target.type === 'button' || + event.target.type === 'text' || + event.target.type === 'textarea' + ) { return true; } const innerView = this.context.pmViews[this.node.attrs.id]; diff --git a/wax-questions-service/src/MultipleChoiceQuestionService/TrueFalseSingleCorrectQuestionService/TrueFalseSingleCorrectNodeView.js b/wax-questions-service/src/MultipleChoiceQuestionService/TrueFalseSingleCorrectQuestionService/TrueFalseSingleCorrectNodeView.js index c94c3fc49..0d86be0e0 100644 --- a/wax-questions-service/src/MultipleChoiceQuestionService/TrueFalseSingleCorrectQuestionService/TrueFalseSingleCorrectNodeView.js +++ b/wax-questions-service/src/MultipleChoiceQuestionService/TrueFalseSingleCorrectQuestionService/TrueFalseSingleCorrectNodeView.js @@ -26,6 +26,7 @@ export default class TrueFalseSingleCorrectNodeView extends QuestionsNodeView { if ( !event.target.type || event.target.type === 'button' || + event.target.type === 'text' || event.target.type === 'textarea' ) { return true; -- GitLab