From f0258bedc3d6ce6551491fb97506f41f8dfc3814 Mon Sep 17 00:00:00 2001 From: chris <kokosias@yahoo.gr> Date: Sat, 12 Nov 2022 10:45:18 +0200 Subject: [PATCH] eslint --- .eslintrc.js | 7 ++++++ wax-prosemirror-core/src/config/Config.js | 2 -- .../components/componentPlugin.js | 24 +------------------ .../MenuService/MenuCollection.js | 2 +- .../MultipleChoiceDropDown.js | 1 - 5 files changed, 9 insertions(+), 27 deletions(-) diff --git a/.eslintrc.js b/.eslintrc.js index 6e5f1c917..679cc7de9 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -8,6 +8,13 @@ eslint.parserOptions = { }, }; +eslint.rules['no-unused-vars'] = ['error', { varsIgnorePattern: 'inject' }]; + +eslint.rules['no-underscore-dangle'] = [ + 'error', + { allow: ['_tools', '_config'] }, +]; + eslint.rules['class-methods-use-this'] = [ 1, { exceptMethods: ['run', 'enable', 'active', 'select'] }, diff --git a/wax-prosemirror-core/src/config/Config.js b/wax-prosemirror-core/src/config/Config.js index 9ecd54446..b69d732a1 100644 --- a/wax-prosemirror-core/src/config/Config.js +++ b/wax-prosemirror-core/src/config/Config.js @@ -1,5 +1,3 @@ -/* eslint-disable no-unused-vars */ -/* eslint-disable no-underscore-dangle */ import { set, get, isArrayLikeObject } from 'lodash'; import { injectable, inject } from 'inversify'; diff --git a/wax-prosemirror-core/src/config/defaultServices/LayoutService/components/componentPlugin.js b/wax-prosemirror-core/src/config/defaultServices/LayoutService/components/componentPlugin.js index 1fe7a1431..b4fe73103 100644 --- a/wax-prosemirror-core/src/config/defaultServices/LayoutService/components/componentPlugin.js +++ b/wax-prosemirror-core/src/config/defaultServices/LayoutService/components/componentPlugin.js @@ -1,30 +1,8 @@ -/* eslint-disable react/prop-types */ /* eslint-disable react/jsx-props-no-spreading */ -/* eslint-disable no-shadow */ /* eslint-disable react/no-array-index-key */ -/* eslint-disable react/destructuring-assignment */ -import React, { Component } from 'react'; +import React from 'react'; import { useInjection } from '../../../../WaxContext'; -// eslint-disable-next-line no-unused-vars -class UpdateView extends Component { - constructor(props) { - super(props); - - this.state = { - view: this.props.view, - }; - } - - updateView(view) { - this.setState(view); - } - - render() { - return this.props.children({ view: this.state.view }); - } -} - const ComponentPlugin = renderArea => layoutProps => { const { instance } = useInjection('Layout'); diff --git a/wax-prosemirror-core/src/config/defaultServices/MenuService/MenuCollection.js b/wax-prosemirror-core/src/config/defaultServices/MenuService/MenuCollection.js index 8cd01f377..d8109a6cc 100644 --- a/wax-prosemirror-core/src/config/defaultServices/MenuService/MenuCollection.js +++ b/wax-prosemirror-core/src/config/defaultServices/MenuService/MenuCollection.js @@ -1,4 +1,4 @@ -// eslint-disable-next-line no-unused-vars +/* eslint-disable no-unused-vars */ import { injectable, multiInject } from 'inversify'; @injectable() diff --git a/wax-prosemirror-services/src/WaxToolGroups/MultipleChoiceDropDownToolGroupService/MultipleChoiceDropDown.js b/wax-prosemirror-services/src/WaxToolGroups/MultipleChoiceDropDownToolGroupService/MultipleChoiceDropDown.js index 01347bfd5..d63ae4b7e 100644 --- a/wax-prosemirror-services/src/WaxToolGroups/MultipleChoiceDropDownToolGroupService/MultipleChoiceDropDown.js +++ b/wax-prosemirror-services/src/WaxToolGroups/MultipleChoiceDropDownToolGroupService/MultipleChoiceDropDown.js @@ -1,4 +1,3 @@ -/* eslint-disable no-underscore-dangle */ import React, { useMemo } from 'react'; import { injectable, inject } from 'inversify'; import { isEmpty } from 'lodash'; -- GitLab