wax-prosemirror issueshttps://gitlab.coko.foundation/wax/wax-prosemirror/-/issues2020-09-21T09:31:57Zhttps://gitlab.coko.foundation/wax/wax-prosemirror/-/issues/20Fix expand link with track changes2020-09-21T09:31:57ZChristosFix expand link with track changesWhen tracked text exists create link is broken and is not created , if contained or expanded.When tracked text exists create link is broken and is not created , if contained or expanded.https://gitlab.coko.foundation/wax/wax-prosemirror/-/issues/33UI: adding custom styles to a link element2021-07-06T13:06:30Zjulientaqjulien@coko.foundationUI: adding custom styles to a link element
When trying to add a custom inline style to an element with a link, the custom block is hidden below the link preview.
> “an image is better than a long text”
>
> — the bad yannis
![image](/uploads/c52b9e4704bed1be4c174ee817771e...
When trying to add a custom inline style to an element with a link, the custom block is hidden below the link preview.
> “an image is better than a long text”
>
> — the bad yannis
![image](/uploads/c52b9e4704bed1be4c174ee817771efc/image.png)https://gitlab.coko.foundation/wax/wax-prosemirror/-/issues/34Empty element break the export2021-07-29T10:16:21Zjulientaqjulien@coko.foundationEmpty element break the exportI was trying to move an image around in Wax, so i copy pasted the image.
What happened is that it left the caption where is was. So i copied the caption and pasted it in the new figure element.
Which left in place an unselectable / unr...I was trying to move an image around in Wax, so i copy pasted the image.
What happened is that it left the caption where is was. So i copied the caption and pasted it in the new figure element.
Which left in place an unselectable / unremovable `<figure>` empty element.
So wax should definitely removes any empty figure element on save (and it should also be the case for any empty element: it’s useful to have line breaks when creating the content, but it’s unncessary for all the other situations imho)
As a side note, Wax shouldn’t allow empty elements because the designer will need to go and remove them in editoria to have the best controls on the design.
![Image_collée_à_2021-7-29_12-04](/uploads/7fc406a5d11cb71a4d8f672b7ca5cba5/Image_collée_à_2021-7-29_12-04.png)
![image](/uploads/979270b91f95fa7bc1ce63a89e8bef2a/image.png)https://gitlab.coko.foundation/wax/wax-prosemirror/-/issues/36Applying image styles in Wax editor2021-10-11T11:45:40ZRyan Dix-PeekApplying image styles in Wax editor**Description;** currently specific images styling cannot be applied in the Wax editor, only captions can be added.
Use cases:
- Pagination; certain images are required to span the whole page in case of multi-column layouts, and other i...**Description;** currently specific images styling cannot be applied in the Wax editor, only captions can be added.
Use cases:
- Pagination; certain images are required to span the whole page in case of multi-column layouts, and other images remain within a column.
- Push an image into the margin with a class like `.margin-top` or `.margin-bottom`
- When certain images are to be treated in the same way, for example. The opening image of each chapter should take the full width of the page. In this case you'd want to apply a class to the image, e.g. `.chapter-opener` and then define the styles for that class in the stylesheet.
- When you're doing "print refinement" and you want control over an image to improve the layout of the pages, so it's done on a case by case basis. Here's where the float rules come in handy to override the rule that set for all figures
The current solution is to identify images by assigning a custom style using the Wax editor. A proposed solution is to apply a CSS class in Wax so that the CSS template in pagedjs can apply a style targeted to images only.https://gitlab.coko.foundation/wax/wax-prosemirror/-/issues/38Cannot use toolbar to undo ordered lists2021-11-15T05:59:30ZRyan Dix-PeekCannot use toolbar to undo ordered lists**Issue description;** as a user editing a manuscript in Wax clicking on the ordered lists (numbered/bulleted) toolbar plugins to *un-order* list does nothing. If an ordered list is imported or styled as such in Wax the user should be ab...**Issue description;** as a user editing a manuscript in Wax clicking on the ordered lists (numbered/bulleted) toolbar plugins to *un-order* list does nothing. If an ordered list is imported or styled as such in Wax the user should be able to use the ordered list tools to revert the ordered styling to paragraph text.
Reference; [Kotahi repo issue with an example](https://gitlab.coko.foundation/kotahi/kotahi/-/issues/697#note_71473).https://gitlab.coko.foundation/wax/wax-prosemirror/-/issues/44Maths blocks don't work in editor and cause PagedJS output errors2023-06-19T13:11:58ZChristinaTrompMaths blocks don't work in editor and cause PagedJS output errors## Expected behaviour
As in the Ketida (FKA Editoria) docs:
> Insert Mathematical Function, Formula, or Equation as a Block
>
> Follow the above instructions using two dollar signs at the beginning and end of the math in LaTex syntax.
...## Expected behaviour
As in the Ketida (FKA Editoria) docs:
> Insert Mathematical Function, Formula, or Equation as a Block
>
> Follow the above instructions using two dollar signs at the beginning and end of the math in LaTex syntax.
>
> The math will be centered on the page on its own line(s).
## Current behaviour
In the OEN instance and the Wax demo, it's impossible to insert blocks of maths, only inline maths works and the editor interprets blocks of maths as inline maths with another set of dollar signs outside of it.
So the maths doesn’t render properly in the editor, and then an error is generated on output of PagedJS PDF saying ‘ParseError: KaTeX parse error: Can't use function '$' in math mode at position 1’.
## Steps to reproduce
1. Go to Wax demo
2. Type in $$\frac{1}{2}$$ or any basic equation (but don't add a space after the first set of double dollars)
3. See that the maths renders as inline maths with another set of dollars outside of it (see screenshots below)
![Screen_Shot_2022-12-07_at_17.18.33](/uploads/ca7e5962d6aadf30d20fab17c785e8b4/Screen_Shot_2022-12-07_at_17.18.33.png)
![Screen_Shot_2022-12-07_at_17.18.28](/uploads/879b309f084705d6f25a0f637eccb29d/Screen_Shot_2022-12-07_at_17.18.28.png)
4. If you do the same in the OEN instance, on export with one of the templates (e.g. Juans les Pins or Les Angles) you will get an error
![Screen_Shot_2022-12-01_at_16.17.40](/uploads/f7ceb9ac9184b47bb8184542294a9e6b/Screen_Shot_2022-12-01_at_16.17.40.png)
Note the workaround for this is to add a space after you type two sets of dollars and then type your maths. But this isn't ideal because many people will copy paste from a separate maths editor/validator and that doesn't render properly.https://gitlab.coko.foundation/wax/wax-prosemirror/-/issues/45Hitting enter twice should jump out of table's last row onto new line outside...2023-01-16T09:15:01ZChristinaTrompHitting enter twice should jump out of table's last row onto new line outside of table## Expected behaviour
If I have a table at the very end of a section, I should be able to hit Enter twice to exit the table and jump onto a new line. This is needed because if the table is the last thing in the section and I need to add...## Expected behaviour
If I have a table at the very end of a section, I should be able to hit Enter twice to exit the table and jump onto a new line. This is needed because if the table is the last thing in the section and I need to add things below it, at present I can't. You may think the 'Join with above block' button could help here, whereby I could add stuff below the section, and then make it join with the above section, however unless that next line is part of a section itself, it can't be joined into the previous section.
![Screen_Shot_2022-12-07_at_17.31.11](/uploads/aea5f9e96585b599fc8b275a0a0d93a6/Screen_Shot_2022-12-07_at_17.31.11.png)
![Screen_Shot_2022-12-07_at_17.33.50](/uploads/bdee53270d5e3e448e588d766f81ddc7/Screen_Shot_2022-12-07_at_17.33.50.png)
## Current behaviour
If a table is the last thing in my section, there is no way to create a line under the table in that section. Hitting Enter twice just creates more lines in the table.https://gitlab.coko.foundation/wax/wax-prosemirror/-/issues/46Improve support for ordered and unordered lists2023-11-28T09:44:00ZChristinaTrompImprove support for ordered and unordered lists## Context
This issue is duplicated in the Ketida repo https://gitlab.coko.foundation/ketida/ketida/-/issues/574
Currently these are the only two buttons relevant to lists in the Wax editor:
![Screen_Shot_2022-12-12_at_14.26.38](/uplo...## Context
This issue is duplicated in the Ketida repo https://gitlab.coko.foundation/ketida/ketida/-/issues/574
Currently these are the only two buttons relevant to lists in the Wax editor:
![Screen_Shot_2022-12-12_at_14.26.38](/uploads/7d01968552e23a34333b8d5bfaa3090c/Screen_Shot_2022-12-12_at_14.26.38.png)
Currently you can create a very basic nested list in the editor by following these steps:
1. Click the list icon (ordered or unordered) which creates the first item
2. Type some text into the first item
3. Hit enter to get a second item
4. Click the list icon again, to nest the second list item
The problem is, for ordered lists, the resulting list is like this, and the PagedJS templates export this as WYSIWYG where the numbering is the same as in the editor shown below.
![Screen_Shot_2022-12-12_at_13.12.07](/uploads/bdcef63f24044d1c7d49665d71c937a7/Screen_Shot_2022-12-12_at_13.12.07.png)
1. an issue for ordered lists is that if a paragraph or teacher refers to point 1, there are multiple point 1s so it doesn't make sense.
2. another issue is that for ordered and unordered lists is that you can't subsequently create points in the unnested part of the list (in the example above there is no intuitive way to unnest point 3 to make it a continuation of the previous level of the list). The workaround for this in the editor is to create the full unnested list (1, 2, 3), then add nested points within it by hitting enter on the 'parent' item and clicking the list icon again to nest children (nested items) within it, but that's not intuitive in the authoring process because it requires you to create all the 'parent' items first instead of writing the list top to bottom.
3. another issue for ordered lists is the lack of support for roman numerals, alphabetical lists, and other similar list handling which appears in a lot of textbooks.
4. Lastly, it's impossible to continue numbering when the list is split by explanatory paragraphs that are not part of the list.
## Proposal
Add advanced list handling:
- [ ] Dropdown list for types of bullets in unordered lists
- [ ] Dropdown list for types of 'numbers' in ordered lists (like roman numerals; A, B, C etc.)
- [ ] Add 'Continue numbering' and 'Restart numbering' options
- [ ] Add an ident and unindent button that allows you to shift part of the list right (to be nested) and left (to get unnested)
To give further context to how this is handled by other editors (not intended to be copied, rather just for context because it's a common feature in WYSIWYG editors), for example MS Word and Google Docs handle advanced lists like this:
![Screen_Shot_2022-12-12_at_13.27.00](/uploads/2706cc5cc43f2cec34ca0713c0404caa/Screen_Shot_2022-12-12_at_13.27.00.png)
![Screen_Shot_2022-12-12_at_13.20.03](/uploads/2532c9fde280af207454a49fe5e8a206/Screen_Shot_2022-12-12_at_13.20.03.png)
![Screen_Shot_2022-12-12_at_13.19.48](/uploads/d8e9b0d6b0b30bed02284d89afb3ccc7/Screen_Shot_2022-12-12_at_13.19.48.png)
![Screen_Shot_2022-12-12_at_13.19.34](/uploads/f0d9eea6c8d01c87a201bc98574d4f8d/Screen_Shot_2022-12-12_at_13.19.34.png)
## Design
[Include sketch or wireframes of the UI changes necessary for this feature]
## Implementation (if applicable)
[A description of the steps to implement the feature.]
## Alternative approaches (if applicable)
[Include any alternatives to meet this use case.]
## Open issues (if applicable)
[Links to and a discussion of related issues, if applicable.]ChristinaTrompRyan Dix-PeekDione Mentisdione@coko.foundationAdam Hydeadam@coko.foundationChristinaTromphttps://gitlab.coko.foundation/wax/wax-prosemirror/-/issues/47Allow text case change on multiple paragraphs at once2023-11-20T14:38:47ZChristinaTrompAllow text case change on multiple paragraphs at onceThis issue is duplicated in the Ketida repo: https://gitlab.coko.foundation/ketida/ketida/-/issues/575
## Context
In the Wax editor there are four text-case change symbols:
1. Uppercase
2. Lower case
3. Sentence case
4. Title case
If...This issue is duplicated in the Ketida repo: https://gitlab.coko.foundation/ketida/ketida/-/issues/575
## Context
In the Wax editor there are four text-case change symbols:
1. Uppercase
2. Lower case
3. Sentence case
4. Title case
If you select a word or paragraph and click the symbol, you get the desired text change, but this doesn't work on multiple paragraphs.
A nice to have would be to be able to change the case of multiple paragraphs at once. For example if I’m copy pasting an entire page or chapter into the editor in all caps and need to make it sentence case.
## Proposal
Allow text case change on multiple paragraphs at once.
## Design
[Include sketch or wireframes of the UI changes necessary for this feature]
## Implementation (if applicable)
[A description of the steps to implement the feature.]
## Alternative approaches (if applicable)
[Include any alternatives to meet this use case.]
## Open issues (if applicable)
[Links to and a discussion of related issues, if applicable.]https://gitlab.coko.foundation/wax/wax-prosemirror/-/issues/48When searching, allow user to go back to results past 0 (last result)2023-11-20T14:38:23ZChristinaTrompWhen searching, allow user to go back to results past 0 (last result)This issue is duplicated in the Ketida repo: https://gitlab.coko.foundation/ketida/ketida/-/issues/576
## Context
The Ketida and OEN versions of the Wax editor have a useful search feature. How it currently works is that I click the se...This issue is duplicated in the Ketida repo: https://gitlab.coko.foundation/ketida/ketida/-/issues/576
## Context
The Ketida and OEN versions of the Wax editor have a useful search feature. How it currently works is that I click the search icon or ctrl F (cmd F on Mac) and type or copy paste text to find into the search bar. The number of results are then shown and I can cycle forwards to each result by clicking the next button:
![Screen_Shot_2022-12-14_at_11.51.45](/uploads/f46aa804ccd3dea562b8c12d1bd6e2df/Screen_Shot_2022-12-14_at_11.51.45.png)
What if I have 200 results in a chapter and I know the result I'm looking for is near the end? It would be useful to go to result 200 first, and cycle backwards. Currently, even though the previous button looks clickable when you're at result 0 or 1, clicking the previous button doesn't result in a change in the editor. In the case of 200 results, at position 0 or 1 I would expect to go back to result 200 by clicking the previous button.
A workaround for this use case, is to put your cursor lower down in the chapter and cycle forwards with the search bar to see only results near the end of the chapter. But cycling backwards past 0 is a nice feature if possible.
To elevate this further, to make the search feature more keyboard friendly, allow Ctrl G (and Cmd G on Mac) to cycle to the next result, and Shift Ctrl G (Shift Cmd G on Mac) to go to the previous result. (By the way, Windows and Linux people please confirm the shortcuts usual practice in browsers and text editors on because I'm not sure.)
## Proposal
1. At the top of a document the user presses Ctrl F
2. The total number of results are shown
3. If they click previous they go to the last result
4. The usual forward and backwards functions still apply, but allow Ctrl G (and Cmd G on Mac) to cycle to the next result, and Shift Ctrl G (Shift Cmd G on Mac) to go to the previous result
## Design
[Include sketch or wireframes of the UI changes necessary for this feature]
## Implementation (if applicable)
[A description of the steps to implement the feature.]
## Alternative approaches (if applicable)
[Include any alternatives to meet this use case.]
## Open issues (if applicable)
[Links to and a discussion of related issues, if applicable.]https://gitlab.coko.foundation/wax/wax-prosemirror/-/issues/50Add regex search to find and replace2023-11-20T14:37:29ZChristinaTrompAdd regex search to find and replaceThis issue is duplicated in the Ketida repo: https://gitlab.coko.foundation/ketida/ketida/-/issues/586
<!-- Required. Provide a general summary of the issue in the title above -->
## Context
Regex search is so incredibly useful for th...This issue is duplicated in the Ketida repo: https://gitlab.coko.foundation/ketida/ketida/-/issues/586
<!-- Required. Provide a general summary of the issue in the title above -->
## Context
Regex search is so incredibly useful for the editorial process. Especially in OEN when authoring and editing is expected to be done in the editor. For example it's amazing for an editor to be able to find all four digit numbers separated by a hyphen with any four digits following them, to help make sure all dates are separated by an En dash instead of a hyphen. 6 hours just turned into 30 minutes of work.
There are many other examples where regex is amazing and I'm sure in time more and more editors will become acquainted with it.
## Proposal
Add regex search and replace to the editor find and replace, which can be turned off and on. By default it's off.
Add basic regex guidance in the docs.
## Design
<!-- Include sketches or wireframes of the UI suggested for this feature -->
## Implementation (if applicable)
<!-- A description of the steps to implement the feature.-->
## Alternative approaches (if applicable)
<!-- Include any alternatives to meet this use case. -->
<!-- After creating this issue you can link other related or blocking issues with the Gitlab's Linked issues functionality. -->https://gitlab.coko.foundation/wax/wax-prosemirror/-/issues/52Deprecation of componentWillReceiveProps2023-11-20T14:35:26ZKevin WellerDeprecation of componentWillReceivePropsReceiving the following warnings when running the demos, suggesting the component will stop working properly under future versions of React:
```
react-dom.development.js:88 Warning: componentWillReceiveProps has been renamed, and is not...Receiving the following warnings when running the demos, suggesting the component will stop working properly under future versions of React:
```
react-dom.development.js:88 Warning: componentWillReceiveProps has been renamed, and is not recommended for use. See https://fb.me/react-unsafe-component-lifecycles for details.
* Move data fetching code or side effects to componentDidUpdate.
* If you're updating state whenever props change, refactor your code to use memoization techniques or move it to static getDerivedStateFromProps. Learn more at: https://fb.me/react-derived-state
* Rename componentWillReceiveProps to UNSAFE_componentWillReceiveProps to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.
Please update the following components: Dropdown
printWarning @ react-dom.development.js:88
warn @ react-dom.development.js:51
push.../../node_modules/react-dom/cjs/react-dom.development.js.ReactStrictModeWarnings.flushPendingUnsafeLifecycleWarnings @ react-dom.development.js:11377
flushRenderPhaseStrictModeWarningsInDEV @ react-dom.development.js:23112
commitRootImpl @ react-dom.development.js:22396
unstable_runWithPriority @ scheduler.development.js:653
runWithPriority$1 @ react-dom.development.js:11039
commitRoot @ react-dom.development.js:22381
finishSyncRender @ react-dom.development.js:21807
performSyncWorkOnRoot @ react-dom.development.js:21793
(anonymous) @ react-dom.development.js:11089
unstable_runWithPriority @ scheduler.development.js:653
runWithPriority$1 @ react-dom.development.js:11039
flushSyncCallbackQueueImpl @ react-dom.development.js:11084
flushSyncCallbackQueue @ react-dom.development.js:11072
flushPassiveEffectsImpl @ react-dom.development.js:22883
unstable_runWithPriority @ scheduler.development.js:653
runWithPriority$1 @ react-dom.development.js:11039
flushPassiveEffects @ react-dom.development.js:22820
(anonymous) @ react-dom.development.js:22699
workLoop @ scheduler.development.js:597
flushWork @ scheduler.development.js:552
performWorkUntilDeadline @ scheduler.development.js:164
react_devtools_backend.js:4012 Warning: componentWillReceiveProps has been renamed, and is not recommended for use. See https://fb.me/react-unsafe-component-lifecycles for details.
* Move data fetching code or side effects to componentDidUpdate.
* If you're updating state whenever props change, refactor your code to use memoization techniques or move it to static getDerivedStateFromProps. Learn more at: https://fb.me/react-derived-state
* Rename componentWillReceiveProps to UNSAFE_componentWillReceiveProps to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.
Please update the following components: PanelGroup
```https://gitlab.coko.foundation/wax/wax-prosemirror/-/issues/56Suggesting mode doesn't work properly when deleting a lot of content at once2023-11-20T14:13:17ZChristinaTrompSuggesting mode doesn't work properly when deleting a lot of content at once<!-- Required. Provide a general summary of the issue in the title above -->
Duplicated in Ketida repo here: https://gitlab.coko.foundation/ketida/ketida/-/issues/627
## Expected behaviour
You should be able to suggest to delete an h2...<!-- Required. Provide a general summary of the issue in the title above -->
Duplicated in Ketida repo here: https://gitlab.coko.foundation/ketida/ketida/-/issues/627
## Expected behaviour
You should be able to suggest to delete an h2, followed by a list, followed by 3 paragraphs, followed by another list, all at once, using suggesting mode.
## Current behaviour
When you try to delete an h2, followed by a list, followed by 3 paragraphs, followed by another list, all at once, using suggesting mode, the content jumps on the page and isn't tracked as a suggested tracked deletion.
## Steps to reproduce
<!-- Required. Provide a link to a live example or screenshots, and the steps to reproduce this bug.]-->
1. Go to Ketida into any component
2. Add and style the following content properly using heading formatting and list items (or see [this chapter](https://ketida.cloud68.co/books/ec5d7ab2-d54a-4210-b7cc-94b4840f584a/bookComponents/66d32dda-b959-4378-93b3-87780a792bc0) which contains that content)
```
### A heading for my book
- A list oitem
- Another one
Lorem ipsum dolor sit amet, consectetur adipiscing elit. Sed in orci et mi euismod malesuada vel quis nunc. Phasellus facilisis ultrices auctor. Quisque vulputate a dolor a malesuada. Pellentesque nec sapien ligula. Quisque sed fermentum lacus, vel laoreet tortor. Nunc eu facilisis turpis. In sit amet quam et est sodales venenatis eget quis nunc. Etiam vel fermentum tellus.
Nullam vel ligula at sapien mollis elementum. Maecenas mattis elementum leo, ut mattis magna tristique eu. Quisque auctor enim sit amet purus posuere faucibus. Sed facilisis justo lectus, fermentum sodales nisl cursus nec. Mauris sit amet accumsan enim. Proin tempus magna vel nisi tincidunt consequat. Aenean dictum justo urna, ac hendrerit metus volutpat a.
Maecenas non lacus at risus aliquet fringilla. Integer elementum ante gravida, rutrum turpis vitae, porttitor est. Etiam vel nulla ac tortor varius egestas. Vestibulum risus diam, tincidunt quis sapien sit amet, pulvinar feugiat eros. Donec eu diam sit amet nisl tincidunt interdum. Vestibulum ante ipsum primis in faucibus orci luctus et ultrices posuere cubilia curae; Vestibulum pharetra condimentum neque ut lobortis. Etiam accumsan vehicula ligula quis iaculis. Vestibulum consequat nulla sit amet varius porttitor. Integer a ante sodales, dictum ligula id, sodales est. Phasellus at quam ut quam cursus pellentesque. Pellentesque facilisis hendrerit mi ac pellentesque.
- Lorem ipsum dolor sit amet, consectetur adipiscing elit. Sed in orci et mi euismod malesuada vel quis nunc. Phasellus facilisis ultrices auctor. Quisque vulputate a dolor a malesuada. Pellentesque nec sapien ligula. Quisque sed fermentum lacus, vel laoreet tortor. Nunc eu facilisis turpis. In sit amet quam et est sodales venenatis eget quis nunc. Etiam vel fermentum tellus.
- Nullam vel ligula at sapien mollis elementum. Maecenas mattis elementum leo, ut mattis magna tristique eu. Quisque auctor enim sit amet purus posuere faucibus. Sed facilisis justo lectus, fermentum sodales nisl cursus nec. Mauris sit amet accumsan enim. Proin tempus magna vel nisi tincidunt consequat. Aenean dictum justo urna, ac hendrerit metus volutpat a.
```
3. Toggle on suggesting mode
4. Select all that content and backspace
5. See that it isn't deleted
## Environment
MacOS in Chrome.
## Possible solution
<!-- If known, provide details on how to fix the bug.-->
<!-- After creating this issue you can link other related or blocking issues with the Gitlab's Linked issues functionality. -->https://gitlab.coko.foundation/wax/wax-prosemirror/-/issues/67Allow enter x 2 to get out of image caption onto next line (Ketida 1, OEN ver...2023-11-20T14:35:05ZChristinaTrompAllow enter x 2 to get out of image caption onto next line (Ketida 1, OEN version, for images that are part of a section or part of a pedagogical element)<!-- Required. Provide a general summary of the issue in the title above -->
## Expected behaviour
In general enter x 2 allows you to get out of the current section or block. This should work for image captions as well.
## Current be...<!-- Required. Provide a general summary of the issue in the title above -->
## Expected behaviour
In general enter x 2 allows you to get out of the current section or block. This should work for image captions as well.
## Current behaviour
When I am in an image caption, enter x 2 does not work to get out of it, I have to click on the image above and use enter x 2 to get out. It does work correctly for images that are not part of any section or pedagogical element after the recent changes made to fix this, but still doesn't work in oen for images that are part of a section or part of a pedagogical element.
## Steps to reproduce
<!-- Required. Provide a link to a live example or screenshots, and the steps to reproduce this bug.]-->
1. Go into the OEN instance of Ketida
2. Go into a component of any book and make sure you're in a section or pedagogical element
3. Upload an image and insert it
4. Give the image a caption
5. Try Enter x 2 to get out of the caption onto the next line, see that it doesn't work
6. If you have sections below the image, you can simply click on them. But this doesn't work if you don't have a section or new line below the image already. Alternatively you can click on the image and Enter x 2 to get onto the next line below the caption. But enter x 2 to get out of the caption would be ideal.
## Environment
Mac 10.12. Chrome Version 103.0.5060.134 (Official Build) (x86_64)
## Possible solution
<!-- If known, provide details on how to fix the bug.-->
<!-- After creating this issue you can link other related or blocking issues with the Gitlab's Linked issues functionality. -->https://gitlab.coko.foundation/wax/wax-prosemirror/-/issues/68Suggesting mode sometimes doesn't track delete (can't reproduce consistently)2023-11-20T14:13:25ZChristinaTrompSuggesting mode sometimes doesn't track delete (can't reproduce consistently)<!-- Required. Provide a general summary of the issue in the title above -->
Created in the Ketida repo in https://gitlab.coko.foundation/ketida/ketida/-/issues/644
The Kotahi team also reported this issue but seemed to resolve it in h...<!-- Required. Provide a general summary of the issue in the title above -->
Created in the Ketida repo in https://gitlab.coko.foundation/ketida/ketida/-/issues/644
The Kotahi team also reported this issue but seemed to resolve it in https://gitlab.coko.foundation/kotahi/kotahi/-/merge_requests/857/diffs
## Expected behaviour
Show crossed out line over deleted area
## Current behaviour
Sometimes, when you highlight text and press backspace while in suggesting mode, the deletion isn't tracked
## Steps to reproduce
<!-- Required. Provide a link to a live example or screenshots, and the steps to reproduce this bug.]-->
1. Go into a book
2. Add text in editing mode
3. Turn on suggesting mode
4. Highlight some text and press backspace
5. See the text isn't crossed out, it just gets deleted
6. Note this behaviour is not consistently reproducible but needs investigating because it's problematic
See attached video
![tracked-delete-not-working](/uploads/0713c3d024eb492c6b5359191ea779bd/tracked-delete-not-working.mov)
## Environment
MacOS using Chrome on the OEN test instance
## Possible solution
<!-- If known, provide details on how to fix the bug.-->
<!-- After creating this issue you can link other related or blocking issues with the Gitlab's Linked issues functionality. -->https://gitlab.coko.foundation/wax/wax-prosemirror/-/issues/69Don't delete empty blocks on Enter2023-11-20T14:33:59ZChristinaTrompDon't delete empty blocks on Enter<!-- Required. Provide a general summary of the issue in the title above -->
Created in the Ketida repo in: https://gitlab.coko.foundation/ketida/ketida/-/issues/561
## Context
In the book editor, if I click on an element in the left, ...<!-- Required. Provide a general summary of the issue in the title above -->
Created in the Ketida repo in: https://gitlab.coko.foundation/ketida/ketida/-/issues/561
## Context
In the book editor, if I click on an element in the left, for example Key questions, it creates a Key questions section. Then if I hit Enter to get out of the Key questions block, the section is removed if I didn’t already add content. As a user I want to leave the section blank for now and come back to it. The user can always backspace to intentionally remove the section.
A related issue is logged in https://gitlab.coko.foundation/ketida/ketida/-/issues/580
## Proposal
Don’t delete empty blocks on enter. The way to delete an empty section or block will be to backspace to intentionally remove the section.
## Design
<!-- Include sketches or wireframes of the UI suggested for this feature -->
## Implementation (if applicable)
<!-- A description of the steps to implement the feature.-->
## Alternative approaches (if applicable)
<!-- Include any alternatives to meet this use case. -->
<!-- After creating this issue you can link other related or blocking issues with the Gitlab's Linked issues functionality. -->https://gitlab.coko.foundation/wax/wax-prosemirror/-/issues/78fileUpload not triggered when image is copy pasted into wax2023-11-20T14:32:40ZGrigor MalofileUpload not triggered when image is copy pasted into waxImages that are pasted into the editor are not uploaded via the fileUpload handler. This is causing issues when trying to export the content of the editor in different formats, because there is no fileId attribute and no url from where t...Images that are pasted into the editor are not uploaded via the fileUpload handler. This is causing issues when trying to export the content of the editor in different formats, because there is no fileId attribute and no url from where to download the image
## Expected behaviour
When pasting an image, it should trigger the fileUpload handler, same as when adding images via the toolbar button
## Current behaviour
Images that are pasted are not uploaded. Instead, a base64 string is saved as the src of the image object
## Steps to reproduce
The bug was observed in the hhmi project
1. copy an image in the file system
2. paste it inside the editor
4. in the editor content object, a base64 string is stored as the image src
3. no image upload happens
## Environment
Any browser
## Possible solution
Either the pasting of images should be blocked, or it should trigger the upload process just as adding images via the toolbar button does
<!-- After creating this issue you can link other related or blocking issues with the Gitlab's Linked issues functionality. -->https://gitlab.coko.foundation/wax/wax-prosemirror/-/issues/79math equations can be wider than Wax width2023-11-20T14:37:54ZDan Viselmath equations can be wider than Wax widthFrom this Kotahi issue: https://gitlab.coko.foundation/kotahi/kotahi/-/issues/1397
We have an issue where someone has a malformed LaTeX in a `<math-display` element:
![Screenshot_2023-09-13_at_14-16-12_Kotahi\_-\_open_journals.png](/u...From this Kotahi issue: https://gitlab.coko.foundation/kotahi/kotahi/-/issues/1397
We have an issue where someone has a malformed LaTeX in a `<math-display` element:
![Screenshot_2023-09-13_at_14-16-12_Kotahi\_-\_open_journals.png](/uploads/ae9ad973b85af274fa743e3c05f92573/Screenshot_2023-09-13_at_14-16-12_Kotahi_-_open_journals.png)There's a pretty clear import issue going on (those `delta`s should probably be `\delta` which would make the Greek letter, which would make the width of this much less. But if you go to the Wax demo and try typing in a long equation:
![Screenshot 2023-09-14 at 1.00.53 PM.png](/uploads/31eb9b32cef3c5c41aff105450ae263f/Screenshot_2023-09-14_at_1.00.53_PM.png)You can see that this is a Wax issue:
![Screenshot 2023-09-14 at 1.01.05 PM.png](/uploads/6bbc88ce68cd47bd443ec058c18eb948/Screenshot_2023-09-14_at_1.01.05_PM.png)Adding a bit of CSS fixes this:
```plaintext
math-display {
max-width: 100%;
overflow-x: auto;
}
```
(We can add that in Kotahi, but it seems like that should be added into `MathService/math.css`.)
I think this is effectively a problem with MathJax: it doesn't seem like it sets a max-width for equations: https://groups.google.com/g/mathjax-users/c/Ou0csmewIr8 – in https://gitlab.coko.foundation/wax/wax-prosemirror/-/blob/master/wax-prosemirror-services/src/MathService/plugins/math-nodeview.js#L198 there's a `containerWidth` of 700 being set for MathJax, but it's not respecting that.https://gitlab.coko.foundation/wax/wax-prosemirror/-/issues/88Change Replace button styling, to look like it's enabled2024-02-12T11:53:44ZChristinaTrompChange Replace button styling, to look like it's enabled## Expected behavior
The Replace button should have appropriate styling, currently it's light grey which is the style of buttons that are not enabled.
## Current behavior
The Replace button is greyed out
## Steps to reproduce
![Scre...## Expected behavior
The Replace button should have appropriate styling, currently it's light grey which is the style of buttons that are not enabled.
## Current behavior
The Replace button is greyed out
## Steps to reproduce
![Screen_Shot_2023-10-30_at_11.10.07](/uploads/d4a689146ca260103334a10d5fce50cd/Screen_Shot_2023-10-30_at_11.10.07.png)
1. Go to a book in Ketida
1. Click the find and replace icon
1. Type in a find term (that exists in the document)
1. See that the replace button is greyed out
## Environment
Chrome and Firefox
## Possible solution
[Not required. Suggest a fix for the bug]Week 46 and 47Dione Mentisdione@coko.foundationDione Mentisdione@coko.foundationhttps://gitlab.coko.foundation/wax/wax-prosemirror/-/issues/92Chapter appears untitled after uploading image right before title2023-11-20T14:30:41ZBela TociChapter appears untitled after uploading image right before titleIn the editor, when an image is uploaded just before the title of a chapter, the chapter appears untitled in the left panel of producer page, even though there is some text with a heading 1 that should serve as the title.
## Expected be...In the editor, when an image is uploaded just before the title of a chapter, the chapter appears untitled in the left panel of producer page, even though there is some text with a heading 1 that should serve as the title.
## Expected behavior
The chapter should have the correct title based on the text formatted with heading 1. The presence of an image should not affect the title.
## Current behavior
Inserting an image just before the title causes the chapter to appear untitled, even though there is text with heading 1 that should serve as the title.
## Steps to reproduce
1. Create a new chapter and title it or go to an existing titled chapter
2. Place the cursor just before the title text, where the title is formatted with heading 1 and upload an image
3. Observe that in the left panel the chapter now appears as 'Untitled Chapter' (as in the screenshot below)
![image](/uploads/a6539c5a6603bd8acefb7d2f9d60c22d/image.png)
## Environment
[Provide browser name and version and if you're working from a PC or Mac]
## Possible solution
[Not required. Suggest a fix for the bug]Dione Mentisdione@coko.foundationDione Mentisdione@coko.foundation