wax issueshttps://gitlab.coko.foundation/wax/wax/-/issues2017-12-09T14:07:04Zhttps://gitlab.coko.foundation/wax/wax/-/issues/97Move "Take me back to the editor" up on Wax exit screen2017-12-09T14:07:04ZAlex ThegMove "Take me back to the editor" up on Wax exit screenThe editors both agree that the "Take me back to the editor" option on the Wax exit screen is too far separated from the other two options (quit & save and quit without saving), making it easy to miss. They don't naturally look all the w...The editors both agree that the "Take me back to the editor" option on the Wax exit screen is too far separated from the other two options (quit & save and quit without saving), making it easy to miss. They don't naturally look all the way to bottom of the screen for their options, since they expect them all to be presented more tightly grouped.
![Screen_Shot_2017-12-08_at_1.34.55_PM](/uploads/c7aa0e55ffa11eed53aa1a3f0329da6b/Screen_Shot_2017-12-08_at_1.34.55_PM.png)
They'd be fine if the "quit" options were still grouped and there was a bit of separation between those two and the "Take me back to the editor" option, although this isn't particularly important to them.https://gitlab.coko.foundation/wax/wax/-/issues/94Keyboard Shortcuts doesn't work when you are on ReadOnly Mode2017-11-28T18:32:50ZGiannis Kopanasjkopanas@gmail.comKeyboard Shortcuts doesn't work when you are on ReadOnly Modehttps://gitlab.coko.foundation/wax/wax/-/issues/93Possible to invisibly select 2 text blocks instead of 1, causing styling errors2017-11-28T18:30:50ZAlex ThegPossible to invisibly select 2 text blocks instead of 1, causing styling errorsIn Wax, it's possible to invisibly select the block of text following the visible selection. This can cause styling to be unintentionally applied to two blocks instead of one.
To reproduce:
* Open a chapter in Wax
* Click inside a text ...In Wax, it's possible to invisibly select the block of text following the visible selection. This can cause styling to be unintentionally applied to two blocks instead of one.
To reproduce:
* Open a chapter in Wax
* Click inside a text block and drag with the mouse to select text. Select through the end of the block, and move the cursor down to be level with the first line of the next text block. Keep the cursor off to the left-hand side, but don't select any text from the 2nd text block, like this:
![cursor_drag](/uploads/efccd6ec66a6b68e5fd0429035f02a33/cursor_drag.png)
* Change the styling
Expected: the new styling will be applied to the top text block with visible selection
Actual: both the top block and the following block reflect the new styling.
It doesn't appear possible to do the same thing with a preceding text block: selecting by clicking and dragging, then moving the cursor up to the end of the preceding line creates a visible grey selection.https://gitlab.coko.foundation/wax/wax/-/issues/87Set up performance testing2017-11-13T22:09:28ZYannis BarlasSet up performance testinghttps://gitlab.coko.foundation/wax/wax/-/issues/86RFC Convert custom HTML tags to generic ones2017-11-30T09:18:12ZYannis BarlasRFC Convert custom HTML tags to generic onesThis means that what got written in the HTML as `<comment>` for example, will be turned into something along the lines of `<span data-type="comment">`.
The aim is to have HTML that is interoperable with epub, as well as other systems ...This means that what got written in the HTML as `<comment>` for example, will be turned into something along the lines of `<span data-type="comment">`.
The aim is to have HTML that is interoperable with epub, as well as other systems to some extent, without the burden of maintaining a separate converter from our custom HTML to a universally valid one.
Some concerns:
* Conforming the HTML output to epub specs (2.1 vs 3?)
* Being friendly to .mobi files if possible
* Try to give semantic meaning where possiblehttps://gitlab.coko.foundation/wax/wax/-/issues/85Comments intermediate state2017-12-02T09:39:26ZYannis BarlasComments intermediate stateWe should have an intermediate state in comments, where something has been written, but not submitted.
This should keep the comment active, even if the selection goes away from the annotation.
If the page is reloaded, non-submitted c...We should have an intermediate state in comments, where something has been written, but not submitted.
This should keep the comment active, even if the selection goes away from the annotation.
If the page is reloaded, non-submitted comments are lost.
This should work in a similar fashion to google docs comments, for a UI reference.
Some changes are needed in the way we handle comments to enable this.
Off the top of my head, we should allow for multiple active comments, but I'm sure more will come up.https://gitlab.coko.foundation/wax/wax/-/issues/83Long discussions in comments2017-10-31T13:11:42Zjulientaqjulien@coko.foundationLong discussions in commentsWhen you have a long discussion in the comments, if you want to read the discussion, you scroll down, and you loses the paragraph you're talking about.
I'm wondering what benefits we could get from separating the scroll of a discussion f...When you have a long discussion in the comments, if you want to read the discussion, you scroll down, and you loses the paragraph you're talking about.
I'm wondering what benefits we could get from separating the scroll of a discussion from the scroll of the content WHEN a comment is active.
Limiting the `max-height` of a discussion and adding `overflow scroll-Y` should be enough to test it.https://gitlab.coko.foundation/wax/wax/-/issues/81Resolved Comment2018-01-21T01:24:47ZChristosResolved CommentResolved comment should hold the comment conversation, in order to revert it if needed. If that's not the case we do not need a resolved comment annotation in the first place.Resolved comment should hold the comment conversation, in order to revert it if needed. If that's not the case we do not need a resolved comment annotation in the first place.https://gitlab.coko.foundation/wax/wax/-/issues/79[RFC] Complex list2017-10-31T18:11:28Zjulientaqjulien@coko.foundation[RFC] Complex listTo follow up the discussion about list (#79)
----
Handling lists is a complex issue. When it's only a small list of text, it's pretty easy. Problems come from multiple paragraphs as a single item of the list (for example):
````html
...To follow up the discussion about list (#79)
----
Handling lists is a complex issue. When it's only a small list of text, it's pretty easy. Problems come from multiple paragraphs as a single item of the list (for example):
````html
<li>blah</li>
````
vs
````html
<li>
<p>blah</p>
<p>blah</p>
</li>
````
The `li` and `ul` element are at a higher level in the dom.
In this case, you dont replace a paragraph with a `li`, you surround it with a `li`. And the numbering comes from those semantics.
Options:
- create a ADD TO ITEM button, only appearing after the last element of the `<li>`, which would let you add element to an item (images, table, other paragraph);
![listExample](/uploads/20b5a13888855685cd41b178d9b2d4e3/listExample.png)
This UI is just for example, as it needs more work, but the idea is to keep the list builder simple and the action near the spot where it will change things in the editor.
An exemple of how it can be made is [Prosemirror](http://prosemirror.net/) has some interesting elements concatenation that may be a way to do it: wrap paragraph into block level element (list, div, figure) which is an interesting way to do it, usability in mind.https://gitlab.coko.foundation/wax/wax/-/issues/77Rules for list merging2017-10-25T20:48:52ZYannis BarlasRules for list mergingWe need to come up with some rules for the ways lists are merged with each other.
For example, let's say you have two adjacent numbered lists:
```
1. something
1. anything
2. everything
```
If you select the two 1's right now, you en...We need to come up with some rules for the ways lists are merged with each other.
For example, let's say you have two adjacent numbered lists:
```
1. something
1. anything
2. everything
```
If you select the two 1's right now, you end up with the following:
```
1. something
2. anything
1. everything
```
So a new list was created out of the selection, but it could be argued that the lists should be merged.
Let's investigate examples for this and see what makes sense.https://gitlab.coko.foundation/wax/wax/-/issues/76RFC Wax components and conversion to HTML2017-10-25T20:28:37ZYannis BarlasRFC Wax components and conversion to HTMLWe need to investigate the possibility of wax components defining their own rules for converting to plain valid HTML (eg. for use in epub).
Maintaining the components and the converter separately makes little sense.
Will come back a...We need to investigate the possibility of wax components defining their own rules for converting to plain valid HTML (eg. for use in epub).
Maintaining the components and the converter separately makes little sense.
Will come back at some point with a proposal, but comments more than welcome in the meantime.https://gitlab.coko.foundation/wax/wax/-/issues/75Inserting image in list deletes the whole list2017-10-25T20:24:48ZYannis BarlasInserting image in list deletes the whole list* Make a bullet list
* Leave the last item empty and put the cursor in there
* Insert an image
* Whole list is now gone
This is actually a substance bug, but we might be able to intercept (or at least report / fix upstream).* Make a bullet list
* Leave the last item empty and put the cursor in there
* Insert an image
* Whole list is now gone
This is actually a substance bug, but we might be able to intercept (or at least report / fix upstream).https://gitlab.coko.foundation/wax/wax/-/issues/72Multi-block list tranformations & cursor position2017-10-25T20:16:26ZYannis BarlasMulti-block list tranformations & cursor positionWhen selecting lists among other blocks and make a transaction, the selection gets lost.
This has to do with substance's `toggleList` not returning anything.
But let's investigate a solution to that, as it's a bit jarring as far as U...When selecting lists among other blocks and make a transaction, the selection gets lost.
This has to do with substance's `toggleList` not returning anything.
But let's investigate a solution to that, as it's a bit jarring as far as UX is concerned.https://gitlab.coko.foundation/wax/wax/-/issues/71Add a comment that spans multiple blocks2017-10-25T20:10:12ZYannis BarlasAdd a comment that spans multiple blockshttps://gitlab.coko.foundation/wax/wax/-/issues/69Find / Find & Replace2018-05-20T14:57:30ZYannis BarlasFind / Find & ReplaceWe need this functionality, but it's not worth implementing, as it's already in substance's latest version.
Will close this when we upgrade and check that all works well.
UCP's shortcut suggestions were:
* `CTRL+F` for find/replace
* ...We need this functionality, but it's not worth implementing, as it's already in substance's latest version.
Will close this when we upgrade and check that all works well.
UCP's shortcut suggestions were:
* `CTRL+F` for find/replace
* `CTRL+G`/`CTRL+SHIFT+G` for find next/previousWeekly 21ChristosChristoshttps://gitlab.coko.foundation/wax/wax/-/issues/67Use react-router's Prompt for confirmation message2017-12-22T18:00:46ZAlf EatonUse react-router's Prompt for confirmation messageNow that PubSweet apps are using `react-router` v4 and `history` v4, the `history.listenBefore` method is no longer available.
Instead, use [react-router's `Prompt` component](https://reacttraining.com/react-router/core/api/Prompt) to c...Now that PubSweet apps are using `react-router` v4 and `history` v4, the `history.listenBefore` method is no longer available.
Instead, use [react-router's `Prompt` component](https://reacttraining.com/react-router/core/api/Prompt) to conditionally show a message when leaving the editor.https://gitlab.coko.foundation/wax/wax/-/issues/59[wax-pubsweet] Move dependencies to peerDependencies2017-10-09T11:13:42ZAlf Eaton[wax-pubsweet] Move dependencies to peerDependenciesPubSweet components use `peerDependencies` for things like `pubsweet-client`, `react`, `react-redux` and `redux`, which helps to avoid multiple versions of the same package being installed.PubSweet components use `peerDependencies` for things like `pubsweet-client`, `react`, `react-redux` and `redux`, which helps to avoid multiple versions of the same package being installed.Yannis BarlasYannis Barlashttps://gitlab.coko.foundation/wax/wax/-/issues/55RFC: Keep save button always enabled2018-01-05T13:13:17ZYannis BarlasRFC: Keep save button always enabledThere is a weird UX behaviour where I could:
* start with the save button disabled
* write something, which would enable the save button
* click on save, which would disable it again
* undo
This last undo, will revert to the previous ...There is a weird UX behaviour where I could:
* start with the save button disabled
* write something, which would enable the save button
* click on save, which would disable it again
* undo
This last undo, will revert to the previous state, but will not re-enable the save button, leaving you with no way to save unless you write something again.
Might be easier said than done, but I think it is worth investigating how to allow the user to always be able to save.https://gitlab.coko.foundation/wax/wax/-/issues/53Editor should accept scroll to links from other components2017-09-20T14:30:58ZYannis BarlasEditor should accept scroll to links from other componentsIn a page where the editor is not the only component, the user might want to be able to click on a link outside of the editor, which would scroll the content to the link's id (given it's found).
The editor should provide a graceful way...In a page where the editor is not the only component, the user might want to be able to click on a link outside of the editor, which would scroll the content to the link's id (given it's found).
The editor should provide a graceful way to handle this.https://gitlab.coko.foundation/wax/wax/-/issues/52Add purple numbers2018-04-23T16:16:19ZYannis BarlasAdd purple numbersThere should be an option to have purple tags in the editor.
@julientaq do you want to paste an image of your design for this?There should be an option to have purple tags in the editor.
@julientaq do you want to paste an image of your design for this?