wax issueshttps://gitlab.coko.foundation/wax/wax/-/issues2018-05-04T18:31:06Zhttps://gitlab.coko.foundation/wax/wax/-/issues/40Tracking formatting changes UI2018-05-04T18:31:06ZYannis BarlasTracking formatting changes UIWe need to think of what the UI is gonna be for styling changes, both inline and block-level.
The challenge is to have them be consistent with the current design, but at the same time different enough so that they wouldn't be confused ...We need to think of what the UI is gonna be for styling changes, both inline and block-level.
The challenge is to have them be consistent with the current design, but at the same time different enough so that they wouldn't be confused for a tracked addition.
On a functional level, we currently have two types of changes ("add" and "delete"), so we'd probably need to introduce more, so that on accepting something, only the style is removed.Weekly 18julientaqjulien@coko.foundationjulientaqjulien@coko.foundationhttps://gitlab.coko.foundation/wax/wax/-/issues/69Find / Find & Replace2018-05-20T14:57:30ZYannis BarlasFind / Find & ReplaceWe need this functionality, but it's not worth implementing, as it's already in substance's latest version.
Will close this when we upgrade and check that all works well.
UCP's shortcut suggestions were:
* `CTRL+F` for find/replace
* ...We need this functionality, but it's not worth implementing, as it's already in substance's latest version.
Will close this when we upgrade and check that all works well.
UCP's shortcut suggestions were:
* `CTRL+F` for find/replace
* `CTRL+G`/`CTRL+SHIFT+G` for find next/previousWeekly 21ChristosChristoshttps://gitlab.coko.foundation/wax/wax/-/issues/152Set up testing scripts2018-04-23T17:15:29ZYannis BarlasSet up testing scriptsNot the tests themselves, but the setup to enable them.Not the tests themselves, but the setup to enable them.LandingChristosChristoshttps://gitlab.coko.foundation/wax/wax/-/issues/128Internationalization and Non-Western Character Set Support2018-04-23T17:17:08ZErich van RijnInternationalization and Non-Western Character Set SupportWhat would it take to add keyboard support for non-western character sets and diacritics either on an ad hoc basis, or permanently? The question was raised in author/copyeditor testing of Editoria. This is a low-priority issue since we...What would it take to add keyboard support for non-western character sets and diacritics either on an ad hoc basis, or permanently? The question was raised in author/copyeditor testing of Editoria. This is a low-priority issue since we'd like to make sure support for western diacritics is functioning properly first, but will likely need to be addressed eventually as a feature request.LandingChristosChristoshttps://gitlab.coko.foundation/wax/wax/-/issues/6Wax editor should reflect paragraph indentation2018-05-04T10:39:26ZAlex ThegWax editor should reflect paragraph indentationIn Wax, the paragraphs that will be indented in the paginated output should also appear indented in the editor (first line only, not the whole paragraph). This helps editors verify that the styling is correct and narrows the gap between ...In Wax, the paragraphs that will be indented in the paginated output should also appear indented in the editor (first line only, not the whole paragraph). This helps editors verify that the styling is correct and narrows the gap between the display in Wax and the final output.
The paginated output and the in-editor indentation display should use the same rules:
* All General Text paragraphs should be indented unless they follow a:
* Chapter Title
* Subtitle
* Epigraph: Prose
* Epigraph: Poetry
* Heading 1, 2 or 3
* Line space (an extra return)
* The first paragraph of an Extract: Prose and an Epigraph: Prose should not be indented. Subsequent paragraphs in the same extract/epigraph should be indented.
* The “General Text Continuation” tag (will update with a different name) should not be indented (see editoria/editoria#77)LandingChristosChristoshttps://gitlab.coko.foundation/wax/wax/-/issues/203[Bug] Chapter remains locked with no authors in it / chapter upload is hung2020-05-22T20:58:56ZRace MoChridhe[Bug] Chapter remains locked with no authors in it / chapter upload is hungThis report comes in three parts: the editor's report of the actions leading up to the chapter lock, the current lock situation, and an error with upload of a chapter file that may or may not be related.
1) The editor reports that, whil...This report comes in three parts: the editor's report of the actions leading up to the chapter lock, the current lock situation, and an error with upload of a chapter file that may or may not be related.
1) The editor reports that, while working in a paragraph containing italicized text, her cursor came into contact with the italics such that she was starting to type in italics. This was not desired, and she selected the text and hit the "I" icon in the editor, but the italics were not removed. She also attempted undoing, as well as using the ctrl+i keyboard command, but the italics remained. She then discovered that, although she could still highlight text with her cursor, the "Add Comment" button was no longer responsive, and she was no longer able to add or change text within the paragraph. Other paragraphs continued to behave normally. When she first reported this, she had already exited the chapter and I advised her to enter it again and see if the problem persisted. It did, and she reported that it occurred on another paragraph as well as she continued to edit. She left the chapter a second time, whereupon it remained locked.
Using a test book on the same installation, and using both the latest version of Edge on Windows 10 (as the editor was using) and the latest version of Chrome, I have been unable to replicate the reported error with editing italic text and chapter-specific loss of responsiveness. However, I have been working on a small test chapter without pre-existing edits. The chapter in production, at the last time I was able to view it, had over 500 tracked changes, which I imagine could be a significant variable. In any event, I can confirm that the chapter is now locked for all users.
2) The locked chapter is inaccessible to all users, despite no users being in it at present. Additionally, attempts to access the "Preview" of the locked chapter (both using the "Preview" button on the ToC and using the links to the affected chapter from the adjoining chapters) result in display of Editoria's top menu, but no document:
![image](/uploads/f26399ab73bd22aae2f067a3e1e157eb/image.png)
Periodically, the page reloads, causing the menu to temporarily disappear and return. Attempting to interact with the buttons in the top menu results in a pop-up browser message stating that "cloud68.co is not responding due to a long-running script." Using the button provided by that message to "Stop the script" reloads the page, whereupon the situation is the same. Eventually, Edge produces a message stating that "This page is having a problem loading. We tried to load this page for you a few times, but there is still a problem with this site. We know you have better things to do than to watch this page reload over and over again so try coming back to this page later."
3) Approximately eight hours ago, I created a new chapter in the same book and attempted to upload a DOCX file containing the text of a chapter. This file is still listed as "Uploading..." In attempting to discern why the chapter was taking so long, it was discovered that the author had included her images directly in the DOCX file, which was, consequently, almost 47MB in size. One imagines this may be at the root of the upload problem, as we have not encountered this with normally sized files. The fact remains, however, that we have no way to cancel this stuck upload process or delete the chapter in question so as to start again.
Any and all assistance would be appreciated.https://gitlab.coko.foundation/wax/wax/-/issues/201[Bug] "Undo" operates incompletely on deletion of a note2020-05-22T21:08:39ZRace MoChridhe[Bug] "Undo" operates incompletely on deletion of a noteRecently had this bug brought to my attention by an editor working in our system and have successfully reproduced the unexpected/undesired behaviour myself.
If an editor deletes a footnote in Wax, this change can be rejected using the "...Recently had this bug brought to my attention by an editor working in our system and have successfully reproduced the unexpected/undesired behaviour myself.
If an editor deletes a footnote in Wax, this change can be rejected using the "Reject" button. If, however, the editor uses ctrl+z to undo the deletion (which works normally for undoing other edits), the note in the main text will be restored, but the text of the note itself remains rubricated and struck through in the notes panel at the bottom of the screen. Wax, however, no longer regards the deletion of that text as a tracked change (because the change has already been undone), and so the "Reject" button remains greyed out:
![Capture](/uploads/ba4d0055bca5d34645449c3244b2a068/Capture.PNG)
The only way for the editor to restore the note text at that point (besides simply copy-pasting the text into a new note and deleting the previous one with track changes off), is to re-delete the note in the main text, which allows the "Reject" button to be used and restores everything to normal. This is not intuitive, however, and our editor ended up struggling for a long time with trying to restore the note text before finally reaching out to me. I imagine others may eventually fall into this trap as well.https://gitlab.coko.foundation/wax/wax/-/issues/196Feature Request: Direct Editing of HTML2019-02-06T12:59:44ZRace MoChridheFeature Request: Direct Editing of HTMLFor some tasks requiring more intensely customized layout, it would be nice to be able to toggle between Wax's semantic editor and direct editing of the underlying HTML, similar to Wordpress (pre-Gutenberg). Is that doable?For some tasks requiring more intensely customized layout, it would be nice to be able to toggle between Wax's semantic editor and direct editing of the underlying HTML, similar to Wordpress (pre-Gutenberg). Is that doable?https://gitlab.coko.foundation/wax/wax/-/issues/194Providers should be registered through configurator , similar to substance Pr...2018-12-03T14:38:33ZChristosProviders should be registered through configurator , similar to substance Providers.https://gitlab.coko.foundation/wax/wax/-/issues/189Will Wax support citations/references? Synergy with Manubot's CSL cite-by-ID ...2018-08-17T14:16:30ZDaniel HimmelsteinWill Wax support citations/references? Synergy with Manubot's CSL cite-by-ID infrastructure.Greetings, I just learned about Wax from Kristen Ratan (we'll both be at the FORCE2018 conference at Montreal). I checked out the [Wax demo](http://wax-demo.coko.foundation/) and it looks slick! I didn't see an option to do citations... ...Greetings, I just learned about Wax from Kristen Ratan (we'll both be at the FORCE2018 conference at Montreal). I checked out the [Wax demo](http://wax-demo.coko.foundation/) and it looks slick! I didn't see an option to do citations... are citations coming? Is this an upstream feature that is under the purview of Substance?
Anyways, I'm one of the lead developers of [Manubot](https://github.com/greenelab/manubot-rootstock), which is a system for writing papers using git + GitHub + continuous integration. It targets a more technical user base than Wax, but we've developed a robust system for going from citation identifier to CSL JSON data to rendered references. Basically, the user [can cite](https://github.com/greenelab/manubot-rootstock/blob/master/USAGE.md#citations) a DOI, PubMed ID, PMC ID, arXiv ID, or URL and the CSL JSON metadata is automatically generated. The user can choose from thousands of predefined CSL styles (or create their own) to cause the references to render in whatever style they want.
This is currently part of our [Python package](https://github.com/greenelab/manubot), but I'm assuming Wax would need a javascript client-side implementation. So our code may not be directly portable, but it would be great to standardize our methods and approach as much as possible with the web-based editors that will bring cite-by-ID to the masses.
Also another possibility would be a web-app with an API that uses our Python infrastructure, and hence can take advantage of caching to limit the requests made to upstream metadata APIs. Also users could submit metadata patches in case the upstream metadata were faulty.https://gitlab.coko.foundation/wax/wax/-/issues/185search and replace: remove component if empty2018-06-17T16:27:00Zjulientaqjulien@coko.foundationsearch and replace: remove component if emptyWhen searching for a string that is the complete component, and i hit replace, there is still an empty string where the searched words were. This white line should be removed.When searching for a string that is the complete component, and i hit replace, there is still an empty string where the searched words were. This white line should be removed.https://gitlab.coko.foundation/wax/wax/-/issues/184Editing Functions2018-06-16T07:31:34ZPaulEditing FunctionsFollowing my mild moan on Twitter about GoogleDocs editing functions, I said that I’d note down the feature from Word that I miss in GoogleDocs. https://twitter.com/CokoFoundation/status/1007631154797637632
I’m afraid I’ve not used Wax ...Following my mild moan on Twitter about GoogleDocs editing functions, I said that I’d note down the feature from Word that I miss in GoogleDocs. https://twitter.com/CokoFoundation/status/1007631154797637632
I’m afraid I’ve not used Wax so it could be that you’ve already included these features.
The major issue I have is that the three modes of GoogleDocs (editing/suggesting/viewing) in combination with the “Review Suggested Edits” tool are not as useful as the four viewing modes of Word (Simple Mark Up / All Mark Up / No Mark Up / Original ) in combination with track Changes On/Off.
Editing/Suggesting is equivalent to Track Changes On/Off but the view modes (which are essentially previews in GoogleDocs) make it very difficult to follow what is going on once you’ve got lots of changes in a manuscript (I’ve recently seen manuscripts with 200-300 small changes).
The most frustrating thing is not being able edit a manuscript with tracked changes on in a manuscript in google docs without seeing all of the mark up. This is simple in Word (Tracked Changes On, No Mark Up mode). In GoogleDocs the only way you can see what the edited manuscript looks like (without accepting suggestions) is to use the preview tool (Tools>Review Suggested Edits>Preview “Accept All”). Unfortunately, this is a view only mode so all of the minor problems that are easy to miss in a busy tracked changes manuscript are hard to pick up - it’s very time consuming to flick between modes to fix missing spaces, grammar problems, rogue words/letters that didn’t get cut or extra carriage returns. The viewing mode hides tracked changes and again is view only.
Until recently there were also problems with calculating word count of the tracked changes document (although that seems to have been recently changed) and copying comments and suggestions over to a new document (again this looks like it has been recently resolved).https://gitlab.coko.foundation/wax/wax/-/issues/180Annotate images2018-05-22T15:18:43ZBarbara RühlingAnnotate imagesIt would be wonderful if there could be a way to annotate images with simple text fields and a drawing tool.It would be wonderful if there could be a way to annotate images with simple text fields and a drawing tool.https://gitlab.coko.foundation/wax/wax/-/issues/179Support non-Roman alphabet and right-to-left languages2018-05-22T13:25:44ZClara TottenSupport non-Roman alphabet and right-to-left languagesWe would like support for various languages. In addition, we would like to be able to include both left-to-right and right-to-left languages in the same body of text (including in the same sentence).We would like support for various languages. In addition, we would like to be able to include both left-to-right and right-to-left languages in the same body of text (including in the same sentence).https://gitlab.coko.foundation/wax/wax/-/issues/177Tables in Wax2018-05-22T09:02:18ZAlex ThegTables in WaxI'm opening this ticket @christos for when you are ready to tackle tables in Wax. Here's how XSweet currently handles tables, in case it informs how you implement them (it may not!).
XSweet recreates tables from Word in HTML, capturing
...I'm opening this ticket @christos for when you are ready to tackle tables in Wax. Here's how XSweet currently handles tables, in case it informs how you implement them (it may not!).
XSweet recreates tables from Word in HTML, capturing
* cell contents
* horizontal and vertical text alignment within cells
* horizontally and vertically merged cells
XSweet wraps the text of cell contents in `<p>`s. You can see an example of an extracted table here: http://xsweet.coko.foundation/xsweet-core/#tables
Once you've got an idea of how you'll handle them in Wax, let us know and we can add a bit to Editoria Typescript to change tables into the proper format.julientaqjulien@coko.foundationjulientaqjulien@coko.foundationhttps://gitlab.coko.foundation/wax/wax/-/issues/175Change tooltip text for tracking adding/removing emphasis2018-05-21T03:12:12ZAlex ThegChange tooltip text for tracking adding/removing emphasisCurrently, the hover over tooltip that appears to describe tracked changes that add or remove italics reads "alex added emphasis" or "alex removed emphasis". Instead, this text should read "alex added italics" or "alex removed italics".Currently, the hover over tooltip that appears to describe tracked changes that add or remove italics reads "alex added emphasis" or "alex removed emphasis". Instead, this text should read "alex added italics" or "alex removed italics".https://gitlab.coko.foundation/wax/wax/-/issues/173Add keyboard shortcut to apply highlighting2018-05-17T08:18:03ZAlex ThegAdd keyboard shortcut to apply highlightingWax should have a keyboard shortcut for applying highlighting to selected text.
Juliana had suggested a toggle on/off feature where the cursor becomes a highlighter that highlights on click-and-drag until the highlighter is toggled off ...Wax should have a keyboard shortcut for applying highlighting to selected text.
Juliana had suggested a toggle on/off feature where the cursor becomes a highlighter that highlights on click-and-drag until the highlighter is toggled off again. This would be used to make many highlights easily. A keyboard shortcut is simpler to implement but would also allow fast highlighting.
This relates to #172 in that once the highlighter can retain the last applied color, this shortcut should use the last applied highlight color as well.https://gitlab.coko.foundation/wax/wax/-/issues/172Keep last used highlighter color on state2018-05-17T08:18:03ZChristosKeep last used highlighter color on statefrom @atheg
This looks really nice. One feature that I expect will be requested, but should be saved for implementation farther down the line, is that the highlighter button should retain the last color applied.
Currently, the icon app...from @atheg
This looks really nice. One feature that I expect will be requested, but should be saved for implementation farther down the line, is that the highlighter button should retain the last color applied.
Currently, the icon applies yellow highlighting when clicked. To apply green highlighting, one has to click the dropdown and select green highlighting every time it's applied. Instead, the button should retain the last highlight color applied, so that the user only has to use the dropdown color selector to change colors. Subsequently selecting text and clicking the highlighter button without using the dropdown should apply the last used highlight color again. Baked into this functionality, the highlighter button color should probably change to reflect the current color.https://gitlab.coko.foundation/wax/wax/-/issues/170First line Indent/flush override?2018-05-10T03:38:33ZAlex ThegFirst line Indent/flush override?This is a proposed solution to the following feedback from UCP; it would address not only this immediate concern but other similar cases that arise in the future:
* Sometimes extracts begin with the first line flush left
* Other times th...This is a proposed solution to the following feedback from UCP; it would address not only this immediate concern but other similar cases that arise in the future:
* Sometimes extracts begin with the first line flush left
* Other times they should have the first line indented
* Currently, multiple runs of extracts are treated as multi-paragraph extracts, but they aren't always. Sometimes there really should be multiple distinct extracts in a row
To handle these and other similar cases, @yannis proposes a "first line indented/flush left" toggle override that could be applied to any style. This could be a powerful tool for handling edge cases that arise for extracts and other styles. It would prevent the need to add edge case styles like "General Text Cont'd" ad nauseam. Indentation should be baked in as CSS rules wherever possible, so this override would be used only for exceptions as need, and not as a matter of regular course. It's worth noting that this is a bit of a departure from the rest of the paradigm (styling over formatting), although there's a strong use case for it (edge cases that UCP has brought up).
If we want to pursue this approach, we should check it with UCP first for confirmation. Are we happy with this proposed approach @yannis @christos @alexgeo @adam @Alison?https://gitlab.coko.foundation/wax/wax/-/issues/164Track block-level formatting changes.2018-05-15T10:04:43ZYannis BarlasTrack block-level formatting changes.This is about the implementation of this.
For the design discussion, look at #40.This is about the implementation of this.
For the design discussion, look at #40.ChristosChristos