From 08b7a5a87f6c1c5df109f81533986c98033f8661 Mon Sep 17 00:00:00 2001
From: Alexandru Munteanu <alexandru.munt@gmail.com>
Date: Thu, 23 Aug 2018 14:17:07 +0300
Subject: [PATCH] chore(fix lint and remove unused files):
---
packages/component-faraday-ui/src/PersonInfo.js | 9 +--------
packages/component-faraday-ui/src/WizardFiles.md | 2 +-
.../component-faraday-ui/src/modals/MultiAction.js | 3 +--
packages/component-faraday-ui/src/modals/OpenModal.js | 2 +-
.../src/modals/SingleActionModal.js | 3 +--
packages/component-manuscript/src/components/Files.js | 11 -----------
.../src/components/ResponseToReviewers.js | 11 +----------
.../src/components/ReviewReportCard.js | 6 ------
.../src/components/Reviewers/ReviewerForm.js | 6 ------
packages/styleguide/styleguide.config.js | 1 +
10 files changed, 7 insertions(+), 47 deletions(-)
diff --git a/packages/component-faraday-ui/src/PersonInfo.js b/packages/component-faraday-ui/src/PersonInfo.js
index fbf87496c..006a47787 100644
--- a/packages/component-faraday-ui/src/PersonInfo.js
+++ b/packages/component-faraday-ui/src/PersonInfo.js
@@ -1,10 +1,7 @@
import React from 'react'
import PropTypes from 'prop-types'
-import Text from './Text'
-import Label from './Label'
-import Row from './gridItems/Row'
-import Item from './gridItems/Item'
+import { Text, Row, Label, Item } from './'
const defaultPerson = {
email: '',
@@ -46,7 +43,3 @@ PersonInfo.proTypes = {
}
export default PersonInfo
-
-// #region styles
-
-// #endregion
diff --git a/packages/component-faraday-ui/src/WizardFiles.md b/packages/component-faraday-ui/src/WizardFiles.md
index 8495cb39d..d6b43dcba 100644
--- a/packages/component-faraday-ui/src/WizardFiles.md
+++ b/packages/component-faraday-ui/src/WizardFiles.md
@@ -29,5 +29,5 @@ const files = {
supplementary: [],
};
-<WizardFiles files={files} />
+<WizardFiles files={files} uploadFile={f => console.log('upload file ', f)} />
```
diff --git a/packages/component-faraday-ui/src/modals/MultiAction.js b/packages/component-faraday-ui/src/modals/MultiAction.js
index 4857376e2..8438d5a1a 100644
--- a/packages/component-faraday-ui/src/modals/MultiAction.js
+++ b/packages/component-faraday-ui/src/modals/MultiAction.js
@@ -4,8 +4,7 @@ import { th } from '@pubsweet/ui-toolkit'
import { H2, Button, Spinner, ErrorText } from '@pubsweet/ui'
import { compose, setDisplayName, withHandlers } from 'recompose'
-import Text from '../Text'
-import IconButton from '../IconButton'
+import { IconButton, Text } from '../'
const MultiAction = ({
title,
diff --git a/packages/component-faraday-ui/src/modals/OpenModal.js b/packages/component-faraday-ui/src/modals/OpenModal.js
index 973ce5235..8b6ebe84d 100644
--- a/packages/component-faraday-ui/src/modals/OpenModal.js
+++ b/packages/component-faraday-ui/src/modals/OpenModal.js
@@ -3,7 +3,7 @@ import { get } from 'lodash'
import { compose, withHandlers } from 'recompose'
import { withModal } from 'pubsweet-component-modal/src/components'
-import MultiAction from './MultiAction'
+import { MultiAction } from './'
const OpenModal = ({ onClickEvent, children }) => (
<div>{children(onClickEvent)}</div>
diff --git a/packages/component-faraday-ui/src/modals/SingleActionModal.js b/packages/component-faraday-ui/src/modals/SingleActionModal.js
index 5a68c7963..6e32efa32 100644
--- a/packages/component-faraday-ui/src/modals/SingleActionModal.js
+++ b/packages/component-faraday-ui/src/modals/SingleActionModal.js
@@ -4,8 +4,7 @@ import { th } from '@pubsweet/ui-toolkit'
import { Button, Icon, H2 } from '@pubsweet/ui'
import { compose, setDisplayName, withHandlers } from 'recompose'
-import Text from '../Text'
-import IconButton from '../IconButton'
+import { IconButton, Text } from '../'
const SingleActionModal = ({
error,
diff --git a/packages/component-manuscript/src/components/Files.js b/packages/component-manuscript/src/components/Files.js
index 9701cfcef..16adcf896 100644
--- a/packages/component-manuscript/src/components/Files.js
+++ b/packages/component-manuscript/src/components/Files.js
@@ -2,8 +2,6 @@ import React, { Fragment } from 'react'
import { th } from '@pubsweet/ui-toolkit'
import styled, { css } from 'styled-components'
-import { FileItem } from 'pubsweet-components-faraday/src/components/Files'
-
const Files = ({
files: {
manuscripts = [],
@@ -19,9 +17,6 @@ const Files = ({
<span>Main manuscript</span>
<div />
</Header>
- {manuscripts.map(file => (
- <FileItem compact id={file.id} key={file.id} {...file} />
- ))}
</Fragment>
)}
{!!supplementary.length && (
@@ -30,9 +25,6 @@ const Files = ({
<span>Supplemetary files</span>
<div />
</Header>
- {supplementary.map(file => (
- <FileItem compact id={file.id} key={file.id} {...file} />
- ))}
</Fragment>
)}
{!!coverLetter.length && (
@@ -41,9 +33,6 @@ const Files = ({
<span>Cover letter</span>
<div />
</Header>
- {coverLetter.map(file => (
- <FileItem compact id={file.id} key={file.id} {...file} />
- ))}
</Fragment>
)}
</Root>
diff --git a/packages/component-manuscript/src/components/ResponseToReviewers.js b/packages/component-manuscript/src/components/ResponseToReviewers.js
index cd59bb99f..b370541ad 100644
--- a/packages/component-manuscript/src/components/ResponseToReviewers.js
+++ b/packages/component-manuscript/src/components/ResponseToReviewers.js
@@ -1,9 +1,8 @@
import React, { Fragment } from 'react'
-import { get, isEmpty } from 'lodash'
+import { get } from 'lodash'
import { withProps } from 'recompose'
import { th } from '@pubsweet/ui-toolkit'
import styled, { css } from 'styled-components'
-import { FileItem } from 'pubsweet-components-faraday/src/components/Files'
import { Expandable } from '../molecules'
@@ -18,14 +17,6 @@ const ResponseToReviewers = ({
<Text>{comments}</Text>
</Fragment>
)}
- {!isEmpty(files) && (
- <Fragment>
- <Label>Files</Label>
- {files.map(file => (
- <FileItem compact id={file.id} key={file.id} {...file} />
- ))}
- </Fragment>
- )}
</Expandable>
</Root>
)
diff --git a/packages/component-manuscript/src/components/ReviewReportCard.js b/packages/component-manuscript/src/components/ReviewReportCard.js
index 1eb9b7adb..0ea6fdb25 100644
--- a/packages/component-manuscript/src/components/ReviewReportCard.js
+++ b/packages/component-manuscript/src/components/ReviewReportCard.js
@@ -5,7 +5,6 @@ import { th } from '@pubsweet/ui-toolkit'
import { withJournal } from 'xpub-journal'
import styled, { css } from 'styled-components'
import { DateParser } from 'pubsweet-components-faraday/src/components'
-import { FileItem } from 'pubsweet-components-faraday/src/components/Files'
import { ShowMore } from './'
@@ -71,11 +70,6 @@ const ReviewReportCard = ({
<Row left>
<Label>Files</Label>
</Row>
- <Row left>
- {publicComment.files.map(file => (
- <FileItem compact id={file.id} key={file.id} {...file} />
- ))}
- </Row>
</Fragment>
)}
diff --git a/packages/components-faraday/src/components/Reviewers/ReviewerForm.js b/packages/components-faraday/src/components/Reviewers/ReviewerForm.js
index b8f3ea07f..2094b1e1e 100644
--- a/packages/components-faraday/src/components/Reviewers/ReviewerForm.js
+++ b/packages/components-faraday/src/components/Reviewers/ReviewerForm.js
@@ -9,7 +9,6 @@ import { reduxForm, change as changeForm, initialize } from 'redux-form'
import { ReviewersSelect } from './'
import { inviteReviewer } from '../../redux/reviewers'
-import { ValidatedTextField } from '../AuthorList/FormItems'
const ReviewerForm = ({
users,
@@ -23,11 +22,6 @@ const ReviewerForm = ({
<Root>
<Row>
<ReviewersSelect onSelect={selectReviewer} values={filteredUsers()} />
- <ValidatedTextField isRequired label="Last name*" name="lastName" />
- </Row>
- <Row>
- <ValidatedTextField label="First name" name="firstName" />
- <ValidatedTextField label="Affiliation" name="affiliation" />
</Row>
{reviewerError && (
<CenterRow>
diff --git a/packages/styleguide/styleguide.config.js b/packages/styleguide/styleguide.config.js
index b0d7ed608..c53042e29 100644
--- a/packages/styleguide/styleguide.config.js
+++ b/packages/styleguide/styleguide.config.js
@@ -18,6 +18,7 @@ module.exports = {
components: ['../component-faraday-ui/src/gridItems/[A-Z]*.js'],
},
],
+ skipComponentsWithoutExample: true,
pagePerSection: true,
styleguideComponents: {
Wrapper: path.join(__dirname, 'src/Wrapper'),
--
GitLab