From 0c5fcaee61b49e8ea7f1cd914d61cb2e3403e49d Mon Sep 17 00:00:00 2001
From: Sebastian Mihalache <sebi.mihalache@gmail.com>
Date: Tue, 4 Dec 2018 14:19:31 +0200
Subject: [PATCH] fix(recommendations): fix CR notes
---
.../src/routes/fragmentsRecommendations/post.js | 4 ++--
.../routes/fragmentsRecommendations/strategies/hePublish.js | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/packages/component-manuscript-manager/src/routes/fragmentsRecommendations/post.js b/packages/component-manuscript-manager/src/routes/fragmentsRecommendations/post.js
index 78e37c075..abfd90990 100644
--- a/packages/component-manuscript-manager/src/routes/fragmentsRecommendations/post.js
+++ b/packages/component-manuscript-manager/src/routes/fragmentsRecommendations/post.js
@@ -21,7 +21,7 @@ const requestRevisionAsHE = require('./strategies/heRequestRevision')
const requestRevisionAsEiC = require('./strategies/eicRequestRevision')
module.exports = models => async (req, res) => {
- const { recommendation, comments, recommendationType } = req.body
+ const { recommendation, comments = [], recommendationType } = req.body
if (!services.checkForUndefinedParams(recommendationType, recommendation))
return res.status(400).json({ error: 'Recommendation type is required.' })
@@ -74,11 +74,11 @@ module.exports = models => async (req, res) => {
const newRecommendation = {
userId,
id: v4(),
+ comments,
recommendation,
recommendationType,
createdOn: Date.now(),
updatedOn: Date.now(),
- comments: comments || [],
}
const notification = new Notification({
diff --git a/packages/component-manuscript-manager/src/routes/fragmentsRecommendations/strategies/hePublish.js b/packages/component-manuscript-manager/src/routes/fragmentsRecommendations/strategies/hePublish.js
index bbbe74cae..238efbc14 100644
--- a/packages/component-manuscript-manager/src/routes/fragmentsRecommendations/strategies/hePublish.js
+++ b/packages/component-manuscript-manager/src/routes/fragmentsRecommendations/strategies/hePublish.js
@@ -7,7 +7,7 @@ module.exports = {
newRecommendation,
}) => {
const fragments = await collectionHelper.collection.getFragments()
- // console.log('FRAGs', fragments)
+
if (!collectionHelper.canHEMakeRecommendation(fragments, fragmentHelper)) {
throw new Error('Cannot publish without at least one reviewer report.')
}
--
GitLab