diff --git a/packages/component-faraday-selectors/src/index.js b/packages/component-faraday-selectors/src/index.js index 59273a4fd2f111a727247616f04dff426f276efb..68c0e9420517f878915ee2be203d2168af35df65 100644 --- a/packages/component-faraday-selectors/src/index.js +++ b/packages/component-faraday-selectors/src/index.js @@ -62,21 +62,25 @@ export const canViewReviewersDetails = (state, collection = {}) => { return canViewReports(state, collection.id) } -const authorCannotViewReportsDetails = ['rejected', 'revisionRequested'] +const authorCanViewReportsDetailsStatuses = [ + 'revisionRequested', + 'pendingApproval', + 'rejected', + 'accepted', + 'inQa', +] export const authorCanViewReportsDetails = ( state, collection = {}, fragmentId, ) => { - if ( - authorCannotViewReportsDetails.includes(get(collection, 'status', false)) && - currentUserIsAuthor(state, fragmentId) - ) { - return true - } - - return false + const isAuthor = currentUserIsAuthor(state, fragmentId) + return ( + authorCanViewReportsDetailsStatuses.includes( + get(collection, 'status', 'draft'), + ) && isAuthor + ) } const canHeViewEditorialCommentsStatuses = [ diff --git a/packages/component-faraday-ui/src/contextualBoxes/AuthorReviews.js b/packages/component-faraday-ui/src/contextualBoxes/AuthorReviews.js index 4c6f55363477429f99798cd4f18ec512d4906bcc..447a7614b1a06bf362b4d03db9d0d4a6244a571e 100644 --- a/packages/component-faraday-ui/src/contextualBoxes/AuthorReviews.js +++ b/packages/component-faraday-ui/src/contextualBoxes/AuthorReviews.js @@ -15,17 +15,22 @@ const SubmittedReportsNumberForAuthorReviews = ({ reports }) => ( </Row> ) -const AuthorReviews = ({ invitations, journal, reports, fragment }) => ( - <ContextualBox - label="Review Reports" - rightChildren={ - <SubmittedReportsNumberForAuthorReviews reports={reports.length} /> - } - > - {reports.map((r, i) => ( - <ReviewerReportAuthor journal={journal} key={r.id} report={reports[i]} /> - ))} - </ContextualBox> -) +const AuthorReviews = ({ invitations, journal, reports, fragment }) => + reports.length && ( + <ContextualBox + label="Review Reports" + rightChildren={ + <SubmittedReportsNumberForAuthorReviews reports={reports.length} /> + } + > + {reports.map((r, i) => ( + <ReviewerReportAuthor + journal={journal} + key={r.id} + report={reports[i]} + /> + ))} + </ContextualBox> + ) export default compose(withProps())(AuthorReviews)