diff --git a/packages/component-invite/src/routes/collectionsInvitations/post.js b/packages/component-invite/src/routes/collectionsInvitations/post.js index 7d404e0cec4a91d3a74808722332a7266963aa78..8e354cf84a9b9b912b10980435ea169741ff994e 100644 --- a/packages/component-invite/src/routes/collectionsInvitations/post.js +++ b/packages/component-invite/src/routes/collectionsInvitations/post.js @@ -50,7 +50,6 @@ module.exports = models => async (req, res) => { error: 'Unauthorized.', }) - // check collection status if (!['submitted', 'heInvited'].includes(collection.status)) { return res.status(400).json({ error: `Cannot invite HE while collection is in the status: ${ diff --git a/packages/component-invite/src/tests/collectionsInvitations/post.test.js b/packages/component-invite/src/tests/collectionsInvitations/post.test.js index de48dc4f84033d9090d303bd4ce1563c1298a992..94dc618a3165e9535d1cb6fce0d4fa92e23eb354 100644 --- a/packages/component-invite/src/tests/collectionsInvitations/post.test.js +++ b/packages/component-invite/src/tests/collectionsInvitations/post.test.js @@ -192,7 +192,36 @@ describe('Post collections invitations route handler', () => { }, }) - // expect(res.statusCode).toBe(200) + expect(res.statusCode).toBe(400) + const data = JSON.parse(res._getData()) + + expect(data.error).toEqual( + `Cannot invite HE while collection is in the status: ${ + collection.status + }.`, + ) + }) + it('should return an error when the collection is in the revision requested status', async () => { + const { user, editorInChief } = testFixtures.users + const { collection } = testFixtures.collections + collection.status = 'revisionRequested' + + body = { + email: user.email, + role: 'handlingEditor', + } + const res = await requests.sendRequest({ + body, + userId: editorInChief.id, + route, + models, + path, + params: { + collectionId: collection.id, + }, + }) + + expect(res.statusCode).toBe(400) const data = JSON.parse(res._getData()) expect(data.error).toEqual( diff --git a/packages/component-manuscript-manager/src/routes/fragmentsRecommendations/post.js b/packages/component-manuscript-manager/src/routes/fragmentsRecommendations/post.js index 0a70507ccc8278f72c7ed5310552349764ef88ab..78e37c075431f52afa13f1831a52f441eb63fa7e 100644 --- a/packages/component-manuscript-manager/src/routes/fragmentsRecommendations/post.js +++ b/packages/component-manuscript-manager/src/routes/fragmentsRecommendations/post.js @@ -27,7 +27,7 @@ module.exports = models => async (req, res) => { const reqUser = await models.User.find(req.user) const userId = reqUser.id - // console.log('REQ USER', reqUser) + const isEditorInChief = reqUser.editorInChief || reqUser.admin const { collectionId, fragmentId } = req.params