From 123b933f8dad76dcf3e04d679fc361fc3ca4050f Mon Sep 17 00:00:00 2001
From: Sebastian Mihalache <sebastian.mihalache@gmail.con>
Date: Fri, 18 May 2018 13:48:35 +0300
Subject: [PATCH] feat(compomnemnt-manuscript-manager): update status properly
---
.../src/routes/fragmentsRecommendations/patch.js | 3 ++-
.../src/routes/fragmentsRecommendations/post.js | 5 ++++-
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/packages/component-manuscript-manager/src/routes/fragmentsRecommendations/patch.js b/packages/component-manuscript-manager/src/routes/fragmentsRecommendations/patch.js
index 8283a3b51..d6cbf32c2 100644
--- a/packages/component-manuscript-manager/src/routes/fragmentsRecommendations/patch.js
+++ b/packages/component-manuscript-manager/src/routes/fragmentsRecommendations/patch.js
@@ -45,7 +45,8 @@ module.exports = models => async (req, res) => {
user,
mailService,
})
- await collectionHelper.updateStatus(collection, 'reviewCompleted')
+ if (collection.status !== 'pendingApproval')
+ await collectionHelper.updateStatus(collection, 'reviewCompleted')
}
await fragment.save()
return res.status(200).json(recommendation)
diff --git a/packages/component-manuscript-manager/src/routes/fragmentsRecommendations/post.js b/packages/component-manuscript-manager/src/routes/fragmentsRecommendations/post.js
index ae5818478..745c254c9 100644
--- a/packages/component-manuscript-manager/src/routes/fragmentsRecommendations/post.js
+++ b/packages/component-manuscript-manager/src/routes/fragmentsRecommendations/post.js
@@ -50,7 +50,10 @@ module.exports = models => async (req, res) => {
newRecommendation.recommendation = recommendation || undefined
newRecommendation.comments = comments || undefined
- if (recommendation === 'reject')
+ if (
+ ['reject', 'publish'].includes(recommendation) &&
+ recommendationType === 'editorRecommendation'
+ )
await collectionHelper.updateStatus(collection, 'pendingApproval')
fragment.recommendations.push(newRecommendation)
--
GitLab