From 15bb416cef8eb9ad7a64a6266b83bc51e67ab0db Mon Sep 17 00:00:00 2001
From: Sebastian Mihalache <sebastian.mihalache@gmail.con>
Date: Fri, 25 May 2018 11:14:42 +0300
Subject: [PATCH] feat(component-manuscript-manager): fix status after review
---
.../component-manuscript-manager/src/helpers/Collection.js | 7 +++++++
.../src/routes/fragmentsRecommendations/patch.js | 5 +----
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/packages/component-manuscript-manager/src/helpers/Collection.js b/packages/component-manuscript-manager/src/helpers/Collection.js
index 7717c3395..bde604c66 100644
--- a/packages/component-manuscript-manager/src/helpers/Collection.js
+++ b/packages/component-manuscript-manager/src/helpers/Collection.js
@@ -12,6 +12,12 @@ const updateStatusByRecommendation = async (collection, recommendation) => {
await collection.save()
}
+const updateStatus = async (collection, newStatus) => {
+ collection.status = newStatus
+ collection.visibleStatus = statuses[collection.status].private
+ await collection.save()
+}
+
const getFragmentAndAuthorData = async ({
UserModel,
FragmentModel,
@@ -47,4 +53,5 @@ module.exports = {
updateStatusByRecommendation,
getFragmentAndAuthorData,
getAgreedReviewerInvitation,
+ updateStatus,
}
diff --git a/packages/component-manuscript-manager/src/routes/fragmentsRecommendations/patch.js b/packages/component-manuscript-manager/src/routes/fragmentsRecommendations/patch.js
index 11f3bd7ed..f6c780a6f 100644
--- a/packages/component-manuscript-manager/src/routes/fragmentsRecommendations/patch.js
+++ b/packages/component-manuscript-manager/src/routes/fragmentsRecommendations/patch.js
@@ -46,10 +46,7 @@ module.exports = models => async (req, res) => {
mailService,
})
if (!['pendingApproval', 'revisionRequested'].includes(collection.status))
- await collectionHelper.updateStatusByRecommendation(
- collection,
- recommendation,
- )
+ await collectionHelper.updateStatus(collection, 'reviewCompleted')
}
await fragment.save()
return res.status(200).json(recommendation)
--
GitLab