From 19f132dce2585a092df775086d578a82151b5880 Mon Sep 17 00:00:00 2001
From: Tania Fecheta <tania.fecheta@thinslices.com>
Date: Fri, 23 Nov 2018 10:45:06 +0200
Subject: [PATCH] refactor(authsome-helpers): remove redundant code
---
packages/xpub-faraday/config/authsome-helpers.js | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/packages/xpub-faraday/config/authsome-helpers.js b/packages/xpub-faraday/config/authsome-helpers.js
index 0e41ba0d9..af2414806 100644
--- a/packages/xpub-faraday/config/authsome-helpers.js
+++ b/packages/xpub-faraday/config/authsome-helpers.js
@@ -124,8 +124,8 @@ const stripeFragmentByRole = ({
user = {},
isLast = false,
}) => {
- const { files, authors, recommendations } = fragment
- let recommendationsFromFragment
+ const { files, authors, recommendations = [] } = fragment
+ let recommendationsFromFragment = []
switch (role) {
case 'author':
return {
@@ -135,17 +135,17 @@ const stripeFragmentByRole = ({
: [],
}
case 'reviewer':
- if (isLast && recommendations) {
+ if (isLast) {
recommendationsFromFragment = filterRecommendationsFromLastVersion(
recommendations,
user,
)
- } else if (recommendations) {
+ } else {
recommendationsFromFragment = filterRecommendationsFromOlderVersions(
recommendations,
user,
)
- } else recommendationsFromFragment = []
+ }
return {
...fragment,
files: omit(files, ['coverLetter']),
--
GitLab