diff --git a/packages/component-user-manager/src/routes/collectionsUsers/post.js b/packages/component-user-manager/src/routes/collectionsUsers/post.js index 36ed33c0203adf6e0c4154b3682d46ec89af1375..73957c570bea10d9dc4e1e691690e6e8170916ca 100644 --- a/packages/component-user-manager/src/routes/collectionsUsers/post.js +++ b/packages/component-user-manager/src/routes/collectionsUsers/post.js @@ -1,4 +1,3 @@ -const logger = require('@pubsweet/logger') const get = require('lodash/get') const helpers = require('../../helpers/helpers') const collectionHelper = require('../../helpers/Collection') @@ -10,11 +9,8 @@ module.exports = models => async (req, res) => { if ( !helpers.checkForUndefinedParams(email, role, isSubmitting, isCorresponding) - ) { - res.status(400).json({ error: 'Email and role are required' }) - logger.error('Email and role are missing') - return - } + ) + return res.status(400).json({ error: 'Missing parameters.' }) const collectionId = get(req, 'params.collectionId') let collection diff --git a/packages/component-user-manager/src/tests/collectionsUsers/post.test.js b/packages/component-user-manager/src/tests/collectionsUsers/post.test.js index 14642466da9824cc291bb4b410d9d5ab9f2217a1..6d1b3462178b2b64112afd5f0693a5d950299e7f 100644 --- a/packages/component-user-manager/src/tests/collectionsUsers/post.test.js +++ b/packages/component-user-manager/src/tests/collectionsUsers/post.test.js @@ -87,7 +87,7 @@ describe('Post collections users route handler', () => { expect(res.statusCode).toBe(400) const data = JSON.parse(res._getData()) - expect(data.error).toEqual('Email and role are required') + expect(data.error).toEqual('Missing parameters.') body.email = author.email }) it('should return an error when the role is not author and the user exists', async () => {