From 1f8c43d3298e762888f7d7d0d6e26ceab79649c4 Mon Sep 17 00:00:00 2001 From: Sebastian <sebastian.mihalache@thinslices.com> Date: Wed, 11 Apr 2018 13:05:00 +0300 Subject: [PATCH] feat(component-invite): fix tests --- .../collectionsInvitations/delete.test.js | 15 ------------- .../tests/collectionsInvitations/get.test.js | 21 +------------------ 2 files changed, 1 insertion(+), 35 deletions(-) diff --git a/packages/component-invite/src/tests/collectionsInvitations/delete.test.js b/packages/component-invite/src/tests/collectionsInvitations/delete.test.js index 03c1df0a9..c5ef512e0 100644 --- a/packages/component-invite/src/tests/collectionsInvitations/delete.test.js +++ b/packages/component-invite/src/tests/collectionsInvitations/delete.test.js @@ -42,21 +42,6 @@ describe('Delete Collections Invitations route handler', () => { const data = JSON.parse(res._getData()) expect(data.error).toEqual('Invitation invalid-id not found') }) - it('should return an error when the request user is not editorInChief or admin', async () => { - const { user } = testFixtures.users - const { collection } = testFixtures.collections - const req = httpMocks.createRequest() - req.params.collectionId = collection.id - req.params.invitationId = collection.invitations[0].id - req.user = user.id - const res = httpMocks.createResponse() - await require(deletePath)(models)(req, res) - expect(res.statusCode).toBe(403) - const data = JSON.parse(res._getData()) - expect(data.error).toEqual( - 'The request user must be Editor in Chief or Admin', - ) - }) it('should return success when the collection and invitation exist', async () => { const { editorInChief } = testFixtures.users const { collection } = testFixtures.collections diff --git a/packages/component-invite/src/tests/collectionsInvitations/get.test.js b/packages/component-invite/src/tests/collectionsInvitations/get.test.js index d465691b2..b594ef526 100644 --- a/packages/component-invite/src/tests/collectionsInvitations/get.test.js +++ b/packages/component-invite/src/tests/collectionsInvitations/get.test.js @@ -40,7 +40,7 @@ describe('Get collection invitations route handler', () => { await require(getPath)(models)(req, res) expect(res.statusCode).toBe(400) const data = JSON.parse(res._getData()) - expect(data.error).toEqual('User ID and Role are required') + expect(data.error).toEqual('Role is required') }) it('should return an error when the collection does not exist', async () => { const { editorInChief, handlingEditor } = testFixtures.users @@ -96,23 +96,4 @@ describe('Get collection invitations route handler', () => { `The requested collection does not have a ${req.query.role} Team`, ) }) - it('should return an error when the request user is not EiC or Admin', async () => { - const { user, handlingEditor } = testFixtures.users - const { collection } = testFixtures.collections - const req = httpMocks.createRequest() - req.query = { - role: 'handlingEditor', - userId: handlingEditor.id, - } - req.params.collectionId = collection.id - req.user = user.id - const res = httpMocks.createResponse() - const models = Model.build() - await require(getPath)(models)(req, res) - expect(res.statusCode).toBe(403) - const data = JSON.parse(res._getData()) - expect(data.error).toEqual( - `The request user must be Editor in Chief or Admin`, - ) - }) }) -- GitLab