From 22ebf263f3ad47493fbdda4e4c5e49d8d196d518 Mon Sep 17 00:00:00 2001
From: Demetriad Sinzeanu <demetriad.sinzeanu@thinslices.com>
Date: Wed, 10 Oct 2018 10:31:07 +0300
Subject: [PATCH] fix(AuthorTag/AuthorTagList): UI issues on Author &
Affiliations on Manuscript Details page
deleted vertical live, numbers have the right size, superscript indicator moved at the end of name
and labels
---
packages/component-faraday-ui/src/AuthorTag.js | 2 +-
packages/component-faraday-ui/src/AuthorTagList.js | 3 +--
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/packages/component-faraday-ui/src/AuthorTag.js b/packages/component-faraday-ui/src/AuthorTag.js
index 43a973a32..de77649af 100644
--- a/packages/component-faraday-ui/src/AuthorTag.js
+++ b/packages/component-faraday-ui/src/AuthorTag.js
@@ -15,10 +15,10 @@ const AuthorTag = ({
},
}) => (
<Root>
- {affiliationNumber && <Superscript>{affiliationNumber}</Superscript>}
<Text>{`${firstName} ${lastName}`}</Text>
{isSubmitting && <Tag>SA</Tag>}
{isCorresponding && <Tag>CA</Tag>}
+ {affiliationNumber && <Superscript>{affiliationNumber}</Superscript>}
</Root>
)
diff --git a/packages/component-faraday-ui/src/AuthorTagList.js b/packages/component-faraday-ui/src/AuthorTagList.js
index 2d8268460..4e9cd757a 100644
--- a/packages/component-faraday-ui/src/AuthorTagList.js
+++ b/packages/component-faraday-ui/src/AuthorTagList.js
@@ -82,8 +82,8 @@ const AuthorTagList = ({
<AffiliationRow>
{affiliationList.map((a, i) => (
<Item flex={1} key={a}>
- <Superscript>{i + 1}</Superscript>
<Text>{a}</Text>
+ <Superscript>{i + 1}</Superscript>
</Item>
))}
</AffiliationRow>
@@ -120,7 +120,6 @@ const Root = styled.div`
font-family: ${th('fontReading')};
`
const AffiliationRow = styled(Row)`
- border-left: 1px solid ${th('colorBackgroundHue')};
padding-left: ${th('gridUnit')};
flex-direction: column;
`
--
GitLab