From 2cb31368488db02b1361303c00434ffab64a3cdd Mon Sep 17 00:00:00 2001
From: Iosif Boanca <iosif.boanca@thinslices.com>
Date: Tue, 6 Nov 2018 11:31:06 +0200
Subject: [PATCH] feat(fix after CR):
---
.../src/contextualBoxes/HERecommendation.js | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/packages/component-faraday-ui/src/contextualBoxes/HERecommendation.js b/packages/component-faraday-ui/src/contextualBoxes/HERecommendation.js
index 62fc335b2..92de37929 100644
--- a/packages/component-faraday-ui/src/contextualBoxes/HERecommendation.js
+++ b/packages/component-faraday-ui/src/contextualBoxes/HERecommendation.js
@@ -46,16 +46,16 @@ const options = [
},
]
-const optionsWhereHECanOnlyReject = {
- reviewersInvited: 'reviewersInvited',
- underReview: 'underReview',
- revisionRequested: 'revisionRequested',
-}
+const optionsWhereHECanOnlyReject = [
+ 'reviewersInvited',
+ 'underReview',
+ 'revisionRequested',
+]
-const showHEOptions = (collection, hasReviewerReports, fragment) => {
+const showHEOptions = ({ collection, hasReviewerReports, fragment }) => {
const { status, fragments } = collection
const { invitations } = fragment
- if (findKey(optionsWhereHECanOnlyReject, sts => sts === status)) {
+ if (optionsWhereHECanOnlyReject.includes(status)) {
return [options[1]]
} else if (!hasReviewerReports && fragments.length === 1) {
return tail(options)
@@ -103,11 +103,11 @@ const HERecommendation = ({
<ValidatedField
component={input => (
<Menu
- options={showHEOptions(
+ options={showHEOptions({
collection,
hasReviewerReports,
fragment,
- )}
+ })}
{...input}
/>
)}
--
GitLab