diff --git a/packages/component-manuscript-manager/src/routes/fragmentsRecommendations/post.js b/packages/component-manuscript-manager/src/routes/fragmentsRecommendations/post.js index 1f43c011c5fa7a98b1e6392998d2ef8fcbeb6ab9..0a70507ccc8278f72c7ed5310552349764ef88ab 100644 --- a/packages/component-manuscript-manager/src/routes/fragmentsRecommendations/post.js +++ b/packages/component-manuscript-manager/src/routes/fragmentsRecommendations/post.js @@ -32,7 +32,7 @@ module.exports = models => async (req, res) => { const { collectionId, fragmentId } = req.params - let collection, fragment, fragments + let collection, fragment try { collection = await models.Collection.find(collectionId) @@ -50,18 +50,6 @@ module.exports = models => async (req, res) => { const collectionHelper = new Collection({ collection }) - try { - fragments = await collectionHelper.getAllFragments({ - FragmentModel: models.Fragment, - }) - } catch (e) { - const notFoundError = await services.handleNotFoundError(e, 'Item') - fragments = [] - return res.status(notFoundError.status).json({ - error: notFoundError.message, - }) - } - const authsome = authsomeHelper.getAuthsome(models) const target = { fragment, @@ -143,7 +131,6 @@ module.exports = models => async (req, res) => { await strategies[role][recommendation].execute({ userId, models, - fragments, notification, fragmentHelper, collectionHelper, diff --git a/packages/component-manuscript-manager/src/routes/fragmentsRecommendations/strategies/hePublish.js b/packages/component-manuscript-manager/src/routes/fragmentsRecommendations/strategies/hePublish.js index 73c88c4349f9bc301a9a048a574fe8a11a3fdc10..238efbc141b40fda46e5c048afb3e9031a8213fb 100644 --- a/packages/component-manuscript-manager/src/routes/fragmentsRecommendations/strategies/hePublish.js +++ b/packages/component-manuscript-manager/src/routes/fragmentsRecommendations/strategies/hePublish.js @@ -1,12 +1,13 @@ module.exports = { execute: async ({ userId, - fragments, notification, fragmentHelper, collectionHelper, newRecommendation, }) => { + const fragments = await collectionHelper.collection.getFragments() + if (!collectionHelper.canHEMakeRecommendation(fragments, fragmentHelper)) { throw new Error('Cannot publish without at least one reviewer report.') }