From 3e29633a56058305a4bc0cb1252e3684feb419a6 Mon Sep 17 00:00:00 2001
From: Sebastian Mihalache <sebastian.mihalache@gmail.con>
Date: Fri, 22 Jun 2018 09:38:07 +0300
Subject: [PATCH] feat(component-manuscript-manager): throw error when no
previous version is found
---
.../src/routes/fragments/patch.js | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/packages/component-manuscript-manager/src/routes/fragments/patch.js b/packages/component-manuscript-manager/src/routes/fragments/patch.js
index 3edf6c601..96465c5a6 100644
--- a/packages/component-manuscript-manager/src/routes/fragments/patch.js
+++ b/packages/component-manuscript-manager/src/routes/fragments/patch.js
@@ -17,6 +17,12 @@ module.exports = models => async (req, res) => {
return res.status(400).json({
error: `Collection and fragment do not match.`,
})
+ const fragLength = collection.fragments.length
+ if (fragLength < 2) {
+ return res.status(400).json({
+ error: 'No previous version has been found.',
+ })
+ }
fragment = await models.Fragment.find(fragmentId)
const authsome = authsomeHelper.getAuthsome(models)
@@ -79,12 +85,7 @@ module.exports = models => async (req, res) => {
})
}
- const fragLength = collection.fragments.length
- if (fragLength < 2) {
- return res.status(400).json({
- error: 'No previous version has been found.',
- })
- }
+ fragment.save()
const previousFragment = await models.Fragment.find(
collection.fragments[fragLength - 2],
--
GitLab