diff --git a/packages/component-manuscript-manager/src/FragmentsRecommendations.js b/packages/component-manuscript-manager/src/FragmentsRecommendations.js index df3608c1ace03452ba6124e92e283873edec2666..ea2238a33c903f5b6be5b397d4c951ebe7eedd13 100644 --- a/packages/component-manuscript-manager/src/FragmentsRecommendations.js +++ b/packages/component-manuscript-manager/src/FragmentsRecommendations.js @@ -31,7 +31,7 @@ const FragmentsRecommendations = app => { * ] * } * ], - * "type": "review" [acceptedValues: review, editorRecommendation] + * "recommendationType": "review" [acceptedValues: review, editorRecommendation] * } * @apiSuccessExample {json} Success * HTTP/1.1 200 OK @@ -55,7 +55,7 @@ const FragmentsRecommendations = app => { * ] * } * ], - * "type": "review" [acceptedValues: review, editorRecommendation] + * "recommendationType": "review" [acceptedValues: review, editorRecommendation] * } * @apiErrorExample {json} Invite user errors * HTTP/1.1 403 Forbidden diff --git a/packages/component-manuscript-manager/src/routes/fragmentsRecommendations/post.js b/packages/component-manuscript-manager/src/routes/fragmentsRecommendations/post.js index 3c18f9869315eda64df1d08a6576ae51c442699f..64865ee07072344619e2671dcda78c7fc76ddcea 100644 --- a/packages/component-manuscript-manager/src/routes/fragmentsRecommendations/post.js +++ b/packages/component-manuscript-manager/src/routes/fragmentsRecommendations/post.js @@ -2,9 +2,15 @@ const helpers = require('../../helpers/helpers') const uuid = require('uuid') module.exports = models => async (req, res) => { - const { recommendation, comments, type } = req.body + const { recommendation, comments, recommendationType } = req.body - if (!helpers.checkForUndefinedParams(recommendation, comments, type)) + if ( + !helpers.checkForUndefinedParams( + recommendation, + comments, + recommendationType, + ) + ) return res.status(400).json({ error: 'Parameters are missing.' }) const reqUser = await models.User.find(req.user) @@ -31,7 +37,7 @@ module.exports = models => async (req, res) => { id: uuid.v4(), userId: reqUser.id, submittedOn: new Date(), - type, + recommendationType, recommendation, comments, } diff --git a/packages/component-manuscript-manager/src/tests/fragmentsRecommendations/post.test.js b/packages/component-manuscript-manager/src/tests/fragmentsRecommendations/post.test.js index a63b4e4685cf4ca3a6ae6bf91a1067f12d07eb90..e861ff55a78853be5a91002024c41a69afc1a8ae 100644 --- a/packages/component-manuscript-manager/src/tests/fragmentsRecommendations/post.test.js +++ b/packages/component-manuscript-manager/src/tests/fragmentsRecommendations/post.test.js @@ -23,11 +23,8 @@ const reqBody = { ], }, ], - type: 'review', + recommendationType: 'review', } -// const route = { -// path: '/api/collections/:collectionId/invitations', -// } const path = '../../routes/fragmentsRecommendations/post' describe('Post collections invitations route handler', () => { diff --git a/packages/xpub-faraday/config/validations.js b/packages/xpub-faraday/config/validations.js index 984deecf994c418327dfcd845c88198f08434fe4..61f83d2767617ddfc03dc2927edfb35d7ab161bd 100644 --- a/packages/xpub-faraday/config/validations.js +++ b/packages/xpub-faraday/config/validations.js @@ -92,7 +92,7 @@ module.exports = { Joi.object({ id: Joi.string().required(), userId: Joi.string().required(), - type: Joi.string().required(), + recommendationType: Joi.string().required(), submittedOn: Joi.date(), recommendation: Joi.string().required(), comments: Joi.array().items(