From 572c7b707bcd0067c76f1b3e5bda786f43ef5783 Mon Sep 17 00:00:00 2001
From: Sebastian Mihalache <sebastian.mihalache@gmail.con>
Date: Wed, 9 May 2018 10:37:18 +0300
Subject: [PATCH] feat(component-manuscript-manager): update to
recommendationType
---
.../src/FragmentsRecommendations.js | 4 ++--
.../src/routes/fragmentsRecommendations/post.js | 12 +++++++++---
.../src/tests/fragmentsRecommendations/post.test.js | 5 +----
packages/xpub-faraday/config/validations.js | 2 +-
4 files changed, 13 insertions(+), 10 deletions(-)
diff --git a/packages/component-manuscript-manager/src/FragmentsRecommendations.js b/packages/component-manuscript-manager/src/FragmentsRecommendations.js
index df3608c1a..ea2238a33 100644
--- a/packages/component-manuscript-manager/src/FragmentsRecommendations.js
+++ b/packages/component-manuscript-manager/src/FragmentsRecommendations.js
@@ -31,7 +31,7 @@ const FragmentsRecommendations = app => {
* ]
* }
* ],
- * "type": "review" [acceptedValues: review, editorRecommendation]
+ * "recommendationType": "review" [acceptedValues: review, editorRecommendation]
* }
* @apiSuccessExample {json} Success
* HTTP/1.1 200 OK
@@ -55,7 +55,7 @@ const FragmentsRecommendations = app => {
* ]
* }
* ],
- * "type": "review" [acceptedValues: review, editorRecommendation]
+ * "recommendationType": "review" [acceptedValues: review, editorRecommendation]
* }
* @apiErrorExample {json} Invite user errors
* HTTP/1.1 403 Forbidden
diff --git a/packages/component-manuscript-manager/src/routes/fragmentsRecommendations/post.js b/packages/component-manuscript-manager/src/routes/fragmentsRecommendations/post.js
index 3c18f9869..64865ee07 100644
--- a/packages/component-manuscript-manager/src/routes/fragmentsRecommendations/post.js
+++ b/packages/component-manuscript-manager/src/routes/fragmentsRecommendations/post.js
@@ -2,9 +2,15 @@ const helpers = require('../../helpers/helpers')
const uuid = require('uuid')
module.exports = models => async (req, res) => {
- const { recommendation, comments, type } = req.body
+ const { recommendation, comments, recommendationType } = req.body
- if (!helpers.checkForUndefinedParams(recommendation, comments, type))
+ if (
+ !helpers.checkForUndefinedParams(
+ recommendation,
+ comments,
+ recommendationType,
+ )
+ )
return res.status(400).json({ error: 'Parameters are missing.' })
const reqUser = await models.User.find(req.user)
@@ -31,7 +37,7 @@ module.exports = models => async (req, res) => {
id: uuid.v4(),
userId: reqUser.id,
submittedOn: new Date(),
- type,
+ recommendationType,
recommendation,
comments,
}
diff --git a/packages/component-manuscript-manager/src/tests/fragmentsRecommendations/post.test.js b/packages/component-manuscript-manager/src/tests/fragmentsRecommendations/post.test.js
index a63b4e468..e861ff55a 100644
--- a/packages/component-manuscript-manager/src/tests/fragmentsRecommendations/post.test.js
+++ b/packages/component-manuscript-manager/src/tests/fragmentsRecommendations/post.test.js
@@ -23,11 +23,8 @@ const reqBody = {
],
},
],
- type: 'review',
+ recommendationType: 'review',
}
-// const route = {
-// path: '/api/collections/:collectionId/invitations',
-// }
const path = '../../routes/fragmentsRecommendations/post'
describe('Post collections invitations route handler', () => {
diff --git a/packages/xpub-faraday/config/validations.js b/packages/xpub-faraday/config/validations.js
index 984deecf9..61f83d276 100644
--- a/packages/xpub-faraday/config/validations.js
+++ b/packages/xpub-faraday/config/validations.js
@@ -92,7 +92,7 @@ module.exports = {
Joi.object({
id: Joi.string().required(),
userId: Joi.string().required(),
- type: Joi.string().required(),
+ recommendationType: Joi.string().required(),
submittedOn: Joi.date(),
recommendation: Joi.string().required(),
comments: Joi.array().items(
--
GitLab