From 584a1b370174a9a1e06bbe5e334e28742015a94f Mon Sep 17 00:00:00 2001
From: Alexandru Munteanu <alexandru.munt@gmail.com>
Date: Thu, 2 Aug 2018 15:11:58 +0300
Subject: [PATCH] fix(eqs-decision): do not send mail when rejecting, show the
correct message
---
.../src/routes/technicalChecks/patch.js | 14 ++++++++------
.../src/components/UIComponents/EQSDecisionPage.js | 4 +++-
2 files changed, 11 insertions(+), 7 deletions(-)
diff --git a/packages/component-manuscript-manager/src/routes/technicalChecks/patch.js b/packages/component-manuscript-manager/src/routes/technicalChecks/patch.js
index 45104fada..934709a74 100644
--- a/packages/component-manuscript-manager/src/routes/technicalChecks/patch.js
+++ b/packages/component-manuscript-manager/src/routes/technicalChecks/patch.js
@@ -40,12 +40,14 @@ module.exports = ({ Collection, Fragment, User }) => async (req, res) => {
collection.status = setNewStatus(step, agree)
await collection.save()
- sendNotifications({
- User,
- Fragment,
- collection,
- baseUrl: services.getBaseUrl(req),
- })
+ if (agree) {
+ sendNotifications({
+ User,
+ Fragment,
+ collection,
+ baseUrl: services.getBaseUrl(req),
+ })
+ }
return res.status(200).json(collection)
} catch (e) {
diff --git a/packages/components-faraday/src/components/UIComponents/EQSDecisionPage.js b/packages/components-faraday/src/components/UIComponents/EQSDecisionPage.js
index 3217266f7..6aaa02bb3 100644
--- a/packages/components-faraday/src/components/UIComponents/EQSDecisionPage.js
+++ b/packages/components-faraday/src/components/UIComponents/EQSDecisionPage.js
@@ -98,7 +98,9 @@ export default compose(
})
.then(() => {
setSuccess(
- 'Manuscript accepted. Thank you for your technical check!',
+ `Manuscript ${
+ decision ? 'accepted' : 'rejected'
+ }. Thank you for your technical check!`,
)
hideModal()
})
--
GitLab