From 669a7e102b87f328e1465131b81a8cf267fc1f61 Mon Sep 17 00:00:00 2001
From: Tania Fecheta <tania.fecheta@thinslices.com>
Date: Tue, 18 Dec 2018 14:44:38 +0200
Subject: [PATCH] refactor(user.test.js): move the tests for isAdmin function
from collection.test.js to user.test.js
---
.../src/tests/collection.test.js | 24 +----------
.../src/tests/user.test.js | 40 +++++++++++++++++++
2 files changed, 41 insertions(+), 23 deletions(-)
create mode 100644 packages/component-helper-service/src/tests/user.test.js
diff --git a/packages/component-helper-service/src/tests/collection.test.js b/packages/component-helper-service/src/tests/collection.test.js
index 1cda1f6e6..167153af8 100644
--- a/packages/component-helper-service/src/tests/collection.test.js
+++ b/packages/component-helper-service/src/tests/collection.test.js
@@ -5,7 +5,7 @@ const { cloneDeep } = require('lodash')
const fixturesService = require('pubsweet-component-fixture-service')
const { fixtures, Model } = fixturesService
-const { Collection, Fragment, User } = require('../Helper')
+const { Collection, Fragment } = require('../Helper')
describe('Collection helper', () => {
let testFixtures = {}
@@ -231,26 +231,4 @@ describe('Collection helper', () => {
expect(canHEMakeRecommendation).toBe(false)
})
})
-
- describe('isAdmin', () => {
- it('should return true if user is admin', async () => {
- const { admin } = testFixtures.users
- const adminId = admin.id
- const UserModel = models.User
- const userHelper = new User({ UserModel })
- const isAdmin = await userHelper.isAdmin(adminId)
-
- expect(isAdmin).toBe(true)
- })
-
- it('should return false if user is not admin', async () => {
- const { reviewer } = testFixtures.users
- const reviewerId = reviewer.id
- const UserModel = models.User
- const userHelper = new User({ UserModel })
- const isAdmin = await userHelper.isAdmin(reviewerId)
-
- expect(isAdmin).toBe(false)
- })
- })
})
diff --git a/packages/component-helper-service/src/tests/user.test.js b/packages/component-helper-service/src/tests/user.test.js
new file mode 100644
index 000000000..e31c60840
--- /dev/null
+++ b/packages/component-helper-service/src/tests/user.test.js
@@ -0,0 +1,40 @@
+process.env.NODE_TLS_REJECT_UNAUTHORIZED = '0'
+process.env.SUPPRESS_NO_CONFIG_WARNING = true
+
+const { cloneDeep } = require('lodash')
+const fixturesService = require('pubsweet-component-fixture-service')
+
+const { fixtures, Model } = fixturesService
+const { User } = require('../Helper')
+
+describe('User helper', () => {
+ let testFixtures = {}
+ let models
+
+ beforeEach(() => {
+ testFixtures = cloneDeep(fixtures)
+ models = Model.build(testFixtures)
+ })
+
+ describe('isAdmin', () => {
+ it('should return true if user is admin', async () => {
+ const { admin } = testFixtures.users
+ const adminId = admin.id
+ const UserModel = models.User
+ const userHelper = new User({ UserModel })
+ const isAdmin = await userHelper.isAdmin(adminId)
+
+ expect(isAdmin).toBe(true)
+ })
+
+ it('should return false if user is not admin', async () => {
+ const { reviewer } = testFixtures.users
+ const reviewerId = reviewer.id
+ const UserModel = models.User
+ const userHelper = new User({ UserModel })
+ const isAdmin = await userHelper.isAdmin(reviewerId)
+
+ expect(isAdmin).toBe(false)
+ })
+ })
+})
--
GitLab