From 7292c6b90934c6f69d95fc6b6976e8c6dfbc5cf2 Mon Sep 17 00:00:00 2001
From: Tania Fecheta <tania.fecheta@thinslices.com>
Date: Wed, 5 Dec 2018 15:55:32 +0200
Subject: [PATCH] fix(reviewersCanViewReviewerReports): display the report
reviewer sent only after he submits it, not
---
packages/component-faraday-selectors/src/index.js | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/packages/component-faraday-selectors/src/index.js b/packages/component-faraday-selectors/src/index.js
index 3a774ca94..709e7506f 100644
--- a/packages/component-faraday-selectors/src/index.js
+++ b/packages/component-faraday-selectors/src/index.js
@@ -121,13 +121,13 @@ export const reviewersCanViewReviewerReports = (
fragmentId,
) => {
const isReviewer = currentUserIsReviewer(state, fragmentId)
- const reviewerReports = getFragmentReviewerRecommendations(state, fragmentId)
+ const ownRecommendation = getOwnRecommendations(state, fragmentId)
return (
isReviewer &&
authorAndReviewersCanViewReportsDetailsStatuses.includes(
get(collection, 'status', 'draft'),
) &&
- reviewerReports.length > 0
+ get(ownRecommendation[0], 'submittedOn', false)
)
}
@@ -554,6 +554,6 @@ export const canReview = (state, collection = {}, fragment = {}) => {
if (!isReviewer) return false
return (
get(collection, 'status', 'draft') === 'underReview' &&
- ownRecommendation.length === 0
+ !get(ownRecommendation[0], 'submittedOn', false)
)
}
--
GitLab