From 75d71335ba813b59f337a5782ee8c8a3abf76602 Mon Sep 17 00:00:00 2001
From: Andrei Cioromila <andrei.cioromila@thinslices.com>
Date: Tue, 9 Oct 2018 15:38:18 +0300
Subject: [PATCH] fix(tests): Update tests to support variable number of
collections in test data
fix HIN-1022
---
.../src/fixtures/collections.js | 9 +--------
.../src/tests/collections/get.test.js | 4 ++--
2 files changed, 3 insertions(+), 10 deletions(-)
diff --git a/packages/component-fixture-manager/src/fixtures/collections.js b/packages/component-fixture-manager/src/fixtures/collections.js
index db15723e2..fd83ed23b 100644
--- a/packages/component-fixture-manager/src/fixtures/collections.js
+++ b/packages/component-fixture-manager/src/fixtures/collections.js
@@ -1,12 +1,5 @@
const Chance = require('chance')
-const {
- user,
- handlingEditor,
- answerHE,
- reviewer,
- answerReviewer,
- recReviewer,
-} = require('./userData')
+const { user, handlingEditor, answerHE } = require('./userData')
const { fragment, reviewCompletedFragment } = require('./fragments')
const { standardCollID } = require('./collectionIDs')
diff --git a/packages/component-manuscript-manager/src/tests/collections/get.test.js b/packages/component-manuscript-manager/src/tests/collections/get.test.js
index f9dc3d238..f072e2693 100644
--- a/packages/component-manuscript-manager/src/tests/collections/get.test.js
+++ b/packages/component-manuscript-manager/src/tests/collections/get.test.js
@@ -1,7 +1,7 @@
process.env.NODE_TLS_REJECT_UNAUTHORIZED = '0'
process.env.SUPPRESS_NO_CONFIG_WARNING = true
-const cloneDeep = require('lodash/cloneDeep')
+const { cloneDeep, size } = require('lodash')
const fixturesService = require('pubsweet-component-fixture-service')
const requests = require('../requests')
@@ -88,7 +88,7 @@ describe('Get collections route handler', () => {
expect(res.statusCode).toBe(200)
const data = JSON.parse(res._getData())
- expect(data).toHaveLength(2)
+ expect(data).toHaveLength(size(testFixtures.collections))
expect(data[0].type).toEqual('collection')
expect(data[0]).toHaveProperty('visibleStatus')
expect(data[0].currentVersion.recommendations).toHaveLength(3)
--
GitLab