From 78efa5ad7524f15de2a7e26749e204a0bd2d0691 Mon Sep 17 00:00:00 2001 From: Sebastian Mihalache <sebi.mihalache@gmail.com> Date: Mon, 22 Oct 2018 16:07:35 +0300 Subject: [PATCH] refactor(recommendationsEmails): remove unused code --- .../notifications/notification.js | 5 ----- .../src/routes/fragmentsRecommendations/post.js | 9 --------- 2 files changed, 14 deletions(-) diff --git a/packages/component-manuscript-manager/src/routes/fragmentsRecommendations/notifications/notification.js b/packages/component-manuscript-manager/src/routes/fragmentsRecommendations/notifications/notification.js index 593f705d6..961d23b9e 100644 --- a/packages/component-manuscript-manager/src/routes/fragmentsRecommendations/notifications/notification.js +++ b/packages/component-manuscript-manager/src/routes/fragmentsRecommendations/notifications/notification.js @@ -344,11 +344,6 @@ class Notification { }, }) - // email = helpers.updateEmailContentForSA({ - // email, - // customId, - // signatureName: get(collection, 'handlingEditor.name', eicName), - // }) const { html, text } = email.getNotificationBody({ emailBodyProps: { paragraph: author.paragraph, diff --git a/packages/component-manuscript-manager/src/routes/fragmentsRecommendations/post.js b/packages/component-manuscript-manager/src/routes/fragmentsRecommendations/post.js index 1afb4a42c..1c1f531ad 100644 --- a/packages/component-manuscript-manager/src/routes/fragmentsRecommendations/post.js +++ b/packages/component-manuscript-manager/src/routes/fragmentsRecommendations/post.js @@ -170,19 +170,10 @@ module.exports = models => async (req, res) => { notification.notifyReviewersWhenEiCMakesDecision() } } else { - notification.notifySAWhenHERequestsRevision() - const hasPeerReview = !isEmpty(collection.handlingEditor) if (hasPeerReview) { notification.notifyReviewersWhenHEMakesRecommendation() } - // notifications.sendNotificationsWhenHEMakesRecommendation({ - // fragment, - // collection, - // newRecommendation, - // UserModel: models.User, - // baseUrl: services.getBaseUrl(req), - // }) if (collection.status === 'revisionRequested') { notification.notifySAWhenHERequestsRevision() } -- GitLab