diff --git a/packages/component-helper-service/src/services/Collection.js b/packages/component-helper-service/src/services/Collection.js index 2fe5502233953fffec4f7f4bc91d07780cd612df..6e05d9a584f61eddc5a63a7ad309ac81bea1edb6 100644 --- a/packages/component-helper-service/src/services/Collection.js +++ b/packages/component-helper-service/src/services/Collection.js @@ -92,18 +92,16 @@ class Collection { async updateStatusOnRecommendation({ isEditorInChief, recommendation }) { if (isEditorInChief) { if (recommendation === 'return-to-handling-editor') { - this.updateStatus({ newStatus: 'reviewCompleted' }) - } else { - this.updateFinalStatusByRecommendation({ - recommendation, - }) + return this.updateStatus({ newStatus: 'reviewCompleted' }) } - } else { - this.updateStatusByRecommendation({ + return this.updateFinalStatusByRecommendation({ recommendation, - isHandlingEditor: true, }) } + return this.updateStatusByRecommendation({ + recommendation, + isHandlingEditor: true, + }) } getHELastName() { diff --git a/packages/component-manuscript-manager/src/routes/fragmentsRecommendations/post.js b/packages/component-manuscript-manager/src/routes/fragmentsRecommendations/post.js index f546274ae546d905fe925babdd17189a4167d10b..2531241656d85e7d5090e4b9256e00dcb01f0ae6 100644 --- a/packages/component-manuscript-manager/src/routes/fragmentsRecommendations/post.js +++ b/packages/component-manuscript-manager/src/routes/fragmentsRecommendations/post.js @@ -127,7 +127,7 @@ module.exports = models => async (req, res) => { newRecommendation.comments = comments || undefined if (recommendationType === 'editorRecommendation') { - collectionHelper.updateStatusOnRecommendation({ + await collectionHelper.updateStatusOnRecommendation({ isEditorInChief, recommendation, })