From 8a6c8c1db9e6dfe4d6f9d1595ccd9743c286fd41 Mon Sep 17 00:00:00 2001
From: Bogdan Cochior <bogdan.cochior@thinslices.com>
Date: Tue, 6 Mar 2018 17:17:31 +0200
Subject: [PATCH] fix(authors): fix infinite spinner when saving error
---
.../src/components/AuthorList/AuthorAdder.js | 8 ++++----
.../src/components/AuthorList/AuthorEditor.js | 12 ++++++++----
packages/components-faraday/src/redux/authors.js | 2 ++
3 files changed, 14 insertions(+), 8 deletions(-)
diff --git a/packages/components-faraday/src/components/AuthorList/AuthorAdder.js b/packages/components-faraday/src/components/AuthorList/AuthorAdder.js
index 299fba90c..cd1fc2563 100644
--- a/packages/components-faraday/src/components/AuthorList/AuthorAdder.js
+++ b/packages/components-faraday/src/components/AuthorList/AuthorAdder.js
@@ -34,21 +34,21 @@ const AuthorAdder = ({
<FormBody>
<Title>{authors.length === 0 ? 'Submitting author' : 'Author'}</Title>
<Row>
- <ValidatedTextField isRequired label="First name" name="firstName" />
+ <ValidatedTextField isRequired label="First name*" name="firstName" />
<ValidatedTextField label="Middle name" name="middleName" />
- <ValidatedTextField isRequired label="Last name" name="lastName" />
+ <ValidatedTextField isRequired label="Last name*" name="lastName" />
</Row>
<Row>
<ValidatedTextField
isRequired
- label="Email"
+ label="Email*"
name="email"
validators={[emailValidator]}
/>
<ValidatedTextField
isRequired
- label="Affiliation"
+ label="Affiliation*"
name="affiliation"
/>
<MenuItem label="Country" name="country" options={countries} />
diff --git a/packages/components-faraday/src/components/AuthorList/AuthorEditor.js b/packages/components-faraday/src/components/AuthorList/AuthorEditor.js
index ee3394026..5eed9cd35 100644
--- a/packages/components-faraday/src/components/AuthorList/AuthorEditor.js
+++ b/packages/components-faraday/src/components/AuthorList/AuthorEditor.js
@@ -64,21 +64,25 @@ const AuthorEdit = ({
</Header>
<Row>
- <ValidatedTextField isRequired label="First name" name="edit.firstName" />
+ <ValidatedTextField
+ isRequired
+ label="First name*"
+ name="edit.firstName"
+ />
<ValidatedTextField label="Middle name" name="edit.middleName" />
- <ValidatedTextField isRequired label="Last name" name="edit.lastName" />
+ <ValidatedTextField isRequired label="Last name*" name="edit.lastName" />
</Row>
<Row>
<ValidatedTextField
isRequired
- label="Email"
+ label="Email*"
name="edit.email"
validators={[emailValidator]}
/>
<ValidatedTextField
isRequired
- label="Affiliation"
+ label="Affiliation*"
name="edit.affiliation"
/>
<MenuItem label="Country" name="edit.country" options={countries} />
diff --git a/packages/components-faraday/src/redux/authors.js b/packages/components-faraday/src/redux/authors.js
index 8a9e3a9c7..c9a863d76 100644
--- a/packages/components-faraday/src/redux/authors.js
+++ b/packages/components-faraday/src/redux/authors.js
@@ -51,10 +51,12 @@ export default (state = initialState, action) => {
...initialState,
isFetching: true,
}
+ case 'UPDATE_FRAGMENT_FAILURE':
case FAILURE:
return {
...initialState,
error: action.error,
+ isFetching: false,
}
case 'UPDATE_FRAGMENT_SUCCESS':
case SUCCESS:
--
GitLab