From 8c4b1172f00f17df7c97516c5795268099b8d9d8 Mon Sep 17 00:00:00 2001 From: OanaMacsi <oana.macsimiuc.e@gmail.com> Date: Fri, 14 Dec 2018 15:26:45 +0200 Subject: [PATCH] fix(index(component-faraday-selectors)): EIC and Admin can't make decision when status is rejected/a --- packages/component-faraday-selectors/src/index.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/component-faraday-selectors/src/index.js b/packages/component-faraday-selectors/src/index.js index d51783f14..8cc86c03b 100644 --- a/packages/component-faraday-selectors/src/index.js +++ b/packages/component-faraday-selectors/src/index.js @@ -272,9 +272,11 @@ export const getHERecommendation = (state, collectionId, fragmentId) => { ) } +const cannotEICandAdminMakeDecision = ['accepted', 'rejected', 'deleted'] export const canMakeDecision = (state, collection = {}) => { + const status = get(collection, 'status', 'draft') const isEIC = currentUserIs(state, 'adminEiC') - return isEIC + return isEIC && !cannotEICandAdminMakeDecision.includes(status) } const collectionReviewerReports = state => -- GitLab