From 90b847782c2488eb10e4a068b19fce12ceae0c92 Mon Sep 17 00:00:00 2001
From: Andrei Cioromila <andrei.cioromila@thinslices.com>
Date: Wed, 10 Oct 2018 10:58:37 +0300
Subject: [PATCH] fix(authsome): Skip validating recommendations for fragments
that don't have any
---
packages/xpub-faraday/config/authsome-helpers.js | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/packages/xpub-faraday/config/authsome-helpers.js b/packages/xpub-faraday/config/authsome-helpers.js
index 3670d1e70..2960282ae 100644
--- a/packages/xpub-faraday/config/authsome-helpers.js
+++ b/packages/xpub-faraday/config/authsome-helpers.js
@@ -252,12 +252,14 @@ async function updateReviewerVisibleStatusByInvitation({
const fragmentId = last(collection.fragments)
const fragment = await FragmentModel.find(fragmentId)
const invitation = fragment.invitations.find(inv => inv.userId === user.id)
- const recommendationDone = fragment.recommendations.some(
- rec =>
- rec.recommendationType === 'review' &&
- rec.userId === user.id &&
- rec.submittedOn,
- )
+ const recommendationDone =
+ fragment.recommendations &&
+ fragment.recommendations.some(
+ rec =>
+ rec.recommendationType === 'review' &&
+ rec.userId === user.id &&
+ rec.submittedOn,
+ )
if (recommendationDone) {
return get(statuses, `${collection.status}.reviewer.label`)
--
GitLab