From a00cf5e62dac3c81ae21174904e874b0e13afd3d Mon Sep 17 00:00:00 2001
From: Tania Fecheta <tania.fecheta@thinslices.com>
Date: Tue, 27 Nov 2018 09:30:00 +0200
Subject: [PATCH] fix(reviewerReports): let an invited reviwer on the second
version to see the editorial comments and
---
packages/component-faraday-selectors/src/index.js | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/packages/component-faraday-selectors/src/index.js b/packages/component-faraday-selectors/src/index.js
index 868a670bd..1493dcaf0 100644
--- a/packages/component-faraday-selectors/src/index.js
+++ b/packages/component-faraday-selectors/src/index.js
@@ -96,6 +96,7 @@ const authorAndReviewersCanViewReportsDetailsStatuses = [
'rejected',
'accepted',
'reviewCompleted',
+ 'reviewersInvited',
'inQa',
]
@@ -166,6 +167,7 @@ const canReviewerViewEditorialCommentsStatuses = [
'reviewCompleted',
'pendingApproval',
'revisionRequested',
+ 'reviewersInvited',
]
export const canReviewerViewEditorialComments = (
state,
@@ -554,11 +556,12 @@ export const getVersionOptions = (state, collection = {}) => {
export const canReview = (state, collection = {}, fragment = {}) => {
const fragmentId = get(fragment, 'id', false)
-
if (!fragmentId) return false
-
+ const ownRecommendation = getOwnRecommendations(state, fragmentId)
const isReviewer = currentUserIsReviewer(state, fragmentId)
if (!isReviewer) return false
-
- return get(collection, 'status', 'draft') === 'underReview'
+ return (
+ get(collection, 'status', 'draft') === 'underReview' &&
+ ownRecommendation.length === 0
+ )
}
--
GitLab