From a031371bbb066dd334d61fb2d9daa8b729e072dd Mon Sep 17 00:00:00 2001
From: Alexandru Munteanu <alexandru.munt@gmail.com>
Date: Tue, 19 Jun 2018 16:20:06 +0300
Subject: [PATCH] fix(authsome): fix recommendations patch
---
.../src/routes/fragmentsRecommendations/patch.js | 6 +-----
packages/component-manuscript/src/components/utils.js | 1 -
packages/xpub-faraday/config/authsome-mode.js | 2 +-
3 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/packages/component-manuscript-manager/src/routes/fragmentsRecommendations/patch.js b/packages/component-manuscript-manager/src/routes/fragmentsRecommendations/patch.js
index cda67212c..e2dfc1a65 100644
--- a/packages/component-manuscript-manager/src/routes/fragmentsRecommendations/patch.js
+++ b/packages/component-manuscript-manager/src/routes/fragmentsRecommendations/patch.js
@@ -29,12 +29,8 @@ module.exports = models => async (req, res) => {
})
const authsome = authsomeHelper.getAuthsome(models)
- const authsomeObject =
- recommendation.recommendationType === 'editorRecommendation'
- ? collection
- : fragment
const target = {
- authsomeObject,
+ fragment,
path: req.route.path,
}
const canPatch = await authsome.can(req.user, 'PATCH', target)
diff --git a/packages/component-manuscript/src/components/utils.js b/packages/component-manuscript/src/components/utils.js
index d9785efb4..47c080f7e 100644
--- a/packages/component-manuscript/src/components/utils.js
+++ b/packages/component-manuscript/src/components/utils.js
@@ -139,7 +139,6 @@ const onChange = (
) => {
const newValues = parseReviewRequest(values)
const prevValues = parseReviewRequest(previousValues)
-
if (!isEqual(newValues, prevValues)) {
dispatch(autosaveRequest())
if (newValues.id) {
diff --git a/packages/xpub-faraday/config/authsome-mode.js b/packages/xpub-faraday/config/authsome-mode.js
index 8da1d852c..de9c03f99 100644
--- a/packages/xpub-faraday/config/authsome-mode.js
+++ b/packages/xpub-faraday/config/authsome-mode.js
@@ -201,7 +201,7 @@ async function authenticatedUser(user, operation, object, context) {
// allow reviewer to patch his recommendation
if (
get(object, 'path') ===
- '/api/collections/:collectionId/fragments/:fragmentId/recommendations'
+ '/api/collections/:collectionId/fragments/:fragmentId/recommendations/:recommendationId'
) {
return helpers.hasPermissionForObject({
user,
--
GitLab