From a57327ad7d021cc7e90c1497e49974a142b693b0 Mon Sep 17 00:00:00 2001
From: Daniel Sandu <daniel.sandu@thinslices.com>
Date: Tue, 16 Oct 2018 17:21:38 +0300
Subject: [PATCH] feat: Add data-test-id's for automation testing

---
 packages/component-faraday-ui/src/AuthorCard.js            | 5 +++++
 packages/component-faraday-ui/src/SortableList.js          | 1 +
 packages/component-faraday-ui/src/WizardAuthors.js         | 6 +++++-
 packages/component-faraday-ui/src/modals/MultiAction.js    | 6 ++++--
 .../component-faraday-ui/src/modals/SingleActionModal.js   | 2 +-
 .../components-faraday/src/components/Admin/AdminUsers.js  | 7 ++++++-
 6 files changed, 22 insertions(+), 5 deletions(-)

diff --git a/packages/component-faraday-ui/src/AuthorCard.js b/packages/component-faraday-ui/src/AuthorCard.js
index 3778a82ba..bb4112cc6 100644
--- a/packages/component-faraday-ui/src/AuthorCard.js
+++ b/packages/component-faraday-ui/src/AuthorCard.js
@@ -158,6 +158,7 @@ const AuthorEdit = ({
         <Label required>Email</Label>
         <ValidatedField
           component={TextField}
+          data-test-id="author-card-email"
           name="email"
           validate={[required, validators.emailValidator]}
         />
@@ -166,6 +167,7 @@ const AuthorEdit = ({
         <Label required>First name</Label>
         <ValidatedField
           component={TextField}
+          data-test-id="author-card-firstname"
           name="firstName"
           validate={[required]}
         />
@@ -174,6 +176,7 @@ const AuthorEdit = ({
         <Label required>Last name</Label>
         <ValidatedField
           component={TextField}
+          data-test-id="author-card-lastname"
           name="lastName"
           validate={[required]}
         />
@@ -182,6 +185,7 @@ const AuthorEdit = ({
         <Label required>Affiliation</Label>
         <ValidatedField
           component={TextField}
+          data-test-id="author-card-affiliation"
           name="affiliation"
           validate={[required]}
         />
@@ -192,6 +196,7 @@ const AuthorEdit = ({
           component={input => (
             <Menu {...input} options={countries} placeholder="Please select" />
           )}
+          data-test-id="author-card-country"
           name="country"
         />
       </Item>
diff --git a/packages/component-faraday-ui/src/SortableList.js b/packages/component-faraday-ui/src/SortableList.js
index f6bd63d6e..b0bca13ab 100644
--- a/packages/component-faraday-ui/src/SortableList.js
+++ b/packages/component-faraday-ui/src/SortableList.js
@@ -101,6 +101,7 @@ const SortableList = ({
   <Fragment>
     {items.map((item, i) => (
       <DecoratedItem
+        data-test-id={`add-author-id-${i}`}
         dragHandle={dragHandle}
         index={i}
         item={item}
diff --git a/packages/component-faraday-ui/src/WizardAuthors.js b/packages/component-faraday-ui/src/WizardAuthors.js
index 29d3c90a5..7ea00f08d 100644
--- a/packages/component-faraday-ui/src/WizardAuthors.js
+++ b/packages/component-faraday-ui/src/WizardAuthors.js
@@ -73,7 +73,11 @@ const WizardAuthors = ({
     <Row alignItems="center" justify="flex-start">
       <Item>
         <Label>Authors</Label>
-        <ActionLink icon="plus" onClick={addNewAuthor}>
+        <ActionLink
+          data-test-id="add-author"
+          icon="plus"
+          onClick={addNewAuthor}
+        >
           ADD AUTHOR
         </ActionLink>
       </Item>
diff --git a/packages/component-faraday-ui/src/modals/MultiAction.js b/packages/component-faraday-ui/src/modals/MultiAction.js
index c947ac0f9..348be329d 100644
--- a/packages/component-faraday-ui/src/modals/MultiAction.js
+++ b/packages/component-faraday-ui/src/modals/MultiAction.js
@@ -32,8 +32,10 @@ const MultiAction = ({
         <Spinner size={3} />
       ) : (
         <Fragment>
-          <Button onClick={onClose}>{cancelText}</Button>
-          <Button onClick={onConfirm} primary>
+          <Button data-test-id="modal-cancel" onClick={onClose}>
+            {cancelText}
+          </Button>
+          <Button data-test-id="modal-confirm" onClick={onConfirm} primary>
             {confirmText}
           </Button>
         </Fragment>
diff --git a/packages/component-faraday-ui/src/modals/SingleActionModal.js b/packages/component-faraday-ui/src/modals/SingleActionModal.js
index 49a9ec109..44385a9e7 100644
--- a/packages/component-faraday-ui/src/modals/SingleActionModal.js
+++ b/packages/component-faraday-ui/src/modals/SingleActionModal.js
@@ -21,7 +21,7 @@ const SingleActionModal = ({
     </Icon>
     {title && <H2>{title}</H2>}
     {subtitle && <Text secondary>{subtitle}</Text>}
-    <Button onClick={onClick} primary>
+    <Button data-test-id="modal-confirm" onClick={onClick} primary>
       {confirmText}
     </Button>
   </Root>
diff --git a/packages/components-faraday/src/components/Admin/AdminUsers.js b/packages/components-faraday/src/components/Admin/AdminUsers.js
index 0fc513019..b29d70d42 100644
--- a/packages/components-faraday/src/components/Admin/AdminUsers.js
+++ b/packages/components-faraday/src/components/Admin/AdminUsers.js
@@ -45,7 +45,12 @@ const Users = ({
   <Fragment>
     <Row alignItems="center" justify="space-between" mb={1}>
       <Item alignItems="center">
-        <ActionLink icon="arrow-left" mr={2} onClick={history.goBack}>
+        <ActionLink
+          data-test-id="go-to-dashboard"
+          icon="arrow-left"
+          mr={2}
+          onClick={history.goBack}
+        >
           Admin Dashboard
         </ActionLink>
         <AddUser
-- 
GitLab