From b4b3de30f27ff96fca9f9109cf84de4ebf30c747 Mon Sep 17 00:00:00 2001
From: Bogdan Cochior <bogdan.cochior@thinslices.com>
Date: Fri, 29 Jun 2018 15:03:46 +0300
Subject: [PATCH] refactor(authsome-helpers): do not mutate object
---
packages/xpub-faraday/config/authsome-helpers.js | 2 +-
packages/xpub-faraday/tests/authsome-helpers.test.js | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/packages/xpub-faraday/config/authsome-helpers.js b/packages/xpub-faraday/config/authsome-helpers.js
index b4d065ef7..56f1495a3 100644
--- a/packages/xpub-faraday/config/authsome-helpers.js
+++ b/packages/xpub-faraday/config/authsome-helpers.js
@@ -142,7 +142,7 @@ const stripeCollectionByRole = (coll = {}, role = '') => {
const { handlingEditor } = coll
if (!authorAllowedStatuses.includes(coll.status)) {
- coll = {
+ return {
...coll,
handlingEditor: handlingEditor &&
handlingEditor.isAccepted && {
diff --git a/packages/xpub-faraday/tests/authsome-helpers.test.js b/packages/xpub-faraday/tests/authsome-helpers.test.js
index 97d6798bb..cdc942b01 100644
--- a/packages/xpub-faraday/tests/authsome-helpers.test.js
+++ b/packages/xpub-faraday/tests/authsome-helpers.test.js
@@ -136,7 +136,7 @@ describe('Authsome Helpers', () => {
})
expect(recommendations).toHaveLength(0)
})
- it('stripeFragment - author should see reviews only if recommendation has been made', () => {
+ it('stripeFragment - author should see reviews only if recommendation has been made and only public ones', () => {
const { fragment } = testFixtures.fragments
fragment.recommendations = [
{
@@ -157,7 +157,7 @@ describe('Authsome Helpers', () => {
role: 'author',
status: 'revisionRequested',
})
- const privateComments = get(result, 'recommendations[0].comments')
- expect(privateComments).toHaveLength(1)
+ const publicComments = get(result, 'recommendations[0].comments')
+ expect(publicComments).toHaveLength(1)
})
})
--
GitLab